April 2020 - Koha-bugs - lists.koha-community.org

[Bug 24219] New: Elasticsearch needs to remember sort preference when returning to result list
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Bug ID: 24219 Summary: Elasticsearch needs to remember sort preference when returning to result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: mkstephens(a)lancasterseminary.edu At the present, the sort preference applied to a list of results in the staff client is not remembered when the user returns to the result list after viewing a record. Ideally, clicking on the button to return to the result list should remember the sort preference selected prior to viewing a record. Steps to replicate: 1. Have Elasticsearch enabled 2. Perform a search in the staff client 3. Change the sort order to something different (try Author A-Z) 4. Click on a result to view the record 5. Click on "Results" button on left side to return to result list 6. Note that the result list is sorted by relevancy again and not call number Note: On master, the OPAC remembers sort order in both the "browse results" and "back to results" link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 24356] New: objects.search prefetch
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Bug ID: 24356 Summary: objects.search prefetch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It would be great if objects.search added the prefetch automatically when an embed action is requested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 44

[Bug 11703] Convert checkouts table to ajax datatable
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25042 [Bug 25042] Koha::Schema::Result::Reserve redefines item and biblio rs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #147 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102281&action=e… Bug 4461: Fix OPAC link from staff QA: We have a security issue here, we should not make this link clickable from the staff side. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #146 from David Nind <david(a)davidnind.com> --- Thanks Jonathan for figuring out the problem! Applying Bug 25040 before applying 4461 fixes the problem. When someone gets a chance to fix item 2 (pretty minor - but I don't know how to fix the template) from Comment 139 I'll happily sign off. David -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #145 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to David Nind from comment #141) > Created attachment 102253 [details] > Bug 4461: Error log when using MySQL 5.5 > > I've attached the error log when testing on koha-testing-docker with MySQL v > 5.5 (started with ku) when submitting a problem report when 'A librarian' is > selected. The important line was the first one: 135 Something wrong happened when sending the report problem: The method Koha::Library->get_effective_email is not covered by tests! Sorry David I missed that when rebasing the patches. That should be fixed by the last patch. I am resetting to NSO, but you will need to apply patch from bug 25040, if not pushed yet. I do not have time to retest this feature right now, if you face errors again, please to not spend too much time and FQA it immediatly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi all, I've rebased the first two commits against master and done a followup patch to address Josef's points in comment #12 and #13. Please let me know if I should remove the sign off line in the first commit, and if there are further changes to these commits you feel would be useful. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #144 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102279&action=e… Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #16 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 102278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102278&action=e… Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #143 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to David Nind from comment #140) > This is the error in the plack-error.log after submitting the problem report > in the OPAC (using MariaDB): > > 36 DBD::mysql::st execute failed: Incorrect datetime value: > 'current_timestamp()' for column > `koha_kohadev`.`problem_reports`.`created_on` at row 1 [for Statement > "INSERT INTO `problem_reports` ( `borrowernumber`, `branchcode`, `content`, > `created_on`, `problempage`, `reci pient`, `title`, `username`) VALUES ( > ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="51", 1='CPL', 2="Test 145", > 3='current_timestamp() ', 4="http://kohadev.myDNSname.org:8080/", > 5="admin", 6="Test 145", 7='koha'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > 37 DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: > 'current_timestamp()' for column `koha_kohadev`.`problem_reports`. > `created_on` at row 1 at /kohadevbox/koha/Koha/Object.pm line 164 > 38 Something wrong happened when sending the report problem: Invalid value > passed, problem_reports.created_on=current_timestamp() expected type is > datetime at /kohadevbox/koha/opac/opac-reportproblem.pl line 131. This is coming from a bug in master, see bug 25040. -- You are receiving this mail because: You are watching all bug changes.

1 0