April 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #146 from David Nind <david(a)davidnind.com> --- Thanks Jonathan for figuring out the problem! Applying Bug 25040 before applying 4461 fixes the problem. When someone gets a chance to fix item 2 (pretty minor - but I don't know how to fix the template) from Comment 139 I'll happily sign off. David -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #145 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to David Nind from comment #141) > Created attachment 102253 [details] > Bug 4461: Error log when using MySQL 5.5 > > I've attached the error log when testing on koha-testing-docker with MySQL v > 5.5 (started with ku) when submitting a problem report when 'A librarian' is > selected. The important line was the first one: 135 Something wrong happened when sending the report problem: The method Koha::Library->get_effective_email is not covered by tests! Sorry David I missed that when rebasing the patches. That should be fixed by the last patch. I am resetting to NSO, but you will need to apply patch from bug 25040, if not pushed yet. I do not have time to retest this feature right now, if you face errors again, please to not spend too much time and FQA it immediatly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi all, I've rebased the first two commits against master and done a followup patch to address Josef's points in comment #12 and #13. Please let me know if I should remove the sign off line in the first commit, and if there are further changes to these commits you feel would be useful. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #144 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102279&action=e… Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #16 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 102278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102278&action=e… Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #143 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to David Nind from comment #140) > This is the error in the plack-error.log after submitting the problem report > in the OPAC (using MariaDB): > > 36 DBD::mysql::st execute failed: Incorrect datetime value: > 'current_timestamp()' for column > `koha_kohadev`.`problem_reports`.`created_on` at row 1 [for Statement > "INSERT INTO `problem_reports` ( `borrowernumber`, `branchcode`, `content`, > `created_on`, `problempage`, `reci pient`, `title`, `username`) VALUES ( > ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="51", 1='CPL', 2="Test 145", > 3='current_timestamp() ', 4="http://kohadev.myDNSname.org:8080/", > 5="admin", 6="Test 145", 7='koha'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > 37 DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: > 'current_timestamp()' for column `koha_kohadev`.`problem_reports`. > `created_on` at row 1 at /kohadevbox/koha/Koha/Object.pm line 164 > 38 Something wrong happened when sending the report problem: Invalid value > passed, problem_reports.created_on=current_timestamp() expected type is > datetime at /kohadevbox/koha/opac/opac-reportproblem.pl line 131. This is coming from a bug in master, see bug 25040. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #15 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 102276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102276&action=e… Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #14 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 102275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102275&action=e… Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé <dilan(a)calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 02 Apr '20

02 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0