May 2020 - Koha-bugs - lists.koha-community.org

[Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 David Roberts <david.roberts(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.roberts(a)ptfs-europe.c | |om --- Comment #5 from David Roberts <david.roberts(a)ptfs-europe.com> --- Signed off, although I couldn't see the string in /cgi-bin/koha/opac-review.pl?biblionumber=1'-alert(1)-'abcdefghi&reviewid=1&review= even before the patch was applied. The first URL is certainly fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 David Roberts <david.roberts(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104064|0 |1 is obsolete| | --- Comment #4 from David Roberts <david.roberts(a)ptfs-europe.com> --- Created attachment 104850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104850&action=e… Bug 25339: Validate biblionumber on opac-basket.pl and opac-review.pl This patch runs biblionumber through the int() function before using it in the application. Test Plan: 1) Apply patch 2) Go to /cgi-bin/koha/opac-basket.pl?bib_list=1/abcdefghi'-alert(1)-'j&verbose=1 3) Note that you can't find abcdefghi in the HTML. You only see biblionumber 1. 4) Go to /cgi-bin/koha/opac-review.pl?biblionumber=1'-alert(1)-'abcdefghi&reviewid=1&review= 5) Note that you can't find abcdefghi in the HTML. You only see biblionumber 1. Signed-off-by: David Roberts <david(a)koha-ptfs.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25421] New: Inconsistent return value in Koha::Libraries->pickup_locations
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25421 Bug ID: 25421 Summary: Inconsistent return value in Koha::Libraries->pickup_locations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 22284 In list context we sometimes return an array, or an arrayref: 84 return $libraries->unblessed unless $item or $biblio; 110 return wantarray ? @pickup_locations : \@pickup_locations; It causes the following error: ARRAY(0x55cb36339ec0) at /usr/share/perl5/CGI/Compile.pm line 137. Template process failed: undef error - Not a HASH reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 129. at /kohadevbox/koha/C4/Templates.pm line 122 C4::Templates::output('C4::Templates=HASH(0x55cb355b7a40)') called at /kohadevbox/koha/reserve/request.pl line 764 When doing: Have 1 bibliographic record with 1 item on it Place 1 biblio level hold Delete the item (from moredetail.pl) Go to the hold list Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 23787] New: AUTO_RENEWALS is not in sample_notices.sql
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Bug ID: 23787 Summary: AUTO_RENEWALS is not in sample_notices.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org I wanted to translate the AUTO_RENEWALS notice, but it's not in the sample_notices.sql. It is only in the updatedatabase.pl Martin confirmed on IRC that it should be in both. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 56

[Bug 20884] New: Stale data remaining in cache after koha-remove
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 Bug ID: 20884 Summary: Stale data remaining in cache after koha-remove Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: jcharaoui(a)cmaisonneuve.qc.ca QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Created attachment 75836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75836&action=ed… 0001-Restart-memcached-after-koha-remove-if-needed.patch After running koha-remove, stale data remains in within the memcached server. Say if an instance is deleted then recreated immediately, changed data such as database credentials isn't loaded into the cache, resulting in strange, difficult to troubleshoot problems. The solution would be to flush memcached cache at the end of koha-remove. The most straightforward method to do this is simply restart the service. See attached patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Bonus points.. check that the offsets (account details) make sense from each perspective.. looking at them from the payment, refund credit and overdue fine perspectives. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Test Plan.. play with accounts and backdated returns.. report any oddities. More seriously. Test One 1 - Checkout an item to a patron and make it overdue (can backdate the checkout) 2 - Make sure the itemtype has fines that will be charged 3 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 4 - Check the fine appears on the patrons account 5 - Browse to Circulation->Check in 6 - In 'Checkin settings' backdate to before the due date 7 - Check the fine no longer appears on the patrons account Test Two 1 - Checkout an item to a patron and make it overdue (can backdate the checkout) 2 - Make sure the itemtype has fines that will be charged 3 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 4 - Check the fine appears on the patrons account 5 - Pay off the fine 6 - Browse to Circulation->Check in 7 - In 'Checkin settings' backdate to before the due date 8 - Check the fine still appears on the patrons account (but is now 'zero' and fixed) 9 - Check that there is a credit on the patrons account for the amount they originally paid -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 13 May '20

13 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0