May 2020 - Koha-bugs - lists.koha-community.org

[Bug 25422] New: P0poY
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25422 Bug ID: 25422 Summary: P0poY Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard(a)myacpl.org Reporter: kianrenja(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 104574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104574&action=e… Uwaw Halo shayank aku datang -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #94 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Okay, last chance for string freeze. @RM: As my latest comments indicate, I am not completely enthusiastic about aspects of this patch set. But no definitive blocker on the other hand.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #93 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104571&action=e… Bug 8132: (QA follow-up) Missing filter Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103169|0 |1 is obsolete| | --- Comment #92 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104570&action=e… Bug 8132: Adding message when deleting from the UI Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103168|0 |1 is obsolete| | --- Comment #91 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104569&action=e… Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103167|0 |1 is obsolete| | --- Comment #90 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104568&action=e… Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Apply the patches Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold from B2 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103166|0 |1 is obsolete| | --- Comment #89 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104567&action=e… Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25373] New: Bug 23290 Security fix break all XSLT entities
by bugzilla-daemon＠bugs.koha-community.org 08 May '20

08 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25373 Bug ID: 25373 Summary: Bug 23290 Security fix break all XSLT entities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org By default display XSL have : <!DOCTYPE stylesheet [<!ENTITY nbsp " " >]> Since Bug 23290   are replaced with nothing, mangling xsl style sheet output. Worse if nbsp is inside a xslt:text tag some (all?) xml parsers return an error with an empty output. Error: xsltParseTemplateContent: xslt:text content problem compilation error: file /home/koha/webdatas/public/XSLT/OPACResults.xsl element text xsltParseTemplateContent: xslt:text content problem at /home/koha/src/Koha/XSLT_Handler.pm line 343. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16