June 2020 - Koha-bugs - lists.koha-community.org

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100066|0 |1 is obsolete| | --- Comment #66 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 106134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106134&action=e… Bug 15400: (follow-up) Updating text display Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and search results Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100065|0 |1 is obsolete| | --- Comment #65 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 106133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106133&action=e… Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkout or hold request periods overlap with existing holds
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #88 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Alex, can you please rebase and test this patch really carefully? I looked at the code a while ago and had a feeling that some things probably weren't quite right due to previous rebasing. 98672 - Bug 15261: Check if checkout/reserve request overlaps existing reserves Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15261: Check if checkout/reserve request overlaps existing reserves Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Reserves.pm M Koha/DateUtils.pm M circ/circulation.pl M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M opac/opac-reserve.pl M reserve/placerequest.pl M svc/renew M t/db_dependent/Circulation.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation.t Auto-merging svc/renew Auto-merging reserve/placerequest.pl Auto-merging opac/opac-reserve.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging circ/circulation.pl Auto-merging Koha/DateUtils.pm Auto-merging C4/Reserves.pm Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkout or hold request periods overlap with existing holds
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #207 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- At the moment this is blocked by bug 25539 and also needs a little rebase! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Really interesting feature, starting with QA tools: FAIL installer/data/mysql/atomicupdate/add_history.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt FAIL filters missing_filter at line 903 ( <a href="#" class="buttonHistory" id="[%- mv.id -%]">) missing_filter at line 904 ( <img src="[% interface %]/[% theme %]/img/icon-history.png" alt="History" title="Display history for this field" />) missing_filter at line 904 ( <img src="[% interface %]/[% theme %]/img/icon-history.png" alt="History" title="Display history for this field" />) missing_filter at line 908 ( <table class="history_table" id="[%- mv.id -%]_history" name="[%- mv.name -%]_history">) missing_filter at line 908 ( <table class="history_table" id="[%- mv.id -%]_history" name="[%- mv.name -%]_history">) missing_filter at line 916 ( <td><a href="#" data-tag='[%- mv.id -%]' data-history='[% hist.data %]' class='hist_rollback'>[% hist.data %]</a></td>) missing_filter a FAIL Koha/MetadataRecord/History.pm FAIL critic "return" statement with explicit "undef" at line 103, column 9. See page 199 of PBP. Can you please fix? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #298 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I have a sense of déjà vu with this one... :) 1) QA tools: FAIL t/db_dependent/Acquisition/Basketgroups.t OK critic FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 42) FAIL t/db_dependent/Acquisition/Basketgroups.t OK critic FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 42) FAIL acqui/basketgroup.pl OK critic FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 69) Can you please fix? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8732] Add a system preference to allow users to choose to display an icon based on the MARC control fields or based on the Koha biblio level itemtype
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #32 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 103548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103548 Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones Review of attachment 103548: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=873…) ----------------------------------------------------------------- This patch shows it's age a little, but let's work it out! ::: catalogue/detail.pl @@ +588,4 @@ > > $template->param (basketsorders => \@baskets_orders); > $template->param (basketsdeletedorders => \@baskets_deletedorders); > +$template->{VARS}->{'BiblioItemtypeImage'} = C4::Context->preference('BiblioItemtypeImage'); 1) This can be removed in favor us using the TT plugin in the template instead. ::: installer/data/mysql/atomicupdate/bug_8732_add_BiblioItemtypeImage_system_preference.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > + $dbh->do( "INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('BiblioItemtypeImage', 'Control','Control what biblio level itemtype image displays','Control|Koha','Choice')" ); 2) Please switch to INSERT IGNORE INTO... ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref @@ +275,5 @@ > + - pref: BiblioItemtypeImage > + choices: > + Control: "MARC control fields" > + Koha: "Koha biblio level itemtype" > + - "This preference only affects MARC21 XSLT views. 3) (pref description in yml file): Currently reads: Display itemtype information from the [MARC control fields|Koha biblio level itemtype] This preference only affects MARC21 XSLT views. I wonder if we could improve the description a little. a) In current version the icon this changes is labelled 'material type', so it might not be so easy to locate where and what happens here. b) We've been trying to remove biblio in favor of bibliographic c) missing punctuation :) Suggestion: Display [material type icon derived from MARC control fields|Koha record level item type icon] on detail and results pages in the OPAC. Only works for MARC21. (We are in the process of removing non-XSLT this release) But actually, I'd much prefer a more radical approach in merging this new pref with the existing DisplayIconsXSLT and DisplayOpacIconsXSLT prefs: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in the OPAC. Show [ no format, audience and material type information| the record level item type icon| format, audience and material type information derived from MARC control fields ] in XSLT MARC21 results and detail pages in the OPAC. This way, we'd not need a new pref and we could avoid the conflict of different settings (turn off display and turn on itemtype icon display = still nothing shows) And we'd have this controlled separately for OPAC and staff interface. But then we also got OpacNoItemTypeImages... just wondering how to get these all to play together in a way that is most clear to end users about the effects! ::: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl @@ +171,5 @@ > <xsl:with-param name="UseAuthoritiesForTracings" select="$UseAuthoritiesForTracings"/> > </xsl:call-template> > > + <xsl:if test="$BiblioItemtypeImage='Control'"> > + <xsl:if test="$DisplayIconsXSLT!='0' and $materialTypeCode!=''"> 4) Full quote: <xsl:if test="$BiblioItemtypeImage='Control'"> <xsl:if <test="$DisplayIconsXSLT!='0' and $materialTypeCode!=''"> I think this highlights a conceptual issue as we already have a pref dealing with the display of this information (DisplayIconsXSLT and DisplayOpacIconsXSLT - trying to explain in 3) Also there appears to be no code for the actual icon display? @@ +181,2 @@ > > <xsl:call-template name="show-lang-041"/> 5) I believe there is a merge/rebase error here - the xsl:if should be before the 041 display. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -134,5 @@ > - [% ELSE %] > - [% itemtype | html %] > - [% END %] > - ] [% END %] > - [% IF ( unititle ) %], [% unititle | html %][% END %] 6) Is this removed intentionally? @@ -246,4 @@ > <span class="results_summary year"><span class="label">Year: </span>[% copyrightdate | html %]</span> > [% END %] > > - [% UNLESS ( item_level_itypes ) %] Similar here (see above). ::: opac/opac-detail.pl @@ +1189,4 @@ > @serialcollections > 0 > ? 'serialcollection' : 'subscriptions'; > $template->param('defaulttab' => $defaulttab); > +$template->{VARS}->{'BiblioItemtypeImage'} = C4::Context->preference('BiblioItemtypeImage'); See above! ::: opac/opac-search.pl @@ +1024,4 @@ > $template->{VARS}->{DidYouMean} = > ( defined C4::Context->preference('OPACdidyoumean') > && C4::Context->preference('OPACdidyoumean') =~ m/enable/ ); > +$template->{VARS}->{'BiblioItemtypeImage'} = C4::Context->preference('BiblioItemtypeImage'); See above! -- You are receiving this mail because: You are watching all bug changes.

1 0