September 2020 - Koha-bugs - lists.koha-community.org

[Bug 26191] New: Relocate track_login call in Auth.pm (see 22543)
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26191 Bug ID: 26191 Summary: Relocate track_login call in Auth.pm (see 22543) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org >From bug 22543 comment30: (In reply to Jonathan Druart from comment #29) > 2. This code has been put before track_login_daily, is that expected? No. The track call should be done before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 25511] New: Add --force option to update_dbix_class_files.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Bug ID: 25511 Summary: Add --force option to update_dbix_class_files.pl Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Sometimes, if you know what you are doing, you may want to force a schema overwrite regardless of whether the hashes report there are changes above the fold. In these cases, we should expose said functionality via a --force option on the script. WARNING: Use this at your own risk.. it's helpful if you are maintaining a fork or in other such cases. You should always attempt to run the script without force first and only resort to using force if that fails. It is also very much worthwhile checking the diff after running with force to ensure you have not resulted in any unexpected changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 26232] New: undefined fine grace period kills koha
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Bug ID: 26232 Summary: undefined fine grace period kills koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: didier.gautheron(a)biblibre.com Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Staff can create smart rules with empty (undefined) grace period, but then koha returns an internal error in : DateTime::Duration::new('DateTime::Duration', 'days', undef) called at /kohadevbox/koha/C4/Circulation.pm line 2395 C4::Circulation::_calculate_new_debar_dt(HASH(0x564b11658e58)', 'HASH(0x564b11836c28)', 'DateTime=HASH(0x564b1164d688)', 'DateTime=HASH(0x564b116787d0)') called at /kohadevbox/koha/C4/Circulation.pm line 2451 -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 26018] New: Not all subfields for the following tags are in the same tab (or marked 'ignored')
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Bug ID: 26018 Summary: Not all subfields for the following tags are in the same tab (or marked 'ignored') Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: psmukhopadhyay(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In a fresh install of Koha 20.05.01.000 the 'MARC bibliographic framework test' fails in one point reporting that "Not all subfields for the following tags are in the same tab (or marked 'ignored')" for all preloaded formats (Default to VR). In every case invariably the culprit is subfield 2 of the below mentioned tags - 240(1,2) | 700 (1,7) | 710 (1,7) | 711 (1,7) | 730 (1,7) | 758 (1,7) | 800 (1,8) | 810 (1,8) | 811 (1,8) | 830 (1,8). The numbers within parenthesis indicate tabs are in use. It only occurs in case of a fresh installation of 20.05.01 loaded with default formats (Default, AR, BKS, CF, IR, KT, SER, SR, VR), not with the upgradations of 18.x or 19.x to 20.05.01 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 26506] New: Koha::Account::pay will fail if $userenv is not set
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '20

17 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 Bug ID: 26506 Summary: Koha::Account::pay will fail if $userenv is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: matthias.meusburger(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Koha::Account::pay will fail if $userenv is not set. The context would be a payment plugin for the opac, in which the payment system will call a callback URL to confirm the payment has been made. In this situation, no user is logged in when the plugin uses Koha::Account::pay. The problem is that the following line in Koha::Account::pay: my $manager_id = $userenv ? $userenv->{number} : 0; will result in an SQL error, since $userenv->{number} is not set, and 0 is not an acceptable value because of foreign key constraint: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_hkr`.`accountlines`, CONSTRAINT `accountlines_ibfk_borrowers_2` FOREIGN KEY (`manager_id`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) By the way, if you have a look at C4/Accounts.pm, in the manualinvoice function: my $manager_id = C4::Context->userenv ? C4::Context->userenv->{'number'} : undef; $manager_id will be set to undef, which will not fail, since undef is an acceptable value regarding to SQL foreign key constraints. It's hard to provide a test plan, since it relies on a plugin, sorry, but I will try to answer to any question :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 26148] New: OpenLibrary "Preview" link target is unclear to patrons
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '20

16 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Bug ID: 26148 Summary: OpenLibrary "Preview" link target is unclear to patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When you have OpenLibraryCovers turned on, there will be a "Preview" link showing below the cover that leads to the Open Library page of the title. I think we should make clear in the wording that the link is an external link that will lead you outside the library catalog and it should also open in a new tab. To test: - Activate OpenLibraryCovers - Search (in sample data) for: 0140423826 -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 26172] New: Add a cashup summary view
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '20

16 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Bug ID: 26172 Summary: Add a cashup summary view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 24820 Blocks: 13985 Bug 23355 adds a process for recording cash register cashups; however it does not expose the captured cashup data, leaving that to the end user via reports. This bug serves as a request for enhancement to add a way to display a quick summary of the transactions that have make up a cashup set. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 70

[Bug 26584] New: Remove unused C4::Acquisition::CloseBasket function
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '20

16 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 Bug ID: 26584 Summary: Remove unused C4::Acquisition::CloseBasket function Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 26582 makes it obsolete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 26582] New: Add Koha::Acquisition::Basket->close
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '20

16 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Bug ID: 26582 Summary: Add Koha::Acquisition::Basket->close Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This method should implement the current behaviour: - Mark all open orders as 'requested' - Mark the basket as closed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 23823] New: Allow system preferences to be bookmarked
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '20

16 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Bug ID: 23823 Summary: Allow system preferences to be bookmarked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: helix84(a)centrum.sk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 94271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94271&action=ed… screenshot Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 43