January 2021 - Koha-bugs - lists.koha-community.org

[Bug 25381] New: XSLTs should not define entities
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25381 Bug ID: 25381 Summary: XSLTs should not define entities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Bug 23290 explicitly disabled entity expansion during XML parsing for security reasons. However, many XSLTs define the following entity: <!ENTITY nbsp " " > They don't use the entity &nbsp, but its presence could lead to confusion (as noted in Bug 25373). These entities should be removed from the XSLTs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 27148] New: Internal Server Error during self registration 20.11
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Bug ID: 27148 Summary: Internal Server Error during self registration 20.11 Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: jan.michael.mueck(a)uni-hamburg.de QA Contact: testopia(a)bugs.koha-community.org Internal Server Error during self registration if categorycode is checked in PatronSelfRegistrationBorrowerUnwantedField. Error could be reproduced. Installation was updated from 19.05 where is worked fine. IRC Chat: [14:20] <Guest7457> Hello, i just updatet to 20.11. and try to register a new patreon in opac. Upon submitting the form i get an internal server error. Plack-Error.log shows "[You must provide a patron's category to validate password's strength and length]". In the Form there is a message to provide a password with undefind lenght. In the administrator setting the passwor lenght is defindet as 4 letters minimum. Can anyone help? [14:31] <cait1> do you have patron categories defiend in your system? is the field hidden from the patron form maybe? [15:12] <Guest7457> @cait1 We have got some categorys defined but can you tell me where i can check the visibility setting? The setup worked fine before the update btw. [15:12] <huginn> Guest7457: I'll give you the answer just as soon as RDA is ready [15:12] <wahanui> i already had it that way, huginn. [15:18] <Joubu> Guest7457: can you open a bug report please? [15:18] <Joubu> I do recreate the problem if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" About Koha: Koha-Version: 20.11.00.000 OS Version ('uname -a'): Linux www2 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 Perl Interpreter: /usr/bin/perl Perl-Version: 5.030000 Perl @INC: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/testothek/plugins MySQL-Version: mysql Ver 15.1 Distrib 10.3.25-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 Apache-Version: Server version: Apache/2.4.41 (Ubuntu) PSGI: Plack (deployment) Memcached: Server: 127.0.0.1:11211 | Namespace: koha_testothek | Status: wird ausgeführt. | Konfiguration gelesen aus: koha-conf.xml Zebraversion: Zebra 2.1.4 (C) 1994-2017, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: 45c729bb18ecdd3e0455f47765700b1c9754b1ce Using ICU Message Broker: Status: wird ausgeführt Datum und Zeit: 03.12.2020 15:28 -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 24447] New: POD of C4::Members::Messaging::GetMessagingPreferences() is misleading
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24447 Bug ID: 24447 Summary: POD of C4::Members::Messaging::GetMessagingPreferences() is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Part of the POD for this subroutine looks like this: 42 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrower->{'borrowernumber'}, 43 message_name => 'DUE' } ); 44 45 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY', 46 message_name => 'DUE' } ); It looks like the value for message_name should be a value from letter.code, but it should be a name from message_attributes.message_name: 75 AND message_transports.is_digest = borrower_message_preferences.wants_digest 76 WHERE message_attributes.message_name = ? 77 END_SQL 78 79 my @bind_params = ( $params->{'message_name'} ); Note: This subroutine is set to be renamed and moved by Bug 18595, but the POD seems to be untouched there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 22152] New: Hide printing the tools navigation when printing reports
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152 Bug ID: 22152 Summary: Hide printing the tools navigation when printing reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Hide the navigation showing up on the left side when printing a report page. (see 22147 for reference) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 27543] New: Tooltip on opac-messaging.pl obscured by table headers
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 Bug ID: 27543 Summary: Tooltip on opac-messaging.pl obscured by table headers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org Created attachment 115755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115755&action=e… Tooltip obscured by table headers Whilst testing bug 27493, I noticed that the tooltip for 'Digests only' in opac-messaging.pl is obscured by the table headers. To recreate: 1) Log into the OPAC 2) Go to 'your messaging' /opac-messaging.pl 3) Hover over the Digests only tooltip 4) Note that the tooltip appears on the same line as the headers, so is partially obscured I've added a screenshot to the report. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 27508] New: Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display"
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27508 Bug ID: 27508 Summary: Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Cataloging Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, nugged(a)gmail.com, slavashishkin(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 27446] New: Markup errors in suggestion/suggestion.tt
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Bug ID: 27446 Summary: Markup errors in suggestion/suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org While working on a separate issue I notices there are several markup errors in suggestion/suggestion.tt. 1. <h2> tag closes with an </h3> 2. Some button elements are using the self-closing syntax when they should not 3. <div id="limits> does not close 4. There are some stray </div>'s 5. Indentation/white could be better -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 27034] New: $c->objects->search shouldn't use path parameters
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 Bug ID: 27034 Summary: $c->objects->search shouldn't use path parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The objects.search Mojolicious helper incorrectly adds path parameters to the query for filtering. This works, trivially for plat routes like: GET /patrons/:patron_id or for routes that really have links like (fictional example): GET /patrons/:patron_id/holds In the latter, we already know there's a link borrowers<->reserves so searching holds and filtering by the borrowernumber will work. About this there are two things to consider: - That's not how we are coding, we are actually picking the patron_id manually and using object methods to access the resultset: my $patron = Koha::Patrons->find( $c->validation->param('patron_id') ); ... my $holds_rs = $patron->holds; my $holds = $c->objects->search({ resultset => $holds_rs }); - If we have more tricky examples like: GET /holds/:hold_id/pickup_locations it is obvious that hold_id doesn't make any sense for Koha::Libraries, so filtering on it actually causes an exception. One option is to manually remove the problematic path parameters in the controller: my $hold_id = $c->validation->param('hold_id'); my $hold = Koha::Holds->find( $hold_id ); delete $c->validation->output->{'hold_id'}; my $pickup_locations_rs = $hold->pickup_locations; my $pickup_locations = $c->objects->search( $pickup_locations_rs ); My feeling is that we should be following the current pattern, and not really use the path parameters in objects.search. If we later need some handling in the generic objects->search helper, we can reintroduce it, but we need a real use case, which cannot be found in the codebase yet. It all points towards not needing them there, and just getting in the middle with no gain (just the opposite). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 27352] New: Add GET /biblios/:biblio_id/items
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Bug ID: 27352 Summary: Add GET /biblios/:biblio_id/items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com It would be helpful to have that route. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 24810] New: French SQL files for "news" contain "Welcome into Koha 3!"
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '21

11 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24810 Bug ID: 24810 Summary: French SQL files for "news" contain "Welcome into Koha 3!" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com installer/data/mysql/fr-CA/facultatif/sample_news.sql installer/data/mysql/fr-FR/2-Optionel/sample_news.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18