January 2021 - Koha-bugs - lists.koha-community.org

[Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Why setting the env vars to 0 and " "? I am expecting to have them set to an empty string. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 115870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115870&action=e… Bug 11257: (QA follow-up) Add thank you Even if we are grumpy because they still have not returned the items, we should be nice :) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 115869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115869&action=e… Bug 11257: (followup) Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices This patch changes the default text for the DUEDGST sample notice to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) are due: <<items.content>> (it does not include an atomic update) Test plan: 1. Select "edit" on DUEDGST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115672|0 |1 is obsolete| | Attachment #115673|0 |1 is obsolete| | Attachment #115674|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 115868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115868&action=e… Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> JD amended patch: Remove double spaces in PREDUEDST -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24643] New: Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24643 Bug ID: 24643 Summary: Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The RFC3339 spec (https://www.ietf.org/rfc/rfc3339.txt) says that the second component of a date/time can contain fractions of a second, e.g. 2011-10-05T14:48:00.000Z This is the format returned by Javascript's toISOString() function. Unfortunately, when dt_from_string encounters a string in this format, it effectively drops the time component entirely and you end up with: 2011-10-05T00:00:00Z The problem lies in the regex that attempts to match the string when dt_from_string is called with the 'rfc3339' parameter. Adding support for optional fractions is straightforward. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 14959] Support for Library Communications Framework (LCF)
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14959 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This appears to be slow gathering a bit more support: https://github.com/bic-org-uk/bic-lcf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 [Bug 27525] 'wich' instead of a 'with' in a sentence -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25898] New: Prohibit indirect object notation
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 Bug ID: 25898 Summary: Prohibit indirect object notation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Indirect object notation is when you write: my $cgi = new CGI; Recently announced Perl 7 (https://www.perl.com/article/announcing-perl-7/) will disable this notation by default. We should write instead: my $cgi = CGI->new Perl 7 does not have a release date yet, but it's better to be prepared :) This bug is for adding a rule in .perlcriticrc and removing all indirect object notations. -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 27517] New: Cannot add printer profile in strict mode
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27517 Bug ID: 27517 Summary: Cannot add printer profile in strict mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org [2021/01/21 19:43:02] [WARN] DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 [for Statement "INSERT INTO printers_profile (offset_vert, paper_bin, offset_horz, template_id, creator, units, creep_horz, creep_vert, printer_name) VALUES (?,?,?,?,?,?,?,?,?);" with ParamValues: 0="1", 1="3", 2="1", 3='', 4='Labels', 5="POINT", 6=0, 7=0, 8="Brother"] at /kohadevbox/koha/C4/Creators/Profile.pm line 162. [2021/01/21 19:43:02] [WARN] Database returned the following error on attempted INSERT: Incorrect integer value: '' for column 'template_id' at row 1 at /kohadevbox/koha/C4/Creators/Profile.pm line 164. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 9016] Multi transport types for notices
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '21

27 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva" -- You are receiving this mail because: You are watching all bug changes.

1 0