October 2021 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #380 from David Gustafsson <glasklas(a)gmail.com> --- (And I think it's probably much better to compare the whole record in the tests, you don't get as detailed feedback on failure, but on the other hand catches if there are unexpected modifications of other parts of the record which is more important). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #379 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Thanks David for your follow-ups. Martin and I are ready to help you here. We have enough time before the 21.11 freeze to make this new feature part of the next release :) Can you reply to the other open questions please? See below. I am volunteering to write the patches needed. (In reply to Martin Renvoize from comment #327) > (In reply to Jonathan Druart from comment #324) > > 2. We don't hide the admin page if the pref is off, is that expected? > > Whilst I agree with what you're saying here, I think if memory serves this > was discussed earlier in the bug and the authors wanted the ability to > create their rules and then enable them.. so they wanted to display the page > regardless or whether the pref was on or off (the page does warn you at the > top if the pref is off).. having said that.. I'd be happy to follow-up to > change that.. or, in my opinion in a later bug we could drop the pref and > instead have an 'enabled' flag at the rule level. It seems weird to have the pref off but the link to the admin page visible. > > 3. Should we link the pref to the admin page? > > Not sure what you're saying here? I meant, should we have a link to the admin page of the feature in the syspref's description. I can do it. > > 6. How does it interface with the marc modification templates when batch > > editing bibliographic records? > > Investigating.. I have a feeling his patchset predates it and I missed this > case ! :( Need to be investigated. (In reply to Jonathan Druart from comment #331) > I know librarians can have weird needs but, should we really offer the > "custom" preset? I am reading the tests right now and some combinations are > doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1 > "action" column with the predefined ones? (not considering this question a > blocker, but I would be happy to get an answer). Still waiting for an answer. See also the "warning"s and "fixme"s from the patch "Improve readbility of tests". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #378 from David Gustafsson <glasklas(a)gmail.com> --- Realized was very easy to fix, now tests should be working. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #377 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 125636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125636&action=e… Bug 14957: Exclude leader from saved/updated record comparison in tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #376 from David Gustafsson <glasklas(a)gmail.com> --- Appears to be some failing tests. I think I know why as encountered the same issue with another patch. Part of the leader field is now modified in Koha in ModBiblio, which was not the case before, so records appears to have changed when the data has not as the whole record is now checked, when only specific fields where before. Will have a look at this at monday. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #375 from David Gustafsson <glasklas(a)gmail.com> --- Fixed a regression introduced in commit, "Bug 14957: Clean controller". There was reason for that kludgy code even though it could be somewhat simplified. Also some imports that needed to be fixed after some subs no longer exported by default. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #374 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 125633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125633&action=e… Bug 14957: Fix imports in marc-overlay-rules.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #373 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 125632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125632&action=e… Bug 14957: Fix regression, rules must be refetched on add/edit/deletion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5920] Remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew(a)bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- +1 on this, it'd be a really handy option to have -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0