October 2021 - Koha-bugs - lists.koha-community.org

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43364|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- Created attachment 125648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125648&action=e… Bug 14999: Make sure order prices are not mixed-up We were shifting the price and replacement price for imported orders only after the line: > $duplinbatch = $import_batch_id and next if $duplifound; This lead to the "replacementprice" and "price" query parameters not being shifted/removed from the list if a duplicate record came across and caused the prices be applied to the next record being imported. To reproduce: 1) Download two records from koha to marcxml file, then cat those: cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Create a new order basket, then "Add to basket" using "From a staged file" option 5) Select both bib1 and bib2 and set price & replacement price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong prices, 99.00! 7) Apply patch and notice the prices are now correctly set to 88.00. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #8 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- So this turned out to be tricky to reproduce but I finally found at least one bug where this happens! So if there is a duplicate matched then we have not shifted away for the previous biblio to be added the replacement and price parameters: > replacementprice => shift( @orderreplacementprices ), > my $price= shift( @prices ) || GetMarcPrice($marcrecord, C4::Context->preference('marcflavour')); So when the line: > $duplinbatch = $import_batch_id and next if $duplifound; is called we are leaving the shifts undone. I wonder if we should go with the originally proposed patch here or just move the shifts to the beginning. If we just move the shifts to the beginning then I feel like it could be a bit more prone to someone re-introducing this bug later if a new field is added. To reproduce this bug: 1) Download two records from koha to marcxml file, then cat those cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Add new basket -> import from a staged file 5) Select both bib1 and bib2 and set price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong price, 99.00!! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |joonas.kylmala(a)iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #7 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- I was checking up what old bug reports I have done and came across this. Definitely a bug in the community version as well and a bug that still exists to this day! Seems pretty major as these are the prices you might send via EDI to the vendor. The bug is probably hard to reproduce but if you read the code you see the problem clearly. The GetImportRecordsRange function might return the imported records in whatever order and we are not matching them in anyway with the parameter data we are getting here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28201 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28534] New: pending_offline_circulations table uses MyISAM engine
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Bug ID: 28534 Summary: pending_offline_circulations table uses MyISAM engine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This appears to be a holdover that was never updated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 28412] New: Add supported authentication methods documentation
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28412 Bug ID: 28412 Summary: Add supported authentication methods documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com We should add a section about authentication mechanisms in swagger.yaml. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #382 from David Gustafsson <glasklas(a)gmail.com> --- And I think there are pedagogical reasons to keep the columns with the action choices and being able to see which ones are selected for each preset. Even though I understand it will be challenging for must librarians to understand the current rules concept, if we where to remove the separate actions (which now also have pretty good explanations), I think it would be much harder for people to understand exactly how rules are applied, and a higher risk for assuming work in some different way. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #381 from David Gustafsson <glasklas(a)gmail.com> --- Hi again! > It seems weird to have the pref off but the link to the admin page visible. I have not made any active decision regarding this, it's been like this since before I got involved and have never given it much thought. Don't have any strong opinions either way. Elasticsearch settings seems to work the same way, that is if SearchEngine is Zebra, you still have a "Search engine configuration (Elasticsearch)" link in Administration with a "Elasticsearch is currently disabled" notice at the top. So personally I would probably keep it as it is just to avoid the extra work (even though should be pretty easy to change). > > 6. How does it interface with the marc modification templates when batch > > editing bibliographic records? > > Investigating.. I have a feeling his patchset predates it and I missed this > case ! :( I don't have time to look at this today but can do on Monday. > I know librarians can have weird needs but, should we really offer the > "custom" preset? I am reading the tests right now and some combinations are > doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1 > "action" column with the predefined ones? (not considering this question a > blocker, but I would be happy to get an answer). I see no reason to remove this, I just don't see the harm of having the option if there is some weird scenario where it could be useful. I don't see the "custom" option as complicating the UI, it's just an extra choice in a dropdown. -- You are receiving this mail because: You are watching all bug changes.

1 0