November 2021 - Koha-bugs - lists.koha-community.org

[Bug 28578] New: Terminology: reserve/reservation should be hold
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28578 Bug ID: 28578 Summary: Terminology: reserve/reservation should be hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt:53 %s Set reserve to transit and transfer book to %s: %s %sCancel reservation and then attempt transfer: %s␠ -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 27539] New: Console warnings "Use of uninitialized value in split" on "Holds to pull" page
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Bug ID: 27539 Summary: Console warnings "Use of uninitialized value in split" on "Holds to pull" page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com, nugged(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 25440] New: Remove undef and CGI warnings and fix defaults in circulation rules
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Bug ID: 25440 Summary: Remove undef and CGI warnings and fix defaults in circulation rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: nugged(a)gmail.com Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I am proposing a set of fixes, which I found when doing another mine complicated circulation rules task: I will post separate patches one-by-one with explanations here. -- You are receiving this mail because: You are watching all bug changes.

1 40

[Bug 25491] New: Perl warning at the login page of installer
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Bug ID: 25491 Summary: Perl warning at the login page of installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: slavashishkin(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I encountered this warning at the login page of installer /cgi-bin/koha/installer/install.pl: Use of uninitialized value $info{"invalid_username_or_password"} in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm line 387. This requires a simple fix to check for undef before numeric comparison. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 25506] New: Perl undef warning on the "About Koha" page
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506 Bug ID: 25506 Summary: Perl undef warning on the "About Koha" page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: slavashishkin(a)gmail.com Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: nugged(a)gmail.com, stalkernoid(a)gmail.com Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 25695] New: Missing logging of $@ in onboarding.pl after eval block
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Bug ID: 25695 Summary: Missing logging of $@ in onboarding.pl after eval block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: slavashishkin(a)gmail.com Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, nugged(a)gmail.com, stalkernoid(a)gmail.com There is a forgotten warning in the second eval block just after the same eval block which has warning. This makes the error reason not logged. The solution is to add exactly the same ‘warn $@’ in consecutive eval block. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 25993] New: SIP2 server logs polluted with warnings about uninitialized value $key
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 Bug ID: 25993 Summary: SIP2 server logs polluted with warnings about uninitialized value $key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com, kyle(a)bywatersolutions.com Depends on: 20954 Changes from bug 20954 introduced the following warning in SIP2 server logs: > Use of uninitialized value $key in index at /kohadevbox/koha/C4/SIP/Sip/MsgType.pm line 337, <STDIN> line 2. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 [Bug 20954] Add ability to set syspref overrides in SIP as we can in Apache -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 26590] New: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26590 Bug ID: 26590 Summary: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org I get the following warning message in plack-error.log: > Use of uninitialized value $low in numeric lt (<) at /usr/share/koha/lib/Koha/Patron.pm line 1109. This seems to happen because in /cgi-bin/koha/admin/categories.pl you can set "Age required" field to be empty and then in the is_valid_age subroutine in Patron.pm we compare patroncategory->dateofbirthrequired to numeric value and empty string or undef is not numeric. We should either add input validation to categories.pl or convert dateofbirthrequired to numeric value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 27010] New: Warnings produced by Elasticsearch QueryBuilder.pm
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Bug ID: 27010 Summary: Warnings produced by Elasticsearch QueryBuilder.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm we get following warnings: > [WARN] Use of uninitialized value $f in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605. > [WARN] Use of uninitialized value $d in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605. This seems to be due to _convert_sort_fields() not checking whether my ( $f, $d ) get initialized by the regex before using them in the map function: > 601 grep { $_->{field} } map { > 602 my ( $f, $d ) = /(.+)_(.+)/; > 603 { > 604 field => $sort_field_convert{$f}, > 605 direction => $sort_order_convert{$d} > 606 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 27011] New: Warnings in returns.pl
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Bug ID: 27011 Summary: Warnings in returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you check-in some books you get the following warnings to error logs: > [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 164. > [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 402. This seems to be due to treating the patron fields as non-null values: > 164 my $name = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : ''; The DB schema allows NULL values (and I think that is okay) so we should check for every one of these whether the value is defined or not before using it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25