November 2021 - Koha-bugs - lists.koha-community.org

[Bug 29485] New: selenium/administration_tasks.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '21

24 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Bug ID: 29485 Summary: selenium/administration_tasks.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 19185 Since bug 19185, and Koha_Master running the tests after t/db_dependent/selenium/01-installation.t is ran, t/db_dependent/selenium/administration_tasks.t is failing randomly with: 12:32:59 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 12:32:59 koha_1 | (eval 1710):1 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | (eval 1712):2 in Selenium::Remote::Driver::__ANON__ 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command 12:32:59 koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in (eval) 12:32:59 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:170 in Selenium::Remote::Driver::find_element 12:32:59 koha_1 | t/db_dependent/selenium/administration_tasks.t:188 in t::lib::Selenium::click I don't recreate it locally. The screenshot of the failure shows that the screen is still on the authorised value list view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 [Bug 19185] Web installer and onboarding tool selenium test -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 29264] New: SIP config allows use of non-branchcode institution ids causes workers to die without responding
by bugzilla-daemon＠bugs.koha-community.org 24 Nov '21

24 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 Bug ID: 29264 Summary: SIP config allows use of non-branchcode institution ids causes workers to die without responding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If is entirely possible to create an SIP institution whose ID does not match a valid branchcode in Koha's SIP config. In fact, Koha's example SIP config contains an example of this ( kohalibrary / kohalibrary2 ). If a SIP login uses an institution with an id that doesn't match a valid branchcode, everything will appear to work, but the SIP worker will die anywhere that Koha gets the branch from the userenv and assumes it is valid. The repercussions of this are that actions such as the checkout message simply die and do not return a response message to the requestor. At the very least, we should output a warning to the SIP log. I think we should strongly consider disallowing institution ids in the SIP config that do not match valid branchcodes. In this scenario, attempting to start the SIP server should result in a error message with the SIP server exiting immediately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 1993] Task Scheduler Needs Re-write
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29558] New: Tabbing through item editor no longer works
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29558 Bug ID: 29558 Summary: Tabbing through item editor no longer works Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: bwsdonna(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Libraries are reporting a change to the way you can use the TAB button in the item editor. Prior to 21.05, you could use the TAB key to move through the item editor, hit tab and it would confirm the highlighted/upper choice and go to the next field. You can't just tab to Not For Loan, hit O (for Ordered), and hit tab to select that and jump to collection code. You now have to click and/or use enter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 19444] New: Automatic renewal script should not auto-renew if a patron' s record has expired
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Bug ID: 19444 Summary: Automatic renewal script should not auto-renew if a patron's record has expired Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: janet.mcgowan(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently with the automatic_renewals.pl script, materials are still auto-renewed even if the patron's account has expired. The automatic renewals script has error conditions which prevent automatic renewals in these circumstances: $error eq 'too_many' or $error eq 'on_reserve' or $error eq 'restriction' or $error eq 'overdue' or $error eq 'auto_too_late' or $error eq 'auto_too_much_oweing' or $error eq 'auto_too_soon The error conditions should take into account the expiry date of borrower and not auto renew if the borrower's account has expired. For example adding a new error code such as 'borrower_expired' - or whatever convention achieves this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 17979] New: Fatal error when searching from addbooks.pl due to ISBN flaw
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Bug ID: 17979 Summary: Fatal error when searching from addbooks.pl due to ISBN flaw Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org If you're doing a "Cataloging Search" from /cgi-bin/koha/cataloguing/addbooks.pl, and you type in "1st to die", you'll see the following: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 5 at /<koha>/lib/C4/Breeding.pm line 107 The reason is that the string is 10 characters long and contains a digit, so Koha thinks it's an ISBN. But when it tries to normalize it, it fails, and instead Koha generates no data for the WHERE clause and then the SQL statement fails because it contains a WHERE without the actual clause. The code: if ($query) { # fill isbn or title, depending on what has been entered #u must do check on isbn because u can find number in beginning of title #check is on isbn legnth 13 for new isbn and 10 for old isbn my ( $title, $isbn ); if ($query=~/\d/) { my $clean_query = $query; $clean_query =~ s/-//g; # remove hyphens my $querylength = length $clean_query; if ( $querylength == 13 || $querylength == 10 ) { $isbn = $query; } } if (!$isbn) { $title = $query; } ( $countbr, @resultsbr ) = BreedingSearch( $title, $isbn ); } -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 25429] New: Cleanup Database - remove resolved claims returned from db after X days
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Bug ID: 25429 Summary: Cleanup Database - remove resolved claims returned from db after X days Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Add option to cleanup_database script to removed 'resolved' return claims from the database after a specified number of days. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 78

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Thibaud Guillot <thibaud.guillot(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot(a)biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28847] New: Branch limits while searching should be expanded in query building and not in CGI
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Bug ID: 28847 Summary: Branch limits while searching should be expanded in query building and not in CGI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Bug 21249 introduced the SearchLimitLibrary system preference and added logic to the search scripts to account for it. Moving the code to modules allows us to cover the settings with tests. Additionally we should only expand the query passed to the search engine, the CGI param should remain brief -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 47

[Bug 29204] New: Error 500 when execute Circulation report with date period
by bugzilla-daemon＠bugs.koha-community.org 23 Nov '21

23 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204 Bug ID: 29204 Summary: Error 500 when execute Circulation report with date period Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: joseanjos(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This error doesn't affect version 20.11.03 To reproduce: Go to Reports -> Circulation On Period select "Row" or "Column" and choose a date Submit You will have a Error 500. Logs, intranet-error.log: AH01215: main::calculate(): DBI Exception: DBD::mysql::st execute failed: Incorrect DATETIME value: '' [for Statement "SELECT distinctrow date_format(`datetime`,"%Y-%m-%d") FROM statistics LEFT JOIN borrowers ON (statistics.borrowernumber = borrowers.borrowernumber) WHERE datetime IS NOT NULL AND datetime != '' AND datetime BETWEEN ? AND ? AND type ='issue' group by date_format(`datetime`,"%Y-%m-%d") order by date_format(`datetime`,"%Y-%m-%d") " with ParamValues: 0='2021-10-01', 1='2021-10-11 23:59:59'] at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 104: /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24