February 2021 - Koha-bugs - lists.koha-community.org

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116760|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117255&action=e… Bug 14233: (follow-up) Fix for delete entire notice This fixes the overall notice delete option. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116674|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117254&action=e… Bug 14233: Allow comparing notice changes This patch adds the 'compare' option to the Notices logs. Test plan 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116673|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117253&action=e… Bug 14233: Add filtering of NOTICES type action logs to the logviewer This patch adds handling for the new 'NOTICES' type action_logs to the logviewer page. Test plan 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116672|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117252&action=e… Bug 14233: Add logging to notice create/update/delete This patch adds the call to logaction to record when a notice is added or changed. Test plan 1/ Add a new notice and check a corresponding line appears in the action_logs table. 2/ Update a notice and check that a corresponding line appears in the action_logs table. 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116671|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117251&action=e… Bug 14233: Add 'id' field to `letter` table to allow linking To allow for 'object' linking from the action_logs table we need an int(11) identifier. This patch updates the letter table to add such a field as a replacement for the multi-field primary key and moves that key to a unique constraint. Test plan 1/ Run the database update 2/ Check that the 'letter' table now includes an 'id' primary key and 'letter_uniq_1' multi-field unique key 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27772 [Bug 27772] Add a Koha::Patron->todays_checkins method -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #68 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I've added a minor QA follow-up to pass patron language into GetPreparedLetter as expected. This is a long overdue enhancement and is great to see making it's way into Koha. I would love to see the database call moved into Koha::Patron as a method (->todays_checkins perhaps) and as such have a unit test associated with it.. but we can handle that in another bug. QA script is happy, no regressions found. Passing QA :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #67 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117250&action=e… Bug 12224: (QA follow-up) Ensure patron language is respected Things have moved on a bit since this code was first written, we now expect a 'lang' parameter passed into GetPrepparedLetter to allow for translated notices. Simple fix, so a quick QA follow-up will suffice :) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116489|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117249&action=e… Bug 12224: (follow-up) Loop old_issues with itemnumber Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0