February 2021 - Koha-bugs - lists.koha-community.org

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116488|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117248&action=e… Bug 12224: (follow-up) Switching to TT notice Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116487|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117247&action=e… Bug 12224: (follow-up) Access old_issues table when editing notice This QA follow-up allows access to the old_issues table when editing the notice in Tools. Signed-off-by: Alexandra Speer <alexandra.speer(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116486|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117246&action=e… Bug 12224: (follow-up) Move button to patron column in checkins table This patch moves the "Print checkin slip" out of its own column and into the colum containing patron information. I think this makes more sense because the slip is specific to a patron, not the individual item which has been checked in. Also changed: printcheckinslip function should be triggered via a class, not a non-unique ID. The function should handle the click using "preventDefault" rather than "return false." To test, apply the patch and check in some items checked out to various patrons. - In the table of checked-in items, confirm that the "Print checkin slip" appears correctly in the column of patron information. - Confirm that the button works correctly to print the correct slip for the associated patron. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Alexandra Speer <alexandra.speer(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116485|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117245&action=e… Bug 12224: Print a slip of borrower's checkins for today To test: 1) Apply patch and run installer 2) Check out two items (or more) to a borrower 3) Check in two items (or more) for this borrower (you should end up on circ/returns.pl) 4) Notice the checked-in items table has started building. There should be a new column with the button 'Print checkin slip' in each row. 5) Click the button and confirm the checkin slip opens for printing in a new window. 6) Go to the patron's account 7) Click the Print dropdown. Confirm there is a 'Print checkin slip' option. Click this and confirm the checkin slip opens for printing in a new window. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Alexandra Speer <alexandra.speer(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27715] Possibly SQL injection in virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27715 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com --- Comment #35 from David Nind <david(a)davidnind.com> --- Testing notes (koha-testing-docker): - I was able to test the emails being sent by copying the HTML for the message from the database and pasting it into a Thunderbird email message (Insert > HTML) - everything looked okay to me. - I wasn't able to properly test the attachment, but I'm going to assume the code creates a valid iso2709 file for attaching, sending, and saving/viewing by the recipient. - There was some minor things I noticed with the email input forms (the ones that pop up after you click the email buttons in Koha) - the 'Comment' label for the input box follows directly after the email address input box. Depending on the width of the pop up window the label isn't aligned properly to the left, but this behaviour is the same as what it was before the patch was applied. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114582|0 |1 is obsolete| | --- Comment #34 from David Nind <david(a)davidnind.com> --- Created attachment 117237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117237&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17179] New: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Bug ID: 17179 Summary: Add keyboard shortcuts to repeat (duplicate) a field, and cut text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl add two more keyboard shortcut commands to the list already available: Ctrl-R : Repeat or duplicate a field Ctrl-C : cut command (to be used with paste - Ctrl-V) -- You are receiving this mail because: You are watching all bug changes.

1 56

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Phil Ringnalda <phil(a)chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil(a)chetcolibrary.org --- Comment #10 from Phil Ringnalda <phil(a)chetcolibrary.org> --- (In reply to Jonathan Druart from comment #7) > It could be useful to know if production DBs still contain such values (?) I have 175 in items.replacementpricedate, looks like a chunk from the original import to this system, another chunk from importing 7 more libraries, then a chunk starting a couple weeks ago when we updated to 20.05, which apparently inserts 0000-00-00 when you mispaste your replacementprice into replacementpricedate's input. Not sure where else to look for 0000-00-00, though. -- You are receiving this mail because: You are watching all bug changes.

1 0