February 2021 - Koha-bugs - lists.koha-community.org

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- These patches appear to work as expected for me so signing off. However, I do wonder about the tooltips left behind in a number of templates.. <span title="0000-00-00"> Those could be misleading but I'm not entirely sure how they're intended to work.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #12 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117267&action=e… Bug 7806: (follow-up) Update to use sanitize_zero_date Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114528|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117266&action=e… Bug 7806: Fix remaining occurrences of 0000-00-00 We should remove all SQL queries that contain 0000-00-00 and finally assume we do not longer have such value in our DB (for date type) We already dealt with such values in previous update DB entries. The 2 added by this one haven't been replaced already. The code will now assume that either a valid date exist, or NULL/undef. Test plan: QA review is needed and test of the different places where code is modified. Not sure about the change from reports/issues_avg_stats.pl Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27715] Possibly SQL injection in virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27715 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.03,20.05.09,19.11.15 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to David Nind from comment #24) Great feedback David, thanks for testing :) > 1. The link in the log viewer 'Object' column doesn't go to the actual > notice - it just lists the notices. This is because there are two ?? after > letter.pl (for example: > /cgi-bin/koha/tools/letter. > pl??op=add_form&branchcode=&module=members&code=A_NOTICE_2&lang=default) Good catch, fixed in the first QA follow-up. > 2. I'm not sure whether changes to the notice name should be logged or not - > if I change the notice name it doesn't show in the log. I'm therefore > assuming that only actual changes to the notice itself are logged. I didn't add logging for title changes at this time, but perhaps that could be added too.. I wasn't sure of the best format to take though and felt at the moment it was more important to expose the template changes diff view than record the title changes and lose the diff view. Perhaps a later followup bug :) > 3. The changes logged - I'm not sure whether this is the correct behaviour, > but assume it is: > . If I make a change to a notice, in the log viewer 'Info' column it > shows what it was before the change was made. > . If that is what is expected, then it is working - you can only compare > previous changes, but not to the current version of the notice. Oops, this is a mistake on my part, it should be the 'after' so we can do the comparison with current and prior. I've corrected this in the second QA follow-up. > 4. I could add new notices, the change was logged, and I didn't get the > error the Owen did in Comment 19, presumably because of the follow-up patch. Correct, that was the earlier follow-up :) > 5. Is it possible to add the notice code somewhere? Maybe in front of the > notice name in the log viewer's 'Object' column. Maybe a future enhancement? Done, added in the 'follow-up'. > 6. I was confused that there is already a 'Letter' module listed (before and > after the patch is applied). Is the 'Letter' module something different from > the 'Notices' module, or the same - I prefer notices as it matches up with > the name in the tools section. I hadn't even noticed the existing 'Letter' filtering.. when I dug into it, it seems that it's linked to the acquisitions claims emails. I wonder if we could rename it to 'Claims' in the UI to clarify it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116761|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117259&action=e… Bug 14233: [DO NOT PUSH] DBIC Schema File Update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117258&action=e… Bug 14233: (follow-up) Add notice code to log viewer -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #31 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117257&action=e… Bug 14233: (QA follow-up) Record updated content We should record the updated template, not the content prior to the update.. That way we can properly compare between versions to see the changes made. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117256&action=e… Bug 14233: (QA follow-up) Fix typo in viewlog.tt We had a double ?? in the object link.. Thanks for spotting that David :) -- You are receiving this mail because: You are watching all bug changes.

1 0