February 2021 - Koha-bugs - lists.koha-community.org

[Bug 24447] New: POD of C4::Members::Messaging::GetMessagingPreferences() is misleading
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24447 Bug ID: 24447 Summary: POD of C4::Members::Messaging::GetMessagingPreferences() is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Part of the POD for this subroutine looks like this: 42 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrower->{'borrowernumber'}, 43 message_name => 'DUE' } ); 44 45 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY', 46 message_name => 'DUE' } ); It looks like the value for message_name should be a value from letter.code, but it should be a name from message_attributes.message_name: 75 AND message_transports.is_digest = borrower_message_preferences.wants_digest 76 WHERE message_attributes.message_name = ? 77 END_SQL 78 79 my @bind_params = ( $params->{'message_name'} ); Note: This subroutine is set to be renamed and moved by Bug 18595, but the POD seems to be untouched there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 11996] Default active currencies for ru-RU and uk-UA are wrong
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11996 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22152] New: Hide printing the tools navigation when printing reports
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152 Bug ID: 22152 Summary: Hide printing the tools navigation when printing reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Hide the navigation showing up on the left side when printing a report page. (see 22147 for reference) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 27543] New: Tooltip on opac-messaging.pl obscured by table headers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 Bug ID: 27543 Summary: Tooltip on opac-messaging.pl obscured by table headers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org Created attachment 115755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115755&action=e… Tooltip obscured by table headers Whilst testing bug 27493, I noticed that the tooltip for 'Digests only' in opac-messaging.pl is obscured by the table headers. To recreate: 1) Log into the OPAC 2) Go to 'your messaging' /opac-messaging.pl 3) Hover over the Digests only tooltip 4) Note that the tooltip appears on the same line as the headers, so is partially obscured I've added a screenshot to the report. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 27508] New: Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display"
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27508 Bug ID: 27508 Summary: Can't duplicate the MARC field tag with JavaScript if option "advancedMARCeditor" is set to "Don't display" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Cataloging Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, nugged(a)gmail.com, slavashishkin(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 27446] New: Markup errors in suggestion/suggestion.tt
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Bug ID: 27446 Summary: Markup errors in suggestion/suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org While working on a separate issue I notices there are several markup errors in suggestion/suggestion.tt. 1. <h2> tag closes with an </h3> 2. Some button elements are using the self-closing syntax when they should not 3. <div id="limits> does not close 4. There are some stray </div>'s 5. Indentation/white could be better -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27034] New: $c->objects->search shouldn't use path parameters
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 Bug ID: 27034 Summary: $c->objects->search shouldn't use path parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The objects.search Mojolicious helper incorrectly adds path parameters to the query for filtering. This works, trivially for plat routes like: GET /patrons/:patron_id or for routes that really have links like (fictional example): GET /patrons/:patron_id/holds In the latter, we already know there's a link borrowers<->reserves so searching holds and filtering by the borrowernumber will work. About this there are two things to consider: - That's not how we are coding, we are actually picking the patron_id manually and using object methods to access the resultset: my $patron = Koha::Patrons->find( $c->validation->param('patron_id') ); ... my $holds_rs = $patron->holds; my $holds = $c->objects->search({ resultset => $holds_rs }); - If we have more tricky examples like: GET /holds/:hold_id/pickup_locations it is obvious that hold_id doesn't make any sense for Koha::Libraries, so filtering on it actually causes an exception. One option is to manually remove the problematic path parameters in the controller: my $hold_id = $c->validation->param('hold_id'); my $hold = Koha::Holds->find( $hold_id ); delete $c->validation->output->{'hold_id'}; my $pickup_locations_rs = $hold->pickup_locations; my $pickup_locations = $c->objects->search( $pickup_locations_rs ); My feeling is that we should be following the current pattern, and not really use the path parameters in objects.search. If we later need some handling in the generic objects->search helper, we can reintroduce it, but we need a real use case, which cannot be found in the codebase yet. It all points towards not needing them there, and just getting in the middle with no gain (just the opposite). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 27352] New: Add GET /biblios/:biblio_id/items
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Bug ID: 27352 Summary: Add GET /biblios/:biblio_id/items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com It would be helpful to have that route. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 12260] Printing a page from bootstrap shows unnecessary links
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12260 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.

1 0