May 2021 - Koha-bugs - lists.koha-community.org

[Bug 26632] New: BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '22

23 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632 Bug ID: 26632 Summary: BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org 424 $import_record_id = AddBiblioToBatch($batch_id, $rec_num, $marc_record, $encoding, int(rand(99999)), 0); 430 $import_record_id = AddAuthToBatch($batch_id, $rec_num, $marc_record, $encoding, int(rand(99999)), 0, $marc_type); This populates: my $update_counts = @_ ? shift : 1; Which is used once: _update_batch_record_counts($batch_id) if $update_counts; So...almost always we want to update, but very occasionally, randomly, don't? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 28375] New: Inefficiencies in fetching COinS
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375 Bug ID: 28375 Summary: Inefficiencies in fetching COinS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In XSLTParseForDisplay we fetch the coins for the OPAC even on the staff interface On opac results we fetch the biblio object, this is already fetched in the searchResults subroutine Additionally - we can fetch the coins in the searchResults to move logic out of the scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 18445] New: Tests in t stumble over Auth's BEGIN block
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '22

19 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18445 Bug ID: 18445 Summary: Tests in t stumble over Auth's BEGIN block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com We should be able to run the tests in t without the database. But if some module loads Auth.pm via C4/Serials or Koha/Virtualshelf directly or indirectly, this will trigger execution of Auth's BEGIN block. This block contains three calls for systempreferences (one from Auth_with_cas). Note that loading Biblio.pm also starts a chain going to Auth.pm. This report changes two use C4::Auth statements into requires. This will prevent or postpone execution of this code. Note also that this will resolve a few failing tests like (Matcher.t and Prices.t) where the schema mock actually was too late and the database was accessed instead of defined fixtures. Along the way we fix a few minor issues in t where database access should be eliminated. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 28473] New: Add REST endpoint for searching extended patron attributes
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '22

19 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28473 Bug ID: 28473 Summary: Add REST endpoint for searching extended patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi CC: tomascohen(a)gmail.com We would like to be able to search all our extended patron attributes in the database. The following endpoint would probably need to be added for this: GET /extended_attributes It should have an option to search with the attribute type and value. This is API endpoint would be useful for example gathering a list of patrons with a specific extended attribute which has a statistics group for example, or for searching patrons that are blocked via a special attribute, and so on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 20116] New: Cache language list
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '22

19 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bug ID: 20116 Summary: Cache language list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20115 C4::Languages::getTranslatedLanguages calls _get_language_dirs that list directories to know the available themes. It sounds like we could avoid that and cache it instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 [Bug 20115] Languages appear in a different order in the footer -- You are receiving this mail because: You are watching all bug changes.

1 78

[Bug 22760] New: cataloging search yields no results if queryparser is on
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760 Bug ID: 22760 Summary: cataloging search yields no results if queryparser is on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: mikael.olangcay-brisebois(a)inLibro.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- If QueryParser is on and defaultsortorder is set to relevance,dsc, when you do a cataloging search, first page yields results but other pages don't return any results half the time. It also seems to break the sort by popularity, but that is not adressed by this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 22407] New: OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '22

14 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Bug ID: 22407 Summary: OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Example, instead of this: return Koha::Patrons->find( $self->guarantorid() ); We should do this: return Koha::Patron->_new_from_dbic($self->_result->guarantor); This allows us to use prefetch and perform a single query as opposed to multiple queries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 26995] New: Drop column relationship from borrower tables
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '22

13 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Bug ID: 26995 Summary: Drop column relationship from borrower tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications It will need to be removed from many of the same places as "guarantorid" from Bug 14570 like: - C4/Auth_with_ldap - C4/SIP/ILS/Patron.pm - Possibly other places... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 36

[Bug 28372] New: Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '22

12 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28372 Bug ID: 28372 Summary: Use variables for 007 controlfield translations in MARC21slim2intranetResults.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Slight performance improvement over fetching the same field every time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 27463] New: OAI-PMH date handling in ListBase.pm
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '22

12 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 Bug ID: 27463 Summary: OAI-PMH date handling in ListBase.pm Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: rudolfbyker(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently in Koha/OAI/Server/ListBase.pm two different criteria are used for querying dates and displaying dates. When displaying the "Last Modified" date, this is used: SELECT MAX(timestamp) FROM ( SELECT timestamp FROM biblio_metadata WHERE biblionumber = ? UNION SELECT timestamp FROM deleteditems WHERE biblionumber = ? UNION SELECT timestamp FROM items WHERE biblionumber = ? ) bi But when querying, only biblio_metadata.timestamp is used. This should be made consistent. We could use a query like this (using a join, but removing the need to do a separate query for each record, so it might actually be faster than what we have now): select bm.biblionumber, greatest(bm.timestamp, i.timestamp) as t from biblio_metadata bm inner join items i on bm.biblionumber=i.biblionumber having t >= '2020-07-14' and t <= '2020-07-15' limit 10; Furthermore, we should only use items.timestamp and deleteditems.timestamp when the user has the "include_items" option set in their OAI-PMH config. It does not make sense to query item timestamps if you are only sending data about the records, and not the items. Therefore, if "include_items" is disabled, we can do a simpler query: select biblionumber, timestamp from biblio_metadata where timestamp >= '2020-07-14' and timestamp <= '2020-07-15' limit 10; See full discussion on IRC: http://irc.koha-community.org/koha/2021-01-18#i_2324076 Definition of "datestamp" for reference: https://www.openarchives.org/OAI/openarchivesprotocol.html#Datestamp -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22