May 2021 - Koha-bugs - lists.koha-community.org

[Bug 19237] New: PERSO_NAME authority file ignores first indicator value of new headings saved
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 Bug ID: 19237 Summary: PERSO_NAME authority file ignores first indicator value of new headings saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: imingchan(a)yahoo.com.au QA Contact: testopia(a)bugs.koha-community.org When saving new headings to PERSO_NAME authority, first indicator value is not saved. So when you selected such authority heading (as part the cataloguing), you have to manually re-enter the indicator value concerned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #310 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 120368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120368 Bug 15516: Database and installer updates Review of attachment 120368: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +4350,3 @@ > CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE, > CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE, > CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`desk_id`) REFERENCES `desks` (`desk_id`) ON DELETE SET NULL ON UPDATE CASCADE There is a missing comma here which causes this error: Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `reserves` ( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #309 from David Cook <dcook(a)prosentient.com.au> --- Code looks all right just looking at the diff, so I think fixing the QA test tool failures should resolve things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #308 from David Cook <dcook(a)prosentient.com.au> --- However, it's failing the QA test tools: root@kohadevbox:koha(bug_15516)$ qa testing 6 commit(s) (applied to 8fe090f 'e3 Bug 27864: (QA follow-up) Select2 ') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) OK C4/Reserves.pm FAIL Koha/Hold.pm FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc FAIL filters wrong_html_filter at line 181 ( <div>(part of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% hold.hold_group_id %]" class="hold-group">hold group</a>)</div>) missing_filter at line 181 ( <div>(part of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% hold.hold_group_id %]" class="hold-group">hold group</a>)</div>) OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt FAIL filters wrong_html_filter at line 185 ( <div>(part of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% itemsloo.hold_group_id %]" class="hold-group">hold group</a>)</div>) missing_filter at line 185 ( <div>(part of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% itemsloo.hold_group_id %]" class="hold-group">hold group</a>)</div>) OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt FAIL filters missing_filter at line 23 ( <td>[% hold.priority %]</td>) missing_filter at line 24 ( <td>[% hold.reservenotes %]</td>) FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 2) OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl FAIL reserve/hold-group.pl FAIL critic Subroutine "new" called using indirect syntax at line 25, column 11. See page 349 of PBP. FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 30) OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t FAIL t/db_dependent/Reserves/HoldGroup.t FAIL file permissions File must have the exec flag Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |dcook(a)prosentient.com.au |y.org | --- Comment #307 from David Cook <dcook(a)prosentient.com.au> --- Rebased and works as expected with following test plan: My test plan: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. perl misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml 0d. restart_all 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. (e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test) 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold (e.g. Check in 39999000001310 ) 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118355|0 |1 is obsolete| | --- Comment #306 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 120373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120373&action=e… Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118354|0 |1 is obsolete| | --- Comment #305 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 120372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120372&action=e… Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118353|0 |1 is obsolete| | --- Comment #304 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 120371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120371&action=e… Bug 15516: Schema updates Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118352|0 |1 is obsolete| | --- Comment #303 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 120370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120370&action=e… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 May '21

03 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118351|0 |1 is obsolete| | --- Comment #302 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 120369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120369&action=e… Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0