June 2021 - Koha-bugs - lists.koha-community.org

[Bug 27451] New: Split opac_news.lang into two distinct fields for location and language
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '21

12 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451 Bug ID: 27451 Summary: Split opac_news.lang into two distinct fields for location and language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 28280] New: itemtypes page defaultreplacecost and processfee aren't using Price filter.
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Bug ID: 28280 Summary: itemtypes page defaultreplacecost and processfee aren't using Price filter. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org I don't know if it's an oversight or because they couldn't be NULL anymore if $Price is used but in /cgi-bin/koha/admin/itemtypes.pl page detail defaultreplacecost and processfee aren't formatted unlike To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 28522] New: Correct eslint errors in staff-global.js
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522 Bug ID: 28522 Summary: Correct eslint errors in staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 23833 Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in staff-global.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 28427] New: Terminology: Shelf should be list
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427 Bug ID: 28427 Summary: Terminology: Shelf should be list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt:2 Download shelf &rsaquo; Koha -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 28423] New: JavaScript error on MARC modifications page
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28423 Bug ID: 28423 Summary: JavaScript error on MARC modifications page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/marc_modification_templates.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org This line in the MARC modification template is problematic because if "ActionsLoop" doesn't exist it creates a JS error. var mmtas = [% ActionsLoop.json | $raw %] Normally the solution would be to wrap the variable in quotes: var mmtas = "[% ActionsLoop.json | $raw %]"; ...but that causes an error if ActionsLoop *is* defined. We need some logic for determining how the script is generated. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 28582] New: Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123.
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582 Bug ID: 28582 Summary: Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $self->borrowernumber, message_transport_type => 'email', } ) or warn "can't enqueue letter $letter"; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 28479] New: TestBuilder.pm uses incorrect method for checking if objects to be created exists
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479 Bug ID: 28479 Summary: TestBuilder.pm uses incorrect method for checking if objects to be created exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: joonas.kylmala(a)helsinki.fi Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart+koha(a)gmail.com Blocks: 22690 While working on bug 22690 it was discovered that TestBuilder.pm uses incorrect method to check if objects to be built already exists or not. The warning we got due to this was: > DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /kohadevbox/koha/t/lib/TestBuilder.pm line 235 I'm working on a patch for this, I think it helps to explain more the problem – it was quite tough to debug but I think I got to the bottom of it finally. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 [Bug 22690] Merging records with many items too slow (Elasticsearch) -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 28388] New: Search result set is lost when viewing the MARC plain view (opac-showmarc.pl)
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28388 Bug ID: 28388 Summary: Search result set is lost when viewing the MARC plain view (opac-showmarc.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: timothy_alexis.vass(a)ub.lu.se QA Contact: testopia(a)bugs.koha-community.org After searching with multiple results the bibliographic details page (opac-detail.pl?biblionumber=...) has the option to browse results. When clicking the MARC View (opac-MARCdetail.pl?biblionumber=...) and then returning to Normal view, the search result is preserved. However, when clicking "view plain" in the MARC View and then returning to Normal view, the search result is lost and browsing to a different biblio in the result set will drop the browse results functionality. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 28422] New: OPAC MARC detail view doesn't correctly evaluate holdability
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 Bug ID: 28422 Summary: OPAC MARC detail view doesn't correctly evaluate holdability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The MARC detail view in the OPAC will show a "Place hold" link at times when holds are not allowed. The situation which I observed was when all items were "not for loan." The template expects the "norequests" variable to be set correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 28605] New: Code to calculate item's holdability must be moved to Koha::Item
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '21

11 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28605 Bug ID: 28605 Summary: Code to calculate item's holdability must be moved to Koha::Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 28422 Code is duplicated in opac/opac-ISBDdetail.pl, opac/opac-MARCdetail.pl and opac/opac-detail.pl (at least). It must be moved to a Koha::Item method 721 $norequests = 0 722 if $norequests 723 && !$itm->{'withdrawn'} 724 && !$itm->{'itemlost'} 725 && ($itm->{'itemnotforloan'}<0 || not $itm->{'itemnotforloan'}) 726 && !$itemtypes->{$itm->{'itype'}}->{notforloan} 727 && $itm->{'itemnumber'}; search for '$norequests' in those 3 files. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2