August 2021 - Koha-bugs - lists.koha-community.org

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123587|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 123681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123681&action=e… Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 123680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123680&action=e… Bug 10902: (follow-up) Account for singleBranchMode This patch checks singleBranchMode before highlighting the current branch in search results. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28836] New: Duplicated import in template plugins
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28836 Bug ID: 28836 Summary: Duplicated import in template plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In template plugins, we often find double importing of the parent library: use Template::Plugin; use base qw( Template::Plugin ); Some of the plugins use 'base' [1] like this, and others use 'parent' (that seems to be what we should be using in this cases, as we are not ) [2]. [1] https://perldoc.perl.org/base [2] https://perldoc.perl.org/parent#HISTORY -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 22399] New: Improve responsive behavior of the basic marc editor
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug ID: 22399 Summary: Improve responsive behavior of the basic marc editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, testopia(a)bugs.koha-community.org Depends on: 22045 Target Milestone: --- Created attachment 85569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85569&action=ed… Animated gif showing the proposed style update I propose to make some markup and style changes to the MARC editor to improve its handling of smaller browser widths. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 [Bug 22045] Cataloging UX enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes.

1 69

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

1 0

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '21

10 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This appears to work really well now! Before passing just one more suggestion to discuss: Could we imagine not displaying this information for single branch libraries by default? I think it would help to keep their display a little cleaner without the highlighting and repeated information. I believe we do have a global variable that could be used for this check: singleBranchMode from C4:Auth.pm. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15349] Problem with email pattern check on forms
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '21

09 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #7 from Lucas Gass <lucas(a)bywatersolutions.com> --- In the meantime you can step around email validation on branches.tt by adding the following to your IntranetUserJS sys pref: //turn off email validation for branches.tt if ( $('#admin_branches').length && window.location.href.indexOf("op=add_form") > -1 ) { $('#branchemail').removeClass('email'); } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10902] Highlight patrons from logged-in library in patron searches
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '21

09 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902 --- Comment #12 from David Nind <david(a)davidnind.com> --- Thanks Owen! That works brilliantly! David -- You are receiving this mail because: You are watching all bug changes.

1 0