September 2021 - Koha-bugs - lists.koha-community.org

[Bug 13376] Include a user-editable area/page for terms and conditions of use in the opac
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14771] Allow patrons to pick a username
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11723] Message "A refund has been applied" on all lost item returns
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #372 from David Gustafsson <glasklas(a)gmail.com> --- (In reply to Jonathan Druart from comment #369) > I've spent a lost of time on this patch set to make it part of 21.05. Added > follow-ups and written test. > > Then I had some questions, and didn't get the answers I needed to write the > missing bit. I was not asking anybody else to write anything. > > I wish I had people asking me to write follow-up for my patches.. Sorry I missed some of those questions (i for some reason read comment 221-333 so I was not referring to you regarding requesting new features). Regarding the question in comment 324: > 4. We need a wiki page, or at least more info/examples for the release notes. There is only 2 very succinct example in the test plan but the feature allows much more. I have written a manual entry, it might now be partly out dated since it was 2 years ago, there are some links to it further up in the thread: https://gitlab.com/gnucifer/koha-manual/-/commit/eb07dd1abcb357de27d294cee4… The reason I pointed out that we have been running this in production for a long time is that there appears to be great hesitancy in merging this which is understandable due to the large surface area of changes and and relative high complexity. That serious bugs could lurk is not impossible, but is highly unlikely as we would probably have encountered them by now. There are for example certain contexts that we do not use, like batchmod, z3950 and import_lexile, but it can be good to know that the core functionality appears to be pretty solid. The scariest part of this by far is the potential for unexpected data loss or corruption when records are taken apart and put back together again, and that part appears to be solid. As a side note I don't really get why MergeRules were renamed to OverlayRules, it's not that much worse than merge, but is it really better? To me merge is more intuitive as we basically have to revisions of a record and use certain rules to resolve the diff, merging the two. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #371 from David Gustafsson <glasklas(a)gmail.com> --- (In reply to Martin Renvoize from comment #370) > > I did forget about one thing though, that actually is a show-stopper, and > > that is if this bug is merged without the fix in bug 25539, this will > > trigger a bug with this current patch. I discovered that bug 25539 was set > > as depending on this bug when it should have been the other way around which > > I now fixed. > > Pretty sure we reversed the dependencies deliberately to unblock this.. we > disable this feature for use with bulkmarcimport in one of the patches. Yes, now I remember. I mistakenly misremembered the bug in bug 25539 appearing when saving using the staff interface. In that case there should be no blockers for this patch (with bulkmarcimport.pl disabled, which would be a show-stopper for us, but we would in case this got merged address with a local patch). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #370 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- > I did forget about one thing though, that actually is a show-stopper, and > that is if this bug is merged without the fix in bug 25539, this will > trigger a bug with this current patch. I discovered that bug 25539 was set > as depending on this bug when it should have been the other way around which > I now fixed. Pretty sure we reversed the dependencies deliberately to unblock this.. we disable this feature for use with bulkmarcimport in one of the patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #369 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- I've spent a lost of time on this patch set to make it part of 21.05. Added follow-ups and written test. Then I had some questions, and didn't get the answers I needed to write the missing bit. I was not asking anybody else to write anything. I wish I had people asking me to write follow-up for my patches.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #368 from David Gustafsson <glasklas(a)gmail.com> --- (In reply to Jonathan Druart from comment #339) > There are several questions waiting for answers, see comments 321-333. I read through those comments again, and the questions where not addressing stability issues but feature requests and refactoring suggestions. Probably one of the reasons this has taken so long is that instead of concentrating on minimal viable functionality there are continuous suggestions for new features and improvements. Some of which are actually pretty complicated to implement (like user feedback). As I said we have been running this in production for years, and it more or less covers our needs (as pretty decently sized university library with 200+ employees. I did forget about one thing though, that actually is a show-stopper, and that is if this bug is merged without the fix in bug 25539, this will trigger a bug with this current patch. I discovered that bug 25539 was set as depending on this bug when it should have been the other way around which I now fixed. The reason everything works for us is that we use the fix in bug 25539. We also have large and unruly patch for bulkmarcimport.pl (a which I believe is now deactivated in the current iteration of this patch) so that also source works. Can't remember at the top of my head what the issues in bulkmarcimport.pl was that caused us to disable it, but the fix in bug 25539 will not solve this issue I think (but is still needed to avoid the bug causing rules to be ignored on updates. So I think focusing on sorting out the issue addressed in bug 25539, and possibly address the problems with bulkmarcimport.pl would be reasonable thing to prioritize. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '21

30 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25539 | Depends on| |25539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 [Bug 25539] Remove AddBiblio "defer_marc_save" option -- You are receiving this mail because: You are watching all bug changes.

1 0