October 2022 - Koha-bugs - lists.koha-community.org

[Bug 29150] New: hold pickup sent two patrons
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29150 Bug ID: 29150 Summary: hold pickup sent two patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: amy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 31805] New: Tidy up transfer pages (branchtransfers.pl) - terminology and styling
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31805 Bug ID: 31805 Summary: Tidy up transfer pages (branchtransfers.pl) - terminology and styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 141902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141902&action=e… Screenshots - library transfer screen and table When testing bug 31781 I noticed a couple of items that I think need tidying up for the branch transfer page (/cgi-bin/koha/circ/branchtransfers.pl): - When transferring, the page says "Reserve found", from our terminology list this should be "Hold found". - There are grey backgrounds and a left border around the buttons. - The text should be left aligned. - The table looks "different" than others, I'm assuming because it is not using DataTables. To replicate: 1. Apply bug 31781 if it hasn't been pushed to master. 2. Place an item level hold for a patron (select an item that is in another library). 3. Use the library transfer feature: - Circulation > Transfer > Transfer - Enter the barcode for the item and change the destination library - Select Submit 4. Note that: . The page says "Reserve found", from our terminology list this should be "Hold found". . The transfer and Ignore buttons have a grey background and there is a table border to the left. . The options are center aligned. 5. Choose an action, such as Transfer. 6. Note that the table displayed is "different" from normal tables that use DataTables styling/features. Screenshots of before and after for bug 31781 attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 31032] New: Patron attributes branch limitations are unclear
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032 Bug ID: 31032 Summary: Patron attributes branch limitations are unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When a patron attribute is limited to some branches it seems to mean: 1 - That attribute shows on moremember, and on opac to patron, but not in patron edit screen if signed in at a different branch 2 - It can be set for any patron from any branch on staff side, but only by libraries from the limited list 3 - The code in extended_attributes appears to ignore all branch specific mandatory attributes: 1707 my @required_attribute_types = 1708 Koha::Patron::Attribute::Types->search( 1709 { 1710 mandatory => 1, 1711 category_code => [ undef, $self->categorycode ], 1712 'borrower_attribute_types_branches.b_branchcode' => 1713 undef, 1714 }, 1715 { join => 'borrower_attribute_types_branches' } 1716 )->get_column('code'); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #53 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Björn Nylén from comment #52) > (In reply to Marcel de Rooy from comment #51) > > This was a very BAD dbrev. It clears all preferences ! > > Sorry about that one... I'm certain I tested the sql before. :blush: Don't worry about it, we all broke something before. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31855 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31855] New: Installer output buffering can be confusing
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31855 Bug ID: 31855 Summary: Installer output buffering can be confusing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org On bug 14783 a bug was introduced on the db_rev, that cleared all sysprefs. I rewinded ~500 commits in an attempt to reproduce it, following this steps: $ git reset --hard 1a1529d20572c8eb7e65ad7bbd41f688d5f86f07 $ reset_all $ git reset --hard ae986b992dfc2299ec58f4d1c0079fbac1ec4a03 $ updatedatabase the result is: root@kohadevbox:koha(master)$ updatedatabase C4::Installer::SetVersion(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'Version' for key 'PRIMARY' at /kohadevbox/koha/C4/Installer.pm line 777 If I do this: $ git reset --hard 1a1529d20572c8eb7e65ad7bbd41f688d5f86f07 $ reset_all $ git reset --hard ab1e0a5d6ad2eb31e4322ec11a1e971386144f5d $ updatedatabase the result is: root@kohadevbox:koha((1a1529d2057...))$ updatedatabase Upgrade to 22.06.00.045 [12:04:08]: Bug 29144 - Copy and remove branches.opac_info Upgrade to 22.06.00.046 [12:04:08]: Bug 15348 - Add new column aqorders.estimated_delivery_date Upgrade to 22.06.00.047 [12:04:08]: Bug 30025 - Split and rename BiblioAddsAuthorities system preference Added RequireChoosingExistingAuthority and AutoLinkBiblios BiblioAddsAuthorities removed Upgrade to 22.06.00.048 [12:04:08]: Bug 30472 - borrower_relationships.guarantor_id NOT NULL Upgrade to 22.06.00.049 [12:04:08]: Bug 30490 - Adjust FK constraint for parent item type Upgrade to 22.06.00.050 [12:04:08]: Bug 30497 - Recreate old_reserves_ibfk_4 if cascading Upgrade to 22.06.00.051 [12:04:08]: Bug 7021 - Add patron category to the statistics table Upgrade to 22.06.00.052 [12:04:08]: Bug 25735 - Add Elasticsearch field 'available' Upgrade to 22.06.00.053 [12:04:08]: Bug 30484 - Add a notice template for ILL Update notices Bug 30484 DB update complete Upgrade to 22.06.00.054 [12:04:08]: Bug 23538 - Add new system preferences EmailPatronRegistrations and EmailAddressForPatronRegistrations and new OPAC_REG letter Upgrade to 22.06.00.055 [12:04:08]: Bug 26368 - Add OCLC Encoding Levels system preference Added UseOCLCEncodingLevels system preference Upgrade to 22.06.00.056 [12:04:08]: Bug 30571 - Table z3950servers: three cols NOT NULL Upgrade to 22.06.00.057 [12:04:08]: Bug 29071 - Set HoldsQueueSplitNumbering where not set Added HoldsSplitQueueNumbering if not already there Upgrade to 22.06.00.058 [12:04:08]: Bug 30944 - Replace branchtransfers.cancellation_reason CancelRecall with RecallCancellation Upgrade to 22.06.00.059 [12:04:08]: Bug 25936 - A password change notification feature Upgrade to 22.06.00.060 [12:04:08]: Bug 10950 - Add pronouns to borrowers table Added pronouns column to borrowers table Added pronouns column to deletedborrowers table Added pronouns column to borrower_modifications table Upgrade to 22.06.00.061 [12:04:08]: Bug 31333 - Add new suggestionPatronCategoryExceptions system preference Upgrade to 22.06.00.062 [12:04:08]: Bug 27136 - Add missing languages: Cree, Afrikaans and Multiple languages, Undetermined and No linguistic content Added missing languages Upgrade to 22.06.00.063 [12:04:08]: Bug 31569 - Add primary key for import_biblios Added primary key to import_biblios table Upgrade to 22.06.00.064 [12:04:08]: Bug 14783 - Allow patrons to change pickup location for non-waiting holds Added new system preference 'OPACAllowUserToChangeBranch' Removed system preference 'OPACInTransitHoldPickupLocationChange' As the 'failing' db_rev is the last one, I would've expected the upgrade process to print the previous db_revs output and fail on the last one, somehow. It is a weird case (the introduced bug cleared all sysprefs) but yet, the output is not correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #52 from Björn Nylén <bjorn.nylen(a)ub.lu.se> --- (In reply to Marcel de Rooy from comment #51) > This was a very BAD dbrev. It clears all preferences ! Sorry about that one... I'm certain I tested the sql before. :blush: -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This was a very BAD dbrev. It clears all preferences ! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29819] New: Allow setting AR fees at item type level
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 Bug ID: 29819 Summary: Allow setting AR fees at item type level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 27946 introduced circulation rules to allow charging for article requests. It was done by relying on circulation rules on a per-branch and category basis. It would be great to define it at item type level as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 31852] New: Check out date set to today
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '22

18 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31852 Bug ID: 31852 Summary: Check out date set to today Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nayema(a)mes.ac.in QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We have successfully defined our circulation rules. It was working nicely but since yesterday the check out date is set to same day.So If I check out a book today the due date is today. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2