November 2022 - Koha-bugs - lists.koha-community.org

[Bug 32130] New: Vue files must be kept tidy
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Bug ID: 32130 Summary: Vue files must be kept tidy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Keywords: rel_22_11_candidate Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 32030 We want to keep them tidy, and all use the them rules. To enforce that we should have a test in xt to catch possible discrepancies. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 29607] New: addorderiso2709: The stored discount when importing an order from a file is invalid
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Bug ID: 29607 Summary: addorderiso2709: The stored discount when importing an order from a file is invalid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: christophe.torin(a)univ-rennes2.fr QA Contact: testopia(a)bugs.koha-community.org In the Acquisitions module : - Create a new vendor with a discount (Or select one that has a discount). Here the discount will be 25% - Create a new basket or select an existing one - Select "Add to basket" => From a staged file - Add an order from one of the file ==> Here, you can use a specific discount for the order, to override the vendor discount. The result should be quite the same if you do, but with this discount - The order is created ==> Modify the order - The discount is 0.25% instead of 25% Note that the prices are initially correctly calculated, but the discount value will appear as false. Plus, if you modify the order and change a price, the wrong discount will be used. In database, the discount is indeed stored as a value between 0 and 1, but only in that case (for the vendor, it is the actual percentage, and when you create an order from anoher source, it is stored correctly) This was reported on Koha 20.11, but is still relevant on master. In the code, this happens because the discount value is first divided by 100 to calculate the price, but it is that divided value that is stored in database, instead of the whole percentage value. On the master branch, in the file Koha/acqui/addorderiso2709.pl, the line where it's done are lines 166, 279 and 340 What I would suggest is : - Remove the division per 100 on those lines (166, 279 and 340) - Divide per 100 only when calculating the price (lines 283, 285, 344, 346) ==> ( 1 - $c/100 ) instead of ( 1 - $c ) - In the template (for importing from file), add a "%" just to be clear that the discount is a percentage, and not a value between 0 and 1 I know there was a kind of security (divide by 100 if the input is > 1), but it could be the other way around (multiply by 100 if the input is < 1). But as it is based on the field that is in the form, with a simple "%" indication it should not be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 24310] New: Use Text::Lorem instead of String::Random in Test::Builder
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24310 Bug ID: 24310 Summary: Use Text::Lorem instead of String::Random in Test::Builder Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org That would help to get something more readable. Currently we generate a string of one word that is the size of the column. It produces a lot of overflow when displayed on the screen. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 31471] New: Duplicate check in cataloguing doesn't work with Elasticsearch
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31471 Bug ID: 31471 Summary: Duplicate check in cataloguing doesn't work with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de CC: michaela.sieber(a)kit.edu The duplicate check in cataloguing doesn't work with Elasticsearch. To test: * With Zebra: Download a record via Z39.50 and save. * Make sure the record is found in the catalog. * Download the same record via Z39.50 again and try to save - duplicate confirm message pops up. * Switch to Zebra * Again, make sure that the record can be found in the catalog. * Download the record again via Z39.50 and try to save - no duplicate warning, the record is saved. If an example is needed we could provide a taget and sample. Note: As I understand FindDuplicate it checks for ISSN and after that a combination of title and author. Is there a thing we might be missing here? Tested in different installations with master and 21.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 32205] New: Unnecessary sysprefs used in template params for masthead during failed OPAC auth
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 Bug ID: 32205 Summary: Unnecessary sysprefs used in template params for masthead during failed OPAC auth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org C4::Auth sends many sysprefs as template params unnecessarily since the create of Koha.Preference(). This issue highlights some of them which are sent during a failed OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 31411] New: [Omnibus] Set focus to first input field of an add/entry form
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 Bug ID: 31411 Summary: [Omnibus] Set focus to first input field of an add/entry form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org This serves as an omnibus for several other smaller bugs dealing with add/entry forms for configuration and other settings. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 31413] New: Set focus for cursor to Selector when adding a new audio alert
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Bug ID: 31413 Summary: Set focus for cursor to Selector when adding a new audio alert Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Blocks: 31411 When adding a new audio alert from the administration module, the focus should be on the first input field of the entry form: Selector Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 32375] New: 22.05.07 failing t/AuthoritiesMarc_MARC21.t
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Bug ID: 32375 Summary: 22.05.07 failing t/AuthoritiesMarc_MARC21.t Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: wainuiwitikapark(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org t/AuthoritiesMarc_MARC21.t is failing on 22.05.07 Please see the output below: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/AuthoritiesMarc_MARC21.t t/AuthoritiesMarc_MARC21.t .. 1/5 # No tests run! t/AuthoritiesMarc_MARC21.t .. 5/5 # Failed test 'No tests run for subtest "FindDuplicateAuthority tests"' # at t/AuthoritiesMarc_MARC21.t line 62. DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI connect('database=koha_kohadev;host=localhost;port=3306','koha_kohadev',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /home/vagrant/kohaclone/Koha/Database.pm line 91. at /home/vagrant/kohaclone/Koha/Database.pm line 139 # Looks like your test exited with 255 just after 5. t/AuthoritiesMarc_MARC21.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/5 subtests Test Summary Report ------------------- t/AuthoritiesMarc_MARC21.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Files=1, Tests=5, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.57 cusr 0.17 csys = 1.77 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 31209] New: Add span with class info to enumchron data in circulation.tt, for better styling
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 Bug ID: 31209 Summary: Add span with class info to enumchron data in circulation.tt, for better styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: mathsabypro(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In the table issues-table of circulation.tt, enumchron data in added to the title between parentheses. There is no way to style this information differently from the title. We could add a span with a class to isolate this information. Alternatively, enumchron data could be moved in a new column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 22693] New: ILL "Price paid" column does not appear in column configuration
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Bug ID: 22693 Summary: ILL "Price paid" column does not appear in column configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- "Price paid" was added in bug 22121, it seems I forgot to add it to the column configuration list. Doh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 34