November 2022 - Koha-bugs - lists.koha-community.org

[Bug 31517] New: C4::Tags should use Koha::Tags objects
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Bug ID: 31517 Summary: C4::Tags should use Koha::Tags objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: joonas.kylmala(a)iki.fi Reporter: joonas.kylmala(a)iki.fi QA Contact: testopia(a)bugs.koha-community.org C4::Tags module does currently a lot of raw SQL queries. We should use the Koha object methods for these instead (Koha::Tags and so on). -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 32086] New: Consistent classes for primary buttons: Patrons
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32086 Bug ID: 32086 Summary: Consistent classes for primary buttons: Patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 32085 As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons: This patch will update buttons in patron module templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes. In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 [Bug 32085] Consistent classes for primary buttons: Labels -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 32085] New: Consistent classes for primary buttons: Circulation
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32085 Bug ID: 32085 Summary: Consistent classes for primary buttons: Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 32067 As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons: This patch will update buttons in label-creation templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes. In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067 [Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 32066] New: User can get stuck on login screen
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32066 Bug ID: 32066 Summary: User can get stuck on login screen Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Depends on: 30588 To recreate: 1. Set the syspref TwoFactorAuthentication (enforce or enabled) 2. Configure 2FA for a patron 3. Logout 4. Authenticate but don't enter the 2FA code 5. Switch off the syspref (disabled) => Patron is stuck on the login screen (actually can access Same can happens when the patron needs to setup 2FA. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 [Bug 30588] Add the option to require 2FA setup on first staff login -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 21472] New: Links in Additional Formats section of bib details do not work
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Bug ID: 21472 Summary: Links in Additional Formats section of bib details do not work Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul(a)flo.org QA Contact: testopia(a)bugs.koha-community.org The links that appear under the heading Additional Formats, built using data from 776 fields, are hardcoded to be like this in the OPAC: /cgi-bin/koha/opac-search.pl?q=control-number:__________ And like this in the staff interface: /cgi-bin/koha/catalogue/search.pl?q=control-number:__________ The blanks are filled in with the contents of the 776 field, subfield $w, with any parenthesized organization code stripped. Thus, for example, a 776 field like this: 776 08 $i Online version: [...] $z 9781938168000 $w (OCoLC)895896190 Would yield a staff URL like this: /cgi-bin/koha/opac-search.pl?q=control-number:895896190 But that link won't work, at least not in our case; control numbers found in 035 $a are indexed as other-control-number, not control-number, and the organization code is not stripped when indexing. However, a link like this does retrieve the bib record with the 776 field given above: /cgi-bin/koha/catalogue/search.pl?idx=other-control-number,phr&q=(OCoLC)895896190 These links are built in /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl (lines 808 ff.) and /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl (lines 756 ff.); for example, the latter looks like this:  <xsl:if test="marc:datafield[@tag=776]"> <span class="results_summary add_physical_form"> <span class="label">Additional physical formats: </span> <xsl:for-each select="marc:datafield[@tag=776]"> <xsl:variable name="linktext"> <xsl:choose> <xsl:when test="marc:subfield[@code='t']"> <xsl:value-of select="marc:subfield[@code='t']"/> </xsl:when> <xsl:when test="marc:subfield[@code='a']"> <xsl:value-of select="marc:subfield[@code='a']"/> </xsl:when> <xsl:otherwise> <xsl:text>No title</xsl:text> </xsl:otherwise> </xsl:choose> </xsl:variable> <xsl:if test="@ind2=8 and marc:subfield[@code='i']"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">i</xsl:with-param> </xsl:call-template> <xsl:text>: </xsl:text> </xsl:if> <xsl:choose> <xsl:when test="marc:subfield[@code='w']"> <a> <xsl:attribute name="href"> <xsl:text>/cgi-bin/koha/catalogue/search.pl?q=control-number:</xsl:text> <xsl:call-template name="extractControlNumber"> <xsl:with-param name="subfieldW"> <xsl:value-of select="marc:subfield[@code='w']"/> </xsl:with-param> </xsl:call-template> </xsl:attribute> <xsl:value-of select="$linktext"/> </a> </xsl:when> <xsl:otherwise> <xsl:value-of select="$linktext"/> </xsl:otherwise> </xsl:choose> <xsl:if test="position() != last()"> <xsl:text>; </xsl:text> </xsl:if> </xsl:for-each> </span> </xsl:if> The template "extractControlNumber" extracts the control number (minus parenthesized prefix) from the value in 776 $w. Unfortunately, this template is used elsewhere so I'm not sure it's safe to change it so that it does *not* strip the parenthesized prefix. Perhaps we could add a second parameter to it that specifies whether or not to strip it, with the default set to true. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 28670] New: api/v1/patrons_holds.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28670 Bug ID: 28670 Summary: api/v1/patrons_holds.t is failing randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com First time we get this one (Koha_Master/1700): 12:01:12 koha_1 | # Failed test 'Holds retrieved' 12:01:12 koha_1 | # at t/db_dependent/api/v1/patrons_holds.t line 56. 12:01:12 koha_1 | # Structures begin differing at: 12:01:12 koha_1 | # $got->[0]{hold_id} = '256' 12:01:12 koha_1 | # $expected->[0]{hold_id} = '255' 12:01:12 koha_1 | # Looks like you failed 1 test of 9. 12:01:12 koha_1 | 12:01:12 koha_1 | # Failed test 'list() tests' 12:01:12 koha_1 | # at t/db_dependent/api/v1/patrons_holds.t line 70. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 29224] New: OMNIBUS: Replace the use of jQueryUI Accordion
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 Bug ID: 29224 Summary: OMNIBUS: Replace the use of jQueryUI Accordion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 29222 As part of Bug 29222, "OMNIBUS: Replace the use of jQueryUI," we should replace the use of the jQueryUI accordion component on the following pages with Bootstrap's Collapse component. - Administration -> Table settings - Patrons -> Patrons requesting modifications - Tools -> Notices Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222 [Bug 29222] OMNIBUS: Replace the use of jQueryUI -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 32269] New: Circulation.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '23

19 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269 Bug ID: 32269 Summary: Circulation.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 25551 21:28:55 koha_1 | # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' 21:28:55 koha_1 | # at t/db_dependent/Circulation.t line 5683. 21:28:55 koha_1 | # got: '2022-11-17T20:25:30' 21:28:55 koha_1 | # expected: '2022-12-01T00:00:00' 21:28:55 koha_1 | 21:28:55 koha_1 | # Failed test 'Checkouts with auto-renewal can be renewed earliest on due date if no renewalbefore' 21:28:55 koha_1 | # at t/db_dependent/Circulation.t line 5689. 21:28:55 koha_1 | # got: '2022-11-17T20:25:30' 21:28:55 koha_1 | # expected: '2022-12-01T23:59:00' 21:28:55 koha_1 | # Looks like you failed 2 tests of 5. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 30011] New: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '23

18 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Bug ID: 30011 Summary: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 29115 I would like to upgrade jQueryUI to 1.13.1 everywhere. At the same time, the library will be re-compiled to get rid of unused modules like datepicker. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 32347] New: xt/find-nonutf8 not used and not maintain
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '23

18 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32347 Bug ID: 32347 Summary: xt/find-nonutf8 not used and not maintain Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org sh scripts are not run by our CI, the script cannot be run out of the box in ktd (xt/find-nonutf8: 31: isutf8: not found), and it's failing when the package is installed. kohadev-koha@kohadevbox:/kohadevbox/koha$ sh xt/find-nonutf8 koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/FontAwesome.otf koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.eot koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.ttf koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.woff koha-tmpl/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.woff2 koha-tmpl/intranet-tmpl/lib/tiny_mce/skins/ui/oxide-dark/fonts/tinymce-mobile.woff koha-tmpl/intranet-tmpl/lib/tiny_mce/skins/ui/oxide/fonts/tinymce-mobile.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Bold-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-BoldItalic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Italic-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff koha-tmpl/opac-tmpl/bootstrap/css/fonts/NotoSans-Regular-webfont.woff2 koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/FontAwesome.otf koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.eot koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.ttf koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.woff koha-tmpl/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.woff2 koha-tmpl/opac-tmpl/lib/verovio/000_acoustic_grand_piano.data misc/release_notes/release_notes_16_5_0.md misc/release_notes/release_notes_17_05_00.html misc/release_notes/release_notes_17_05_00.md t/Koha/I18N/po/xx_XX/LC_MESSAGES/Koha.mo t/db_dependent/Koha/Plugins/KitchenSinkPlugin.kpz t/db_dependent/data/frameworks/auth_type.ods t/db_dependent/data/frameworks/auth_type_smaller.ods t/db_dependent/data/frameworks/biblio_framework.ods t/db_dependent/data/frameworks/biblio_framework_new.ods t/db_dependent/data/frameworks/biblio_framework_smaller.ods Should we remove or adjust? -- You are receiving this mail because: You are watching all bug changes.

1 3