February 2022 - Koha-bugs - lists.koha-community.org

[Bug 26590] New: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26590 Bug ID: 26590 Summary: Koha::Patron::is_valid_age gives warning about $low variable's numeric comparison Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org I get the following warning message in plack-error.log: > Use of uninitialized value $low in numeric lt (<) at /usr/share/koha/lib/Koha/Patron.pm line 1109. This seems to happen because in /cgi-bin/koha/admin/categories.pl you can set "Age required" field to be empty and then in the is_valid_age subroutine in Patron.pm we compare patroncategory->dateofbirthrequired to numeric value and empty string or undef is not numeric. We should either add input validation to categories.pl or convert dateofbirthrequired to numeric value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 27010] New: Warnings produced by Elasticsearch QueryBuilder.pm
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Bug ID: 27010 Summary: Warnings produced by Elasticsearch QueryBuilder.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm we get following warnings: > [WARN] Use of uninitialized value $f in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605. > [WARN] Use of uninitialized value $d in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605. This seems to be due to _convert_sort_fields() not checking whether my ( $f, $d ) get initialized by the regex before using them in the map function: > 601 grep { $_->{field} } map { > 602 my ( $f, $d ) = /(.+)_(.+)/; > 603 { > 604 field => $sort_field_convert{$f}, > 605 direction => $sort_order_convert{$d} > 606 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 27011] New: Warnings in returns.pl
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Bug ID: 27011 Summary: Warnings in returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you check-in some books you get the following warnings to error logs: > [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 164. > [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 402. This seems to be due to treating the patron fields as non-null values: > 164 my $name = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : ''; The DB schema allows NULL values (and I think that is okay) so we should check for every one of these whether the value is defined or not before using it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 27161] New: Base.pm complains about unitialized value
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Bug ID: 27161 Summary: Base.pm complains about unitialized value Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: cornejo.alvaro(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org I get several errors on Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. 177 sub get_metadata { 178 my ( $self, $args ) = @_; 179 180 #FIXME: Why another encoding issue? For metadata containing non latin characters. 181 my $metadata = $self->{metadata}; 182 utf8::decode($metadata->{$_}) for keys %$metadata; 183 return $metadata; 184 } Verifying that $metadata value is set before applying utf8::decode will avoid that log error 177 sub get_metadata { 178 my ( $self, $args ) = @_; 179 180 #FIXME: Why another encoding issue? For metadata containing non latin characters. 181 my $metadata = $self->{metadata}; 182 if ($metadata !~ "") { 183 utf8::decode($metadata->{$_}) for keys %$metadata; 184 } 185 return $metadata; 186 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 27549] New: Warning "use of uninitialized value" on renew.pl
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27549 Bug ID: 27549 Summary: Warning "use of uninitialized value" on renew.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com, nugged(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 27745] New: Use of uninitialized value in hash element error at /usr/share/koha/lib/C4/Search.pm
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27745 Bug ID: 27745 Summary: Use of uninitialized value in hash element error at /usr/share/koha/lib/C4/Search.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Searching Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: nugged(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 27746] New: Use of uninitialized value $oclc in pattern match (m//) error at C4/Koha.pm
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27746 Bug ID: 27746 Summary: Use of uninitialized value $oclc in pattern match (m//) error at C4/Koha.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Searching Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: nugged(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 27861] New: Warning in C4/XSLT.pm - use of uninitialized value in numeric eq (==)
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27861 Bug ID: 27861 Summary: Warning in C4/XSLT.pm - use of uninitialized value in numeric eq (==) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In C4/XSLT.pm : elsif ( exists $itemtypes->{ $item->effective_itemtype } && $itemtypes->{ $item->effective_itemtype }->{notforloan} == 1 ) itemtype.notforloan is null by default, its generated a warning in logs. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 28228] New: Warns from plugins when metadata value not defined for key
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 Bug ID: 28228 Summary: Warns from plugins when metadata value not defined for key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 28545] New: Noisy uninitialized warn at opac-MARCdetail.pl line 313
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545 Bug ID: 28545 Summary: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org 19.11 warning like: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/opac/opac-MARCdetail.pl line 312. Same code, line 313 in master. Trivial fix. -- You are receiving this mail because: You are watching all bug changes.

1 20