February 2022 - Koha-bugs - lists.koha-community.org

[Bug 30110] New: Potential bug source: plenty of "my" declarations with conditional assignments
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30110 Bug ID: 30110 Summary: Potential bug source: plenty of "my" declarations with conditional assignments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart+koha(a)gmail.com We have a lot of these things like "my $var .= ...", what is shouldn't be (if no var before "my" so why conditional assignments?) - this looks like refactoring remnants since old times, here I found some to analyze (and fix): C4/Circulation.pm: 859: my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 }); C4/Message.pm: 165: my $format ||= sub { $_[0] || "" }; C4/Search.pm: 891: my $weighted_query .= "(rk=("; # Specifies that we're applying rank C4/Utils/DataTables/VirtualShelves.pm: 47: my $join_vs .= q| circ/circulation.pl: 477: my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 }); Koha/DateUtils.pm: 146: my $time_re .= qr| t/Labels_split_ccn.t: 41: my $split_num += scalar(@{$ccns->{$_}}); t/Labels_split_ddcn.t: 40: my $split_num += scalar(@{$ddcns->{$_}}); t/Labels_split_lccn.t: 43: my $split_num += scalar(@{$lccns->{$_}}); t/db_dependent/SIP/Message.t: 127: my $resp .= C4::SIP::Sip::maybe_add( FID_CALL_NUMBER, $sip_item->hold_patron_name, $server ); 840: my $resp .= C4::SIP::Sip::maybe_add( FID_CALL_NUMBER, $sip_item->hold_patron_bcode, $server ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 30059] New: Add a JS equivalent to Koha::Patron->get_age
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Bug ID: 30059 Summary: Add a JS equivalent to Koha::Patron->get_age Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 30055 To display the age of patrons in a table we will need to do the calculation in JS Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 25251] New: When a record has no items click delete all does not need an alert
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Bug ID: 25251 Summary: When a record has no items click delete all does not need an alert Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl It seems to be overkill, the delete all button is grayed out, has a tooltip, but click it generates an alert that must be dismissed. I think the first two are sufficient To recreate: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Delete all items' is grayed out 4 - Note hovering displays a note that there are no items 5 - Click on it anyway, an alert is generated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 25980] New: Capture cover image via webcam
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25980 Bug ID: 25980 Summary: Capture cover image via webcam Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Would like to see the ability to capture local cover image via webcam. Based off work being done in bug 6815. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 30000] New: Replace the use of jQueryUI tabs on the search engine configuration page
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 Bug ID: 30000 Summary: Replace the use of jQueryUI tabs on the search engine configuration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 29277 Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the search engine configuration (Elasticsearch) page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 29802] New: biblionumber in OPACHiddenItems breaks opac lists
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 Bug ID: 29802 Summary: biblionumber in OPACHiddenItems breaks opac lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When biblionumber is in the opachiddenitems preference the query to find hidden items dies: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous [for Statement "SELECT `me`.`itemnumber`, `me`.`biblionumber`, `me`.`biblioitemnumber`, `me`.`barcode`, `me`.`dateaccessioned`, `me`.`booksellerid`, `me`.`homebranch`, `me`.`price`, `me`.`replacementprice`, `me`.`replacementpricedate`, `me`.`datelastborrowed`, `me`.`datelastseen`, `me`.`stack`, `me`.`notforloan`, `me`.`damaged`, `me`.`damaged_on`, `me`.`itemlost`, `me`.`itemlost_on`, `me`.`withdrawn`, `me`.`withdrawn_on`, `me`.`itemcallnumber`, `me`.`coded_location_qualifier`, `me`.`issues`, `me`.`renewals`, `me`.`reserves`, `me`.`restricted`, `me`.`itemnotes`, `me`.`itemnotes_nonpublic`, `me`.`holdingbranch`, `me`.`timestamp`, `me`.`location`, `me`.`permanent_location`, `me`.`onloan`, `me`.`cn_source`, `me`.`cn_sort`, `me`.`ccode`, `me`.`materials`, `me`.`uri`, `me`.`itype`, `me`.`more_subfields_xml`, `me`.`enumchron`, `me`.`copynumber`, `me`.`stocknumber`, `me`.`new_status`, `me`.`exclude_from_local_holds_priority`, `branchtransfers`.`branchtransfer_id`, `branchtransfers`.`itemnumber`, `branchtransfers`.`daterequested`, `branchtransfers`.`datesent`, `branchtransfers`.`frombranch`, `branchtransfers`.`datearrived`, `branchtransfers`.`datecancelled`, `branchtransfers`.`tobranch`, `branchtransfers`.`comments`, `branchtransfers`.`reason`, `branchtransfers`.`cancellation_reason`, `reserves`.`reserve_id`, `reserves`.`borrowernumber`, `reserves`.`reservedate`, `reserves`.`biblionumber`, `reserves`.`branchcode`, `reserves`.`desk_id`, `reserves`.`notificationdate`, `reserves`.`reminderdate`, `reserves`.`cancellationdate`, `reserves`.`cancellation_reason`, `reserves`.`reservenotes`, `reserves`.`priority`, `reserves`.`found`, `reserves`.`timestamp`, `reserves`.`itemnumber`, `reserves`.`waitingdate`, `reserves`.`expirationdate`, `reserves`.`lowestPriority`, `reserves`.`suspend`, `reserves`.`suspend_until`, `reserves`.`itemtype`, `reserves`.`item_level_hold`, `reserves`.`non_priority` FROM `items` `me` LEFT JOIN `branchtransfers` `branchtransfers` ON `branchtransfers`.`itemnumber` = `me`.`itemnumber` LEFT JOIN `reserves` `reserves` ON `reserves`.`itemnumber` = `me`.`itemnumber` WHERE ( ( ( `biblionumber` NOT IN ( ?, ?, ?, ?, ?, ? ) OR `biblionumber` IS NULL ) AND `itemlost` = ? AND ( `itype` NOT IN ( ?, ? ) OR `itype` IS NULL ) AND ( `location` NOT IN ( ?, ? ) OR `location` IS NULL ) AND `me`.`biblionumber` = ? AND 1=1 ) ) ORDER BY `me`.`itemnumber`" -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 30161] New: Remove duplicate include lines
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30161 Bug ID: 30161 Summary: Remove duplicate include lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Probably a rebase issue on bug 23302 caused this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 30008] New: Software error in details.pl when invalid MARCXML and showing component records
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 Bug ID: 30008 Summary: Software error in details.pl when invalid MARCXML and showing component records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1 - Find a record in the staff catalog 2 - Edit the record 3 - In the 520 notes field, add an ASCII escape character (27 decimal, 1b hex) On ubuntu Ctrl+Shift+u, then 1b, enter 4 - Save the record 5 - Set syspref ShowComponentRecords to 'both...' 6 - On record details: New->New child record 7 - Save the record 8 - Attempt to view the parent record in the staff client and opac - FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 29940] New: Phase out jquery.cookie.js in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Bug ID: 29940 Summary: Phase out jquery.cookie.js in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 11873 Blocks: 27750 The OPAC uses jquery.cookie.js in one feature: "Return to advanced search." This patch will replace use of jquery.cookie.js with js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 [Bug 11873] Upgrade jstree jQuery plugin to the latest version https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 30004] New: Prevent TooMany from executing too many SQL queries
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Bug ID: 30004 Summary: Prevent TooMany from executing too many SQL queries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org If a maximum number of checkouts allowed is defined in circulation rules, C4::Circulation::TooMany will loop over all patron's checkouts. When a patron has several hundreds of checkouts, it can really slow down the checkout process by several seconds (or even tens of seconds) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18