March 2022 - Koha-bugs - lists.koha-community.org

[Bug 29457] New: Fee Cancellation records the wrong manager_id
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Bug ID: 29457 Summary: Fee Cancellation records the wrong manager_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org With the introduction of bug 22008 it has highlighted an error in the charge cancellation controller. We are passing '$user', which contains cardnumber/userid, to cancel when we should be passing a borrowernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 67

[Bug 29552] New: flatpickr misses quick shortcut to "Today" date
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Bug ID: 29552 Summary: flatpickr misses quick shortcut to "Today" date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_22_05_candidate Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: david(a)davidnind.com, jonathan.druart+koha(a)gmail.com, martin.renvoize(a)ptfs-europe.com, nugged(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 29478 >From bug 29478 comment 5: > I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field. I decided we should go with what we have for this coming release, but we should really implement the above asap after release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 30276] New: Web-based installer failing on db upgrade for 30060
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30276 Bug ID: 30276 Summary: Web-based installer failing on db upgrade for 30060 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Trying to upgrade a gitified test-install to current master, I get this error: Upgrade to 21.12.00.016 [09:27:15]: Bug 30060 - Update user_permissions to add primary key and remove null option from code column ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'code': used in a foreign key constraint 'user_permissions_ibfk_2' at /home/magnus/kohaclone-sv/C4/Installer.pm line 738 Dropped any previously created primary key ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'code': used in a foreign key constraint 'user_permissions_ibfk_2' at /home/magnus/kohaclone-sv/C4/Installer.pm line 738 Removed any duplicate rows ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'code': used in a foreign key constraint 'user_permissions_ibfk_2' at /home/magnus/kohaclone-sv/C4/Installer.pm line 738 The table looks like this: MariaDB [koha_koha]> show create table user_permissions\G *************************** 1. row *************************** Table: user_permissions Create Table: CREATE TABLE `user_permissions` ( `borrowernumber` int(11) NOT NULL DEFAULT '0', `module_bit` int(11) NOT NULL DEFAULT '0', `code` varchar(64) COLLATE utf8mb4_unicode_ci DEFAULT NULL, KEY `user_permissions_ibfk_1` (`borrowernumber`), KEY `user_permissions_ibfk_2` (`module_bit`,`code`), CONSTRAINT `user_permissions_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `user_permissions_ibfk_2` FOREIGN KEY (`module_bit`, `code`) REFERENCES `permissions` (`module_bit`, `code`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 1 row in set (0.00 sec) MariaDB [koha_koha]> describe user_permissions; +----------------+-------------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +----------------+-------------+------+-----+---------+-------+ | borrowernumber | int(11) | NO | MUL | 0 | | | module_bit | int(11) | NO | MUL | 0 | | | code | varchar(64) | YES | | NULL | | +----------------+-------------+------+-----+---------+-------+ 3 rows in set (0.01 sec) And it is currently empty: MariaDB [koha_sverige]> select * from user_permissions; Empty set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 30180] New: Deprecate after_hold_create hook
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30180 Bug ID: 30180 Summary: Deprecate after_hold_create hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 30072 introduces 'after_hold_action' hooks, that get passed an 'action' parameter. When the hold is placed, we should just use that hook, with the 'place' action parameter. This will make hooks more consistent. Proposal: deprecate 'after_hold_create' on the 22.05 release. Adding a warning in the logs to make developers update their plugins using the hook. Remove it in the 22.11 release. This should be voted on a dev meeting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 30127] New: By default show pending suggestions tab
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Bug ID: 30127 Summary: By default show pending suggestions tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 28578] New: Terminology: reserve/reservation should be hold
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28578 Bug ID: 28578 Summary: Terminology: reserve/reservation should be hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt:53 %s Set reserve to transit and transfer book to %s: %s %sCancel reservation and then attempt transfer: %s␠ -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 27539] New: Console warnings "Use of uninitialized value in split" on "Holds to pull" page
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Bug ID: 27539 Summary: Console warnings "Use of uninitialized value in split" on "Holds to pull" page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: stalkernoid(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com, nugged(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 25440] New: Remove undef and CGI warnings and fix defaults in circulation rules
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Bug ID: 25440 Summary: Remove undef and CGI warnings and fix defaults in circulation rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: nugged(a)gmail.com Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I am proposing a set of fixes, which I found when doing another mine complicated circulation rules task: I will post separate patches one-by-one with explanations here. -- You are receiving this mail because: You are watching all bug changes.

1 40

[Bug 25491] New: Perl warning at the login page of installer
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Bug ID: 25491 Summary: Perl warning at the login page of installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: slavashishkin(a)gmail.com Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I encountered this warning at the login page of installer /cgi-bin/koha/installer/install.pl: Use of uninitialized value $info{"invalid_username_or_password"} in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm line 387. This requires a simple fix to check for undef before numeric comparison. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 25506] New: Perl undef warning on the "About Koha" page
by bugzilla-daemon＠bugs.koha-community.org 17 May '22

17 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506 Bug ID: 25506 Summary: Perl undef warning on the "About Koha" page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: slavashishkin(a)gmail.com Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: nugged(a)gmail.com, stalkernoid(a)gmail.com Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. -- You are receiving this mail because: You are watching all bug changes.

1 14