March 2022 - Koha-bugs - lists.koha-community.org

[Bug 30325] New: (Bug 30098 follow-up) Broken patron search redirect when one result
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 Bug ID: 30325 Summary: (Bug 30098 follow-up) Broken patron search redirect when one result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 30098 fixed patron search behavior when a later page has only 1 result, but broke the redirect when there is only a single result from search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 30061] New: Simplify Koha::Patron->get_age
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 Bug ID: 30061 Summary: Simplify Koha::Patron->get_age Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The method could just use regular DateTime/DateTime::Duration arithmetic instead of parsing strings and doing math manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 30058] New: Add a Koha::Patrons method to filter by permissions
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 Bug ID: 30058 Summary: Add a Koha::Patrons method to filter by permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 25285] New: Wrong message when plugin minimum version isn't met
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Bug ID: 25285 Summary: Wrong message when plugin minimum version isn't met Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor(a)tuxayo.net QA Contact: testopia(a)bugs.koha-community.org (not sure about the bug category) == Test plan == - Install the Kitchen Sink plugin: https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases - (the .kpz) - go to the plugin directory. - example: /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions - edit minimum_version to be above you koha version - go plugin home page - you should see «Warning: This report was written for a newer version of Koha. Run at your own risk.» - this wrong! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 17648] New: ACCTDETAILS notice does not show in notices.pl
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Bug ID: 17648 Summary: ACCTDETAILS notice does not show in notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. This may be useful from the standpoint that the message is sent immediately, but it should still be added to message_queue with status='sent', so that it's available when looking at the borrowers notices. --Barton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 29957] Cookies not removed after logout
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957 --- Comment #112 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 132239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132239&action=e… Bug 29957: (follow-up) correct spelling QA complaint Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29957] Cookies not removed after logout
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957 --- Comment #111 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 132238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132238&action=e… Bug 29957: Add --keep-cookie option to koha-create As requested on comment99. Personally I do not feel that it should be a requirement for adding a koha-conf entry though. Note that koha-create does/did not even support adding multiple line entries to koha-conf like we do here now. But it might be a start for adding them? Test plan: The following tweak might help you to test without running the complete koha-create, while still convincing you: [1] cp debian/templates/koha-conf-site.xml.in /etc/koha/test.conf [2] Add the following line in debian/scripts/koha-create. Append if after the BCRYPT_SETTINGS= line on L652: generate_config_file test.conf test.xml; exit [3] Run debian/scripts/koha-create --keep-cookie A [4] Check if you see <do_not_remove_cookie>A<..> in test.xml. [5] Run debian/scripts/koha-create --keep-cookie A --keep-cookie B [6] Check for two lines in test.xml [7] Run debian/scripts/koha-create clone_name [8] Check that the __KEEP_COOKIE__ line is gone in test.xml. [9] Undo the tweak by removing test.xml and /etc/koha/test.conf, and removing the added line from koha-create. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29957] Cookies not removed after logout
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957 --- Comment #110 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 132237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132237&action=e… Bug 29957: Add example lines in koha-conf.xml Test plan: Just comments. Nothing to test. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Amended: using new name for deny list. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29957] Cookies not removed after logout
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957 --- Comment #109 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 132236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132236&action=e… Bug 29957: Let check_api_auth return created cookie The cookie created on L1496 is useless, since it is not returned. We could either remove the cookie creation (unchanged behavior). But since check_api_auth is expected to return a cookie when it is ok, I opt for returning the cookie here (corrected behavior). Test plan: Logout in staff. Check on staff: /cgi-bin/koha/svc/localization?id=1 You should have a 400 response. Login with staff credentials (incl. manage_itemtypes) Revisit same URL. You should see a JSON response. Check if you can hit other staff pages. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29957] Cookies not removed after logout
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '22

25 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29957 --- Comment #108 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 132235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132235&action=e… Bug 29957: Adjust push @$cookie statements in Auth We can now use $cookie_mgr->replace_in_list instead. This effectively removes duplicates and keeps the newest cookie. Note: In the test plan below we are just verifying if this patch did not change behavior. The replace_in_list routine has been tested already in a unit test. Test plan: Run t/db_dependent/Auth.t Login at OPAC. Hit some opac and staff pages. Perform an Advanced search on OPAC. Check cookies in browser. Logout. Check cookies again. Verify with your do_not_remove_cookie lines in koha-conf.xml. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0