May 2022 - Koha-bugs - lists.koha-community.org

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #122882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #42 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135274&action=e… Bug 7021: Catch new introductions of UpdateStats -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #41 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135273&action=e… Bug 7021: Remove superflous 'open' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #40 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135272&action=e… Bug 7021: DO NOT PUSH! Schema changes -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #39 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135271&action=e… Bug 7021: Terminology - usercode -> categorycode Lets stick to standard terminology and use categorycode rather than usercode here. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #38 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135270&action=e… Bug 7021: Patron category in the statistics table This patch populates the koha.statistics.usercode with borrowers.categorycode where it is easily available. Currently for statistics.type 'issue' OR 'localuse' OR 'renew'. Supplied a script to UPDATE the old statistics records. Have fun! To test: 1. Add loan for patron. 2. Check statistics table => 'usercode' column for this issue should now contain patrons categorycode To test add_statistics_borrowers_categorycode.pl: 1. Run add_statistics_borrowers_categorycode.pl 2. Check statistics table => all statistics which are type 'issue' OR 'localuse' OR 'renew' should now contain patrons categorycode in 'usercode' column Also prove that tests in t/db_dependent/Circulation.t still pass. Rebased-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7021] Add patron category to the statistics table
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129121|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 135269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135269&action=e… Bug 7021: Reintroduce usercode column This patch reintroduces usercode column to statistics table. To test: 1. Apply patch and update database 2. Confirm there's column usercode in statistics table Sponsored-by: Koha-Suomi Oy Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 29381] New: Auto-renewal digest messages are sent on every cron run
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Bug ID: 29381 Summary: Auto-renewal digest messages are sent on every cron run Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)iki.fi QA Contact: testopia(a)bugs.koha-community.org Depends on: 18532 If you have patrons with checkouts that have auto-renewal enabled and the patron has checked in their messaging preferences that they want auto-renewal messages as digests then they get every day / cron run a message with al list of their checkouts that has auto-renewal enabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] Messaging preferences for auto renewals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 30222] New: Auto_renew_digest still sends every day when renewals are not allowed
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Bug ID: 30222 Summary: Auto_renew_digest still sends every day when renewals are not allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 29381 The non-digest auto-renew notice checks to see whether or not the auto-renew error on the issue has changed since the previous day. If the error is not new, the notice doesn't generate. In the auto-renew-digest, we don't do that check. For any error other than auto_too_soon, the patron will be notified every day. Bug 29381 tried to address this, but did not correct the whole issue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 [Bug 29381] Auto-renewal digest messages are sent on every cron run -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 46

[Bug 30278] New: Auto renewal should be moved to an object method
by bugzilla-daemon＠bugs.koha-community.org 23 May '22

23 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30278 Bug ID: 30278 Summary: Auto renewal should be moved to an object method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 29381 and bug 30222 both required reviewing the conditions under which auto renewal notices are sent. It would be better if the renewals were handled by a unit tested subroutine We should have: Koha::Patron->auto_renew_checkouts Koha::Checkouts->filter_by_auto_renew->renew the renewal can report back on the status and then notify patron, depending on settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5