May 2022 - Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 30 May '22

30 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29418 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 30 May '22

30 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #523 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #522) > (In reply to Martin Renvoize from comment #520) > > Nice one.. faith in community restored.. sorry for being grumpy > > Now I'm feeling grumpy reading through these patches again 😅. > Actually now that I think about it... I feel like I've already grumped about this code recently... Ah yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418#c16 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 30 May '22

30 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #522 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Martin Renvoize from comment #520) > Nice one.. faith in community restored.. sorry for being grumpy Now I'm feeling grumpy reading through these patches again 😅. (In reply to Marcel de Rooy from comment #499) > Created attachment 126883 [details] [review] > Bug 11175: (QA follow-up) Move get_component_part_query This patch removed the double-quotes from the search terms which causes this to break when using Zebra if you're using a title like "MyTitle: MySubtitle" since the following query is a syntax error: Host-item=(MyTitle= MySubtitle) It should be: Host-item=("MyTitle= MySubtitle") According to https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-q…, it looks like Elasticsearch works the same way. Single words don't need to be quoted but terms consisting of more than one word do. Regarding Zebra, we actually have the tools to easily catch this in our unit tests: #!/usr/bin/perl use strict; use warnings; use C4::Context; use ZOOM; my $Zconn = C4::Context->Zconn; eval { my $bad = ZOOM::Query::CCL2RPN->new("Host-item=(MyTitle= MySubtitle)",$Zconn); }; warn $@ if $@; my $good = ZOOM::Query::CCL2RPN->new('Host-item=("MyTitle= MySubtitle")',$Zconn); That code will output the following error: ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from diag-set 'ZOOM' at test.pl line 10. It looks like https://metacpan.org/pod/Search::Elasticsearch::Compat::QueryParser#check() could provide similar error checking for Elasticsearch. If we just syntax checked our query strings, we'd run into far fewer problems... Anyway, I'll open a new bug report for this one. I just figured it would be good for folk to hear about it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13614] Replace usage of YUI on basket groups page
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david(a)davidnind.com> --- Everything is working as expected, except for the second last step: no messages, such as "There are no ungrouped baskets.", are shown on the group edit form if there are no rows. A nice improvement as well, I like the tables and the action buttons (add to group/remove) compared with the drag and drop. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26630] New: Allow custom text for each library on Purchase Suggestion Page
by bugzilla-daemon＠bugs.koha-community.org 27 May '22

27 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Bug ID: 26630 Summary: Allow custom text for each library on Purchase Suggestion Page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: lisetteslatah(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It would be great if using the news tool we could set custom text at the top of the purchase suggestion screen based on the home branch of the patron. Currently I'm using jq to do this, but it would be nice if it was built in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 29823] New: Prohibit the same borrowerfield to be checked in the conflicting system preferences
by bugzilla-daemon＠bugs.koha-community.org 27 May '22

27 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29823 Bug ID: 29823 Summary: Prohibit the same borrowerfield to be checked in the conflicting system preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com There are two system preferences for determining what fields show and don't show during self-registration. It would be nice when a library chose a "mandatory" field in the mandatory sys preference, that this field would not be available to check in the "unwanted" field option and vice versa. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 14806] Action Log for Modifying borrower messaging preferences
by bugzilla-daemon＠bugs.koha-community.org 27 May '22

27 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Amanda Campbell <acampbell(a)hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell(a)hmcpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13614] Replace usage of YUI on basket groups page
by bugzilla-daemon＠bugs.koha-community.org 26 May '22

26 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11708 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 26 May '22

26 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13614 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 [Bug 13614] Replace usage of YUI on basket groups page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13614] Replace usage of YUI on basket groups page
by bugzilla-daemon＠bugs.koha-community.org 26 May '22

26 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 135394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135394&action=e… Bug 13614: Replace usage of YUI on basket groups page This patch updates the basket groups interface so that it doesn't rely on YUI to move baskets in and out of groups. The patch also removes all YUI assets and many long-obsolete references to YUI-related classes and IDs. To test, apply the patch and go to Acquisitions. - Locate a vendor with multiple closed baskets. - Click "Basket groups" in the sidebar menu. - Create or edit a basket group. - On the basket group page you should see the basket group form in one column and ungrouped baskets in another. - Both grouped and ungrouped baskets should be in a sortable DataTable. - Test that when you click the "Add to group" button on an ungrouped basket the row is removed from the table of ungrouped baskets and added to the table of grouped baskets. - The button text on the row should now read "Remove." - Test the reverse operation: Clicking "Remove" on a grouped basket should move it to the table of ungrouped baskets. - Test that when all baskets are moved out of either of the tables a row is displayed with a message specific to that table, e.g. "There are no ungrouped baskets." - Test that the basket group saves correctly when zero or more baskets are added to the group. -- You are receiving this mail because: You are watching all bug changes.

1 0