May 2022 - Koha-bugs - lists.koha-community.org

[Bug 18283] New: Display improvements on report results - hide code and change wording
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283 Bug ID: 18283 Summary: Display improvements on report results - hide code and change wording Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request
by bugzilla-daemon＠bugs.koha-community.org 31 May '22

31 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30195 [Bug 30195] opac-suggestions.pl should use ISBN to FindDuplicate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30097] New: Cataloguing - advanced editor not loading
by bugzilla-daemon＠bugs.koha-community.org 30 May '22

30 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30097 Bug ID: 30097 Summary: Cataloguing - advanced editor not loading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Created attachment 130556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130556&action=e… Screenshot - Loading message fro advanced cataloguing editor When accessing the advanced editor for cataloguing it does not load - see the screenshot. The screen says "Loading, please wait.." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 30866] New: In unit tests, validate CCL queries using ZOOM::Query::CCL2RPN
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30866 Bug ID: 30866 Summary: In unit tests, validate CCL queries using ZOOM::Query::CCL2RPN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org We should validate that we're creating correct CCL in Koha using our unit tests. I've included a simple example at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175#c522 -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #524 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #522) > > Regarding Zebra, we actually have the tools to easily catch this in our unit > tests: > Except of course we're feeding the output of "get_components_query" into $searcher->simple_search_compat or into search.pl/opac-search.pl "q" parameter which both transform the query differently (both for Zebra and for Elasticsearch so we get at least 4x more things to check). Well... if it were easy it would already be done 🤣. Someday... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29283] New: Cannot delete basket with cancelled order for deleted biblio
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Bug ID: 29283 Summary: Cannot delete basket with cancelled order for deleted biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: - have a basket with at least one order - click "Cancel order and delete catalog record", confirm cancellation of order and deletion of bib - click "Delete basket", confirm deletion - get error "Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/basket.pl line 136. at /usr/share/perl/5.28/Carp.pm line 289" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865 [Bug 30865] Koha::Biblio->get_components_query should double quote Host-item search -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29418 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #523 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #522) > (In reply to Martin Renvoize from comment #520) > > Nice one.. faith in community restored.. sorry for being grumpy > > Now I'm feeling grumpy reading through these patches again 😅. > Actually now that I think about it... I feel like I've already grumped about this code recently... Ah yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418#c16 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 29 May '22

29 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #522 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Martin Renvoize from comment #520) > Nice one.. faith in community restored.. sorry for being grumpy Now I'm feeling grumpy reading through these patches again 😅. (In reply to Marcel de Rooy from comment #499) > Created attachment 126883 [details] [review] > Bug 11175: (QA follow-up) Move get_component_part_query This patch removed the double-quotes from the search terms which causes this to break when using Zebra if you're using a title like "MyTitle: MySubtitle" since the following query is a syntax error: Host-item=(MyTitle= MySubtitle) It should be: Host-item=("MyTitle= MySubtitle") According to https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-q…, it looks like Elasticsearch works the same way. Single words don't need to be quoted but terms consisting of more than one word do. Regarding Zebra, we actually have the tools to easily catch this in our unit tests: #!/usr/bin/perl use strict; use warnings; use C4::Context; use ZOOM; my $Zconn = C4::Context->Zconn; eval { my $bad = ZOOM::Query::CCL2RPN->new("Host-item=(MyTitle= MySubtitle)",$Zconn); }; warn $@ if $@; my $good = ZOOM::Query::CCL2RPN->new('Host-item=("MyTitle= MySubtitle")',$Zconn); That code will output the following error: ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from diag-set 'ZOOM' at test.pl line 10. It looks like https://metacpan.org/pod/Search::Elasticsearch::Compat::QueryParser#check() could provide similar error checking for Elasticsearch. If we just syntax checked our query strings, we'd run into far fewer problems... Anyway, I'll open a new bug report for this one. I just figured it would be good for folk to hear about it. -- You are receiving this mail because: You are watching all bug changes.

1 0