June 2022 - Koha-bugs - lists.koha-community.org

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #64 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135821&action=e… Bug 11889: (QA follow-up) Fix tests Noise from 28959 changing category to public. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #63 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135820&action=e… Bug 11889: (QA follow-up) Changes for wantarray move in ->search See bug 29844. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #62 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135819&action=e… Bug 11889: (QA follow-up) Convert to new atomicupdate style The first patch contained an old .sql atomic update. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #61 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135818&action=e… Bug 11889: (QA follow-up) Add POD ground work -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135813|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135817&action=e… Bug 11889: (follow-up) Tests and new get_shared_shelves This is a manual reconstruction of an older patch, that git did not want to apply anymore (sha trouble etc.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135812|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135816&action=e… Bug 11889: (QA follow-up) Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135809|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135815&action=e… Bug 11889: (follow-up) Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135808|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 135814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135814&action=e… Bug 11889: Disown a list upon deletion of owner This patch adds a syspref 'ListOwnershipUponPatronDeletion' which decides if all the owner's lists (public and private) are deleted when the owner is deleted, or if the ownership of their public and shared lists are transfered to the user who deleted the owner (private lists that are not shared are always deleted). To test: 1) Apply patch and update database 2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...' 3) Set up a superlibrarian user 4) Log in as this superlibrarian user and set up three lists, a public list (maybe named 'public'), and two private lists (named 'private' and 'shared') 5) Log in as this user to the opac (if you haven't already) and share the 'shared' list with someone 6) View the virtualshelves table in mysql to see the three lists you just created under your new user 7) Also view the virtualshelfshares table in mysql to see the 'shared' list 8) Log into the staff client with your regular user (a different user to the one you just created) 9) Search for the user you just created and delete them 10) Go to your lists 11) You should see the 'shared' list under your private lists, and their 'public' list under your public lists, both with you as the owner 12) if you view both the virtualshelves table and the virtualshelfshares table in mysql again, youll see you are now the owner and the 'private' list will no longer exist. 13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...' 14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and 'public' lists before you re-create them) 15) You should not see any of the lists you just made under private or public lists this time. To confirm, check the virtualshelves table in mysql and make sure that all three lists have been deleted. Sponsored-by: Catalyst IT Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> 2022-06-08 Removed old atomic update. See new follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '22

08 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108246|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0