July 2022 - Koha-bugs - lists.koha-community.org

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #74 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 137727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137727 Bug 14784: Fix checkin message for restricted patrons Review of attachment 137727: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=147…) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +2296,4 @@ > if ( $issue and $issue->is_overdue($return_date) ) { > # fix fine days > my ($debardate,$reminder) = _debar_user_on_return( $patron_unblessed, $item->unblessed, dt_from_string($issue->date_due), $return_date ); > + if ($debardate and $debardate ne "9999-12-31") { There really shouldn't be any 9999-12-31 dates left for debardate.. we tried to clean them all up back with the 3.15.00.029 database update. @@ +2302,5 @@ > + } else { > + $messages->{'Debarred'} = $debardate; > + } > + } elsif ($patron->debarred) { > + if ( $patron->debarred eq "9999-12-31") { As above -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25115] New: Use get_effective_rule for getting rental discount
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 Bug ID: 25115 Summary: Use get_effective_rule for getting rental discount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org We have this logic for searching rentaldiscount rule https://github.com/Koha-Community/Koha/blob/6ac037f817def256c85706413036bee… Why? This is against documentation on sorting order of circulation rules in the user interface. Use Koha::CirculationRules->get_effective_rule() instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 26593] New: Rental discounts are applied in wrong precedence order
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593 Bug ID: 26593 Summary: Rental discounts are applied in wrong precedence order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org GetIssuingCharges uses its own private sub to choose the correct rental discount rule, specifying the rules returned in order: 1 - same library, same category, same itemtype 2 - all libraries, same category, same itemtype 3 - same library, same category, all itemtypes 4 - all libraries, same category, all itemtypes It doesn't match what the circ rules page says, and is missing several options: same library, same patron category, same item type same library, same patron category, all item types same library, all patron categories, same item type same library, all patron categories, all item types default (all libraries), same patron category, same item type default (all libraries), same patron category, all item types default (all libraries), all patron categories, same item type default (all libraries), all patron categories, all item types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 7960] Choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|choice to not show the text |Choice to not show the text |labels for item types |labels for item types -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98778|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 137760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137760&action=e… Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-results-grouped.tt - opac-shelves.tt - opac-user.tt Sponsored-by: Catalyst IT Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 137753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137753&action=e… Bug 14680: Always subtract discount from price to calculate estimated cost This patch simply removes a discrepancty where when a discount is provided on the order form we add the discount to the price, and when it comes form the vendor we subtract the discount. Discounts should always descrease the estimated cost To test: 0 - Have a vendor with a discount of 10% specified 1 - Export a record from your Koha 2 - Stage the record for import and match on biblionumber 3 - Add to a basket in acq from the staged file 4 - Select the title, and set order price to $10 and do not fill the discount field 5 - Add the order - note $10 RRP and $9 actual/budgeted cost 6 - Repeat 2&3 7 - Select the tile, set price $10 and discount 50% 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL 9 - Apply patch, restart all 10 - Repeat 2-7 11 - Add the order, note $10 RRP and $5 actual.budgeted cost Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14680] When creating orders from a staged file discounts supplied in the form are added
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '22

15 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I'd like to add that $c is really not a nice name for a variable, but that was there 'before patch': my $c = $c_discount ? $c_discount : $bookseller->discount; -- You are receiving this mail because: You are watching all bug changes.

1 0