July 2022 - Koha-bugs - lists.koha-community.org

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '22

01 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- My plan was somehting like this (unfinished on itself): Still had to set the flag when I found a https ref. And check for commented refs. But this is just way too much imo. sub _convert_https { my ( $self, $code, $key, $params ) = @_; my $level = $params->{level} // 0; # to limit recursion level if( $level > $self->max_recursion_level ) { die; #FIXME Exception } # Find refs and resolve recursively my ( $href, $tmp_name, $new_code, $flag, @replaces, $changed ); while( $code =~ /<(?:xsl):(?:import|include)\s*href\s*=\s*['"]([^'"]+)['"]/gcs ) { $href = $1; if( $include_cache->{$href} ) { $new_code = $include_cache->{$href}; $changed = 1; } else { $new_code = $self->_get_code( $href ); ( $new_code, $flag ) = $self->_convert_https( $new_code, $href, { level => $level + 1 } ); $changed = 1 if $flag; } next unless $changed; $tmpname = MIME::Base64::encode_base64url( $href, q{} ); if( !$self->{_tempdir} || !-e $self->{_tempdir}. '/'. $tmpname ) { $self->{_tempdir} //= File::Temp->newdir; write_file( $self->{_tempdir}. '/'. $tmpname, { binmode => ':utf8' }, Encode::encode_utf8($new_code) ); } push @replaces, { href => $href, file => $self->{_tempdir}. '/'. $tmpname }; } # Replace refs foreach my $h ( @replaces ) { $code =~ s/(?=<(?:xsl):(?:import|include)\s*href\s*=\s*)(['"])${h->{href}}['"]/$1${h->{file}}$1/; } # Finalize $include_cache->{$key} = $code if !$self->disable_caching && $changed && $key; return ( $code, $changed // 0 ); } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29919] New: Elasticsearch missing alias pl for place-of-publication
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '22

01 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29919 Bug ID: 29919 Summary: Elasticsearch missing alias pl for place-of-publication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com Elasticsearch is missing alias "pl" for "place-of-publication". Advanced search uses directly this alias. Currently only working with Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 31075] New: Script overdue_notices.pl should use GetPreparedLetter
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '22

01 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075 Bug ID: 31075 Summary: Script overdue_notices.pl should use GetPreparedLetter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org The overdue_notices.pl script contains a lot of code for letter/notice handling that really should not be there. Some regular notice constructs do not work since it is doing its own thing. Look at this example: my $letter = parse_overdues_letter( { letter_code => $overdue_rules->{"letter$i"}, borrowernumber => $borrowernumber, branchcode => $branchcode, items => \@items, substitute => { # this appears to be a hack to overcome incomplete features in this code. bib => $library->branchname, # maybe 'bib' is a typo for 'lib<rary>'? 'items.content' => $titles, 'count' => $itemcount, }, # If there is no template defined for the requested letter # Fallback on the original type message_transport_type => $letter_exists ? $effective_mtt : $mtt, } ); The comment talks about a hack to overcome incomplete features. I did mark this as major, and not enhancement for refactoring. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6