July 2022 - Koha-bugs - lists.koha-community.org

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137208|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137234&action=e… Bug 15187: (QA follow-up) Add unit test This patch adds a unit test for the newly introduced filter. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137207|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137233&action=e… Bug 15187: Index 880 in Zebra the same as Elasticsearch This patch modifies the MARC21 export to Zebra, so that 880 fields are rewritten as their linked fields, in the same way that we already do with Elasticsearch, so that the alternate graphic representation of fields are indexed accordingly. (ie 880 $6245-01 Chinese titles will be indexed into the title index using the 245 rules) Test plan: 0. Apply patch 1. Turn on ICU indexing 1b. vi /etc/koha/zebradb/etc/default.idx 1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml 1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml 1e. Restart Zebra server 1f. Re-index Zebra 2. Add record with a 880 $6 245-01 $a 教牧書信 field. 3. Search for this record using a title index with the Chinese title 4. Note that the record is correctly retrieved (Note: This test probably works better using author or series as they present as links on the detail page which makes the fix more obviously useful.) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29495] New: Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Bug ID: 29495 Summary: Issue link is lost in return claims when using 'MarkLostItemsAsReturned' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We have a foreign key constraint in return_claims for issue_id.. this means that if you have 'MarkLostItemsAsReturned' enabled, we first add the issue_id linking to the original checkout, then immediately move the checkout to old_issues and nuke the issue_id from the claims_return table :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 104

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I added a unit test for you to get this through QA.. Tomas may want to rename the filter at push.. I couldn't come up with a nicer name.. but I don't really like they we call out it's a Zebra thing... What I've not managed to test.. does this cause any issues with non-icu indexed Koha's.. I imagine not as you are unlikely to have such a field in your database in the first place without having enabled ICU (all our customers are ICU by default in case). Passing QA.. scripts are happy, we're now covered by tests and it's a great improvement. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #24 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137208&action=e… Bug 15187: (QA follow-up) Add unit test This patch adds a unit test for the newly introduced filter. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137050|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137207&action=e… Bug 15187: Index 880 in Zebra the same as Elasticsearch This patch modifies the MARC21 export to Zebra, so that 880 fields are rewritten as their linked fields, in the same way that we already do with Elasticsearch, so that the alternate graphic representation of fields are indexed accordingly. (ie 880 $6245-01 Chinese titles will be indexed into the title index using the 245 rules) Test plan: 0. Apply patch 1. Turn on ICU indexing 1b. vi /etc/koha/zebradb/etc/default.idx 1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml 1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml 1e. Restart Zebra server 1f. Re-index Zebra 2. Add record with a 880 $6 245-01 $a 教牧書信 field. 3. Search for this record using a title index with the Chinese title 4. Note that the record is correctly retrieved (Note: This test probably works better using author or series as they present as links on the detail page which makes the fix more obviously useful.) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #22 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This is really nice and elegant David! QAing now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29660] New: reserve/request.pl should not deal with biblioitem
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Bug ID: 29660 Summary: reserve/request.pl should not deal with biblioitem Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The way reserve/request.pl is written is wrong, hard to read and to maintain. We should not use a biblioitemloop variable as there is a 1-1 link between biblio and biblioitem That would simplify the code a lot and make it more readable. -- You are receiving this mail because: You are watching all bug changes.

1 38

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #68 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Did we lose the tests? -- You are receiving this mail because: You are watching all bug changes.

1 0