August 2022 - Koha-bugs - lists.koha-community.org

[Bug 31492] New: Patron image upload fails on first attempt with CSRF failure
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Bug ID: 31492 Summary: Patron image upload fails on first attempt with CSRF failure Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: matthew.lindfield-seager(a)hope.edu.kh QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com After upgrading to 22.05.004 (and after manually installing `libmojolicious-plugin-openapi-perl` to get patron search to work - as per https://www.mail-archive.com/koha@lists.katipo.co.nz/msg28885.html) we are now seeing an issue uploading patron images. After logging in to Koha, the first attempt to upload an individual patron image (from the patron show screen) fails with a CSRF error: > The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again. Second and subsequent attempts succeed up until we log out and log back in again. After that the first submission once again fails. I tailed the logs to see if I could see any errors using `tail -f /var/log/koha/library/*.log`. On one occasion I saw an error related to `picture_upload.pl` in `/var/log/koha/library/intranet-error.log` but I can't reproduce it. In case it's relevant the error I saw once was: > [Wed Aug 31 09:55:06.665314 2022] [cgi:error] [pid 288501] [client 136.228.129.94:64313] AH01215: Use of uninitialized value $cardnumber in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/tools/picture-upload.pl line 66.: /usr/share/koha/intranet/cgi-bin/tools/picture-upload.pl, referer: https://<library url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=1790 The CSRF error in the client is reproducible in up-to-date versions of Chrome on Windows and Safari on macOS so it doesn't seem to be browser or OS specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 30694] New: Impossible to delete line in circulation and fine rules
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30694 Bug ID: 30694 Summary: Impossible to delete line in circulation and fine rules Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: klas.blomberg(a)skovde.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If you have entered a value in the column "Decreased loan period for high holds" for a circulation rule - you can't delete that line. The only thing that will happend is that all numerical values are wiped out - giving today as duedate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 20596] New: Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Bug ID: 20596 Summary: Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: marjorie.barry-vila(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org Created attachment 74361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74361&action=ed… authority to test Hi, We have a Zoom error when we apply a matching rule on a field (035) that appears twice in the authority record. ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F000001" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "44444"") from diag-set 'ZOOM' Test plan : - Add a record matching rule for field 035$a (index control-number) - upload a authority record file in tools/stage-marc-import.pl (attached file) - go to Manage staged MARC records and open authority file - apply matching rule for 035 - see error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 46

[Bug 31166] New: Digest option is not selectable for phone when PhoneNotification is enabled
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166 Bug ID: 31166 Summary: Digest option is not selectable for phone when PhoneNotification is enabled Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 28975] New: Holds queue lists can show holds from all libraries even with IndependentBranches
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 Bug ID: 28975 Summary: Holds queue lists can show holds from all libraries even with IndependentBranches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When using IndependentBranches, usually all branches are removed from the drop-down menus. But in the Holds Queue page, there is the possibility to choose "All branches". From there, you can see holds for patrons from other branches and even click on the names of the patrons to access their file and see their information (!!). To recreate : 1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers 2) Create a staff user with limited permissions (NOT a superlibrarian), including holds permissions. Here are mine as an example - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 3) Create (or make sure you already have) a patron in another branch (we'll call them patron X) 4) Place a hold for patron X on an available item from their own library 5) Run misc/cronjobs/holds/build_holds_queue.pl 6) Go to Circulation > Holds queue and make sure you can see the hold 7) Log in as your limited staff patron 8) Go to Circulation > Holds queue 9) In the drop-down menu, choose "All" and click Submit -- Patron X and their hold appear in the list 10) Click on patron X's name -- You can access patron X's file and see their information Superlibrarians should be able to select any library, but non-superlibrarians should only be able to select their own library from the drop-down menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 29458] New: Show login button consistently in relation to login instructions, reset and register links
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Bug ID: 29458 Summary: Show login button consistently in relation to login instructions, reset and register links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Modal form from masthead: Usercode Password Instructions Reset Register Login opac-auth (click Login from home page): Usercode Password Login Reset Instructions Register opac-main: Usercode Password Login Instructions Reset Register I would suggest to follow the pattern from the home page. After entering usercode and password, next step is normally click Login. Below that offer Instructions, Reset and Register. Do the same on modal and opac-auth. -- You are receiving this mail because: You are watching all bug changes.

1 36

[Bug 31086] New: Do not allow hold requests with no branchcode
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Bug ID: 31086 Summary: Do not allow hold requests with no branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Holds require a branchcode, various code expects this, however, we do not enforce this requirement when saving holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 47

[Bug 31196] New: Key "default_value_for_mod_marc-" cleared from cache but never set
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196 Bug ID: 31196 Summary: Key "default_value_for_mod_marc-" cleared from cache but never set Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We are seeing the following lines several times in the codebase $cache->clear_from_cache("default_value_for_mod_marc-"); But values are never set for this key. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 19693] New: authtypefrom incorrectly set when updating auth recs from file
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 Bug ID: 19693 Summary: authtypefrom incorrectly set when updating auth recs from file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: januszop(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org In those cases when authorities are updated by an external agency (or even internally, by reviewing and correcting an exported authority file) when the heading tag will be changed (seems odd but happens: 111 Congress ==> 110 Corporate body.Congress ; 100 Person ==> 110 Corporate body (a company named with person's name ; 151 City--object ==> 150 Object (city) etc.) and then the authority record in Koha database will be updated with bulkmarcimport or by calling directly ModAuthority from a custom script, the merge function "doesn't know" that the change to the authority type has been made and, consequently, doesn't adequately change the tag in related fields in biblio records (as it would if two different records with different authtypecode were merged with Koha interface). This is because at the moment when merge function is being called by ModAuthority Koha::Authority::Types->find($autfrom->authtypecode) Koha::Authority::Types->find($authto->authtypecode) both have the same value (because $autfrom == $autfrom). Therefore the authtype guessed from the old version of the record should be considered. To test: 1) have an authority record used in biblio; export it to file; change 1XX heading tag to different (but reasonable) value and possibly change also the content of the heading (one can delete also 942 but it doesn't matter); make bulkmarcimport.pl -a -update -file <modified_auth_file> and see that the tag in biblio record has not been changed (whereas the type of authority record did change); 2) make orders in database (so that the authority type and the tag of the field in biblio record correspond); apply the patch; 3) repeat the test from 1). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 18556] New: Message "Patron's address in doubt" is confusing
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '23

15 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Bug ID: 18556 Summary: Message "Patron's address in doubt" is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If a borrower has the patron account flag "Gone no address" set, the message "Patron's address in doubt" appears on the circulation check-out screen. This is confusing -- the borrowers table has the following fields that could be interpreted as an 'address' field: streetnumber streettype address address2 city state zipcode country B_streetnumber B_streettype B_address B_address2 B_city B_state B_zipcode B_country altcontactaddress1 altcontactaddress2 altcontactaddress3 altcontactstate altcontactzipcode altcontactcountry ... and it turns out that the message has *nothing* to do with any of these. I think that the message should read "Patron account flag 'Gone No Address' is set." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17