August 2022 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #438 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138596&action=e… Bug 15516: Add ability to create and view hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138578|0 |1 is obsolete| | --- Comment #437 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138595&action=e… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. The other holds will also be removed from the holds queue. 9. Confirm tests pass - t/db_dependent/Koha/Holds.t - t/db_dependent/Reserves/HoldGroup.t Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl - circ/view_holdsqueue.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138577|0 |1 is obsolete| | --- Comment #436 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138594&action=e… Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128288|0 |1 is obsolete| | Attachment #138576|0 |1 is obsolete| | Attachment #138579|0 |1 is obsolete| | Attachment #138580|0 |1 is obsolete| | Attachment #138581|0 |1 is obsolete| | Attachment #138582|0 |1 is obsolete| | Attachment #138583|0 |1 is obsolete| | Attachment #138584|0 |1 is obsolete| | Attachment #138585|0 |1 is obsolete| | Attachment #138586|0 |1 is obsolete| | Attachment #138587|0 |1 is obsolete| | Attachment #138588|0 |1 is obsolete| | Attachment #138589|0 |1 is obsolete| | --- Comment #435 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138593&action=e… Bug 15516: Database and installer updates Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #434 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Victor Grousset/tuxayo from comment #417) > Hi :) I tried to rebase because why not, but hit a wall on the changes on > ModReserveFill which was moved (and changed a lot) to Hold::fill(). I don't > know where is a right place to put the new code: > > # if this hold was part of a group, cancel other holds in the group > my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id > }); > foreach my $h ( @holds ) { > $h->cancel unless $h->reserve_id == $hold->reserve_id; > } > > > Also, maybe these lines are also needed in Hold::cancel() > Not sure at all. > > I would gladly give another try if someone know what to do about the two > above points. Have rebased the patches in case someone can come along and sign them off - but will now work on putting this code in the right place and squashing some of these patches. Welcome to test in the meantime. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128299|0 |1 is obsolete| | --- Comment #433 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138589&action=e… Bug 15516: (follow-up) Fix hold group details not showing Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128298|0 |1 is obsolete| | --- Comment #432 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138588&action=e… Bug 15516: (follow-up) Prevent cancelling unintended holds And a fix for consistent TT code Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128297|0 |1 is obsolete| | --- Comment #431 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138587&action=e… Bug 15516: Show user's hold groups to user via OPAC This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128296|0 |1 is obsolete| | --- Comment #430 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138586&action=e… Bug 15516: Add ability to create hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '22

04 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128295|0 |1 is obsolete| | --- Comment #429 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 138585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138585&action=e… Bug 15516: Fix hold groups for multi items for one bib Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0