August 2022 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #451 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #450) > __Staff interface detail__ > 1. Go to > http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=134 > 2. Search for patron "koha" > 3. Checkbox both items > 4. Checkbox "Treat as hold group" > 5. Click "Place hold" > *6. Note the following error: > Alert box appears saying "- Please select an item to place a hold" Failing at the moment as it appears to have broken item-specific holds (even without hold groups and multihold) on the staff interface. I've run out of time to keep working on this today, so leaving it here for now. I'll see if I can look at it again tomorrow. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #450 from David Cook <dcook(a)prosentient.com.au> --- My test plan: 0a) koha-upgrade-schema kohadev 0b) koha-plack --restart kohadev __OPAC results__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search… 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Checkbox "Treat as hold group (next available item fulfills all holds)" 5. Click "Confirm hold" 6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 7. Click "Holds" 8. Confirm the two holds appear with the text "part of a hold group", and when you click on that text it shows you both hold group titles 9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group count as 1 hold total 10. In the staff interface, check in "39999000001310" 11. Click "Confirm hold (Y)" 12. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 13. Note only 1 hold appears, and when you click on "part of a hold group" it only shows 1 hold title 12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl 13. Note that only 1 hold appears now 14. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 15. Cancel the hold __Staff interface results__ 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Search for patron "koha" 5. Checkibox "Treat as hold group" 6. Choose "Centerville" as "Pickup at" 7. Click "Place holds" 8. Click on "part of a hold group" on the each hold and note the modal with "Hold group" appears showing the 2 titles 9. Check in "39999000001310" 10. Click "Confirm hold (Y)" 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Cancel the hold __OPAC detail__ NOTE: This is irrelevant without https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 so 15565 can focus on implementing it. __Staff interface detail__ 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=134 2. Search for patron "koha" 3. Checkbox both items 4. Checkbox "Treat as hold group" 5. Click "Place hold" *6. Note the following error: Alert box appears saying "- Please select an item to place a hold" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #449 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 138772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138772&action=e… Bug 15516: [QA followup] Only show hold groups for multi hold in OPAC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31303 [Bug 31303] Fatal error when viewing OPAC user account with waiting holds -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #448 from David Cook <dcook(a)prosentient.com.au> --- Ok I'm pretty sure the fatal error is a bug in master. I'm going to leave this as Failed QA for the moment just because we can't really progress it until the bug in master is fixed... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15565 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple item-level holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #447 from David Cook <dcook(a)prosentient.com.au> --- Hmm this might be due to bug 22456 and it might be my fault... I'm going to try pulling the latest Docker image and see if that makes a difference... but might be a problem in master caused by bug 22456... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #446 from David Cook <dcook(a)prosentient.com.au> --- I am keen to get this functionality into Koha, so I don't know that I'd consider many of my above asterisk comments above blockers per se, but I had to fail it for the fatal error at http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-holds: Template process failed: undef error - Can't call method "rule_value" on an undefined value at /kohadevbox/koha/Koha/Hold.pm line 464. at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes.

1 0