August 2022 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #445 from David Cook <dcook(a)prosentient.com.au> --- My test plan: 0a) koha-upgrade-schema kohadev 0b) perl misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml #NOTE: this step seemed unnecessary 0c) koha-plack --restart kohadev __OPAC results__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search… 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Checkbox "Treat as hold group (next available item fulfills all holds)" 5. Click "Confirm hold" 6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 7. Click "Holds" 8. Confirm the two holds appear with the text "part of a hold group", and when you click on that text it shows you both hold group titles 9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group count as 1 hold total 10. In the staff interface, check in "39999000001310" 11. Click "Confirm hold (Y)" 12. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 13. Note only 1 hold appears, and when you click on "part of a hold group" it only shows 1 hold title 12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl *13. Note the following error: Template process failed: undef error - Can't call method "rule_value" on an undefined value at /kohadevbox/koha/Koha/Hold.pm line 464. at /kohadevbox/koha/C4/Templates.pm line 127 14. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 15. Cancel the hold __OPAC detail__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=134 2. Checkbox "Treat as hold group (next available item fulfills all holds)" 3. Click "Show more options" 4. Click "A specific item" *5. Note that without https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 you can't select multiple items, so it doesn't make much sense to show "Treat as hold group" on this page... __Staff interface results__ 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Search for patron "koha" 5. Checkibox "Treat as hold group" 6. Choose "Centerville" as "Pickup at" 7. Click "Place holds" 8. Click on "part of a hold group" on the each hold and note the modal with "Hold group" appears showing the 2 titles 9. Check in "39999000001310" 10. Click "Confirm hold (Y)" 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Cancel the hold __Staff interface detail__ 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=134 2. Search for patron "koha" 3. Checkbox both items 4. Checkbox "Treat as hold group" 5. Click "Place hold" *6. Note the following error: Alert box appears saying "- Please select an item to place a hold" *7. In theory, one should be able to place holds on multiple items, but I think in practice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 is needed to make that happen, so it might not make sense to show "Treat as hold group" on this page at this time -- On http://localhost:8080/cgi-bin/koha/opac-main.pl it will say "2 holds pending", but when you click on that link it will show "Holds (1)" and then "Holds (2 total)". I think that this is likely to confuse users... while I know libraries want hold groups to count as 1 hold, I'm not sure that Koha can really handle that in a coherent way... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- CC| |dcook(a)prosentient.com.au Assignee|koha-bugs(a)lists.koha-commun |dcook(a)prosentient.com.au |ity.org | --- Comment #8 from David Cook <dcook(a)prosentient.com.au> --- We might want to show the "Item type" options the same way we show the library branches or the item types on http://localhost:8081/cgi-bin/koha/catalogue/search.pl I'm going to deploy the current version locally, but open to alternatives for the Bugzilla patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 --- Comment #7 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 138765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138765&action=e… Bug 6936: Allow multiple itemtypes for bib record export This patch allows multiple item types to be chosen when exporting bib records from the Tools module. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 2. Select "All" for "Item type" and note 435 bibs are exported 3. Select "Books" and note 360 bibs are exported 4. Select "Books" and "Visual Materials" and note 380 bibs are exported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6936] Allow to limit on multiple itemtypes when exporting bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '22

08 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6936 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '22

07 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '22

06 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #444 from Michal Denar <black23(a)gmail.com> --- Created attachment 138742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138742&action=e… Bug 15516: Schema updates Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '22

06 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #443 from Michal Denar <black23(a)gmail.com> --- Created attachment 138741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138741&action=e… Bug 15516: Add ability to create and view hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '22

06 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #442 from Michal Denar <black23(a)gmail.com> --- Created attachment 138740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138740&action=e… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. The other holds will also be removed from the holds queue. 9. Confirm tests pass - t/db_dependent/Koha/Holds.t - t/db_dependent/Reserves/HoldGroup.t Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl - circ/view_holdsqueue.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '22

06 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #441 from Michal Denar <black23(a)gmail.com> --- Created attachment 138739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138739&action=e… Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '22

06 Aug '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138593|0 |1 is obsolete| | Attachment #138594|0 |1 is obsolete| | Attachment #138595|0 |1 is obsolete| | Attachment #138596|0 |1 is obsolete| | Attachment #138597|0 |1 is obsolete| | --- Comment #440 from Michal Denar <black23(a)gmail.com> --- Created attachment 138738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138738&action=e… Bug 15516: Database and installer updates Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0