September 2022 - Koha-bugs - lists.koha-community.org

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Michaela Sieber <michaela.sieber(a)kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from Michaela Sieber <michaela.sieber(a)kit.edu> --- (In reply to Julian Maurice from comment #36) > Patch rebased on master Hey Julian, I'm very sorry, I tried to test it in the ByWater Sandbox and always get an error message "The field could not be inserted. Perhaps the name already exists?" when trying to create an new field. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #36 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75332|0 |1 is obsolete| | --- Comment #35 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 141116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141116&action=e… Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer(a)nyls.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #82 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 141103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141103&action=e… Bug 10950: (follow-up) Change display of pronoun fields Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #81 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 141102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141102&action=e… Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form definded => defined Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #80 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 141101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141101&action=e… Bug 10950: (QA follow-up) Exec Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #79 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 141100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141100&action=e… Bug 10950: (follow-up) fix typo in kohastructure.sql Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #78 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 141099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141099&action=e… Bug 10950: API spec update Test plan: 1. Apply patch, restart_all, and updatedatabase 2. In the staff client go to a patron record or create a new patron. 3. Notice the pronouns field, make sure you add a value to it. 4. Now notice that the value should display in parentheses in places where the patron name is displayed. 5. Go to the details page and you should see the value display in quotes. ( next to othernames ) 6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField. 7. Check to make sure you can make the field required with BorrowerMandatoryField 8. Go to the OPAC to self register. The pronouns field should appear in the form. 9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ). 10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ). 11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '22

30 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #77 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 141098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141098&action=e… Bug 10950: Display pronouns field Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Andrew Fuerste-Henry <andrewfh(a)dubcolib.org> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0