January 2023 - Koha-bugs - lists.koha-community.org

[Bug 31818] New: Advanced editor doesn't show keyboard shortcuts
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '23

28 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Bug ID: 31818 Summary: Advanced editor doesn't show keyboard shortcuts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When using the advanced cataloguing editor, the modal showing the defined keyboard shortcuts no longer works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 31740] New: Illrequests table has a foreign key constraint on status_alias
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31740 Bug ID: 31740 Summary: Illrequests table has a foreign key constraint on status_alias Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I am not sure the intent of this foreign key, however it seems problematic as we can't tie it to a single category To test: 1 - Add an authorised value for Asort1: Authorised value: MONKEY Description: Capuchin 2 - Add an authroised value for LOC: Authorised value: MONKEY Description: Spider 3 - Put an illrequest in the DB: INSERT INTO illrequests (branchcode,status,status_alias) VALUES ('CPL','REQUEST_TEST','MONKEY') 4 - Delete one of the authorised values above 5 - Check the DB: SELECT status_alias FROM illrequests WHERE status = 'REQUEST_TEST' 6 - Note the status is nulled by deletion of unrelated authroised value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 32130] New: Vue files must be kept tidy
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Bug ID: 32130 Summary: Vue files must be kept tidy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Keywords: rel_22_11_candidate Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 32030 We want to keep them tidy, and all use the them rules. To enforce that we should have a test in xt to catch possible discrepancies. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 32519] New: In Elasticsearch mappings table add search field name
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32519 Bug ID: 32519 Summary: In Elasticsearch mappings table add search field name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com In Elasticsearch mappings table, in tabs for mappings we should add search field name in addition to label ; in order to find them when searching using DataTable search field. This is very useful when debugging. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 29607] New: addorderiso2709: The stored discount when importing an order from a file is invalid
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Bug ID: 29607 Summary: addorderiso2709: The stored discount when importing an order from a file is invalid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: christophe.torin(a)univ-rennes2.fr QA Contact: testopia(a)bugs.koha-community.org In the Acquisitions module : - Create a new vendor with a discount (Or select one that has a discount). Here the discount will be 25% - Create a new basket or select an existing one - Select "Add to basket" => From a staged file - Add an order from one of the file ==> Here, you can use a specific discount for the order, to override the vendor discount. The result should be quite the same if you do, but with this discount - The order is created ==> Modify the order - The discount is 0.25% instead of 25% Note that the prices are initially correctly calculated, but the discount value will appear as false. Plus, if you modify the order and change a price, the wrong discount will be used. In database, the discount is indeed stored as a value between 0 and 1, but only in that case (for the vendor, it is the actual percentage, and when you create an order from anoher source, it is stored correctly) This was reported on Koha 20.11, but is still relevant on master. In the code, this happens because the discount value is first divided by 100 to calculate the price, but it is that divided value that is stored in database, instead of the whole percentage value. On the master branch, in the file Koha/acqui/addorderiso2709.pl, the line where it's done are lines 166, 279 and 340 What I would suggest is : - Remove the division per 100 on those lines (166, 279 and 340) - Divide per 100 only when calculating the price (lines 283, 285, 344, 346) ==> ( 1 - $c/100 ) instead of ( 1 - $c ) - In the template (for importing from file), add a "%" just to be clear that the discount is a percentage, and not a value between 0 and 1 I know there was a kind of security (divide by 100 if the input is > 1), but it could be the other way around (multiply by 100 if the input is < 1). But as it is based on the field that is in the form, with a simple "%" indication it should not be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 32492] New: Improve mark-up of OPAC messaging table to ease customization
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32492 Bug ID: 32492 Summary: Improve mark-up of OPAC messaging table to ease customization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When looking at the messaging preferences table in the OPAC, it's really hard to customize. You can only use the row index or the translated descriptions when trying to select the correct line to add things to or when you want to hide unused messages. It would be great if we could add classes with the code for each notice/message, so this is easier. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 32679] New: CSS class article-request-title is doubled up in article requests list in OPAC patron account
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 Bug ID: 32679 Summary: CSS class article-request-title is doubled up in article requests list in OPAC patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The CSS class article-request-title is used for the title of the host and also for the column with the article title. So if you are not careful, things will get mixed up. The classes for 2 different things should be differently named. * Activate article requests in system preferences * Make sure article requests are allowed in circulation conditions * Make an article request for a record in the OPAC * Check the display in the patron account for the article request -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 24310] New: Use Text::Lorem instead of String::Random in Test::Builder
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24310 Bug ID: 24310 Summary: Use Text::Lorem instead of String::Random in Test::Builder Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org That would help to get something more readable. Currently we generate a string of one word that is the size of the column. It produces a lot of overflow when displayed on the screen. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 32678] New: Add new line in authorized values tests in search_for_data_inconsistencies.pl
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32678 Bug ID: 32678 Summary: Add new line in authorized values tests in search_for_data_inconsistencies.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} It would be more clear with new lines, especially for scripts (grep, awk ...) : * The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }): {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV} -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 31471] New: Duplicate check in cataloguing doesn't work with Elasticsearch
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '23

27 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31471 Bug ID: 31471 Summary: Duplicate check in cataloguing doesn't work with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de CC: michaela.sieber(a)kit.edu The duplicate check in cataloguing doesn't work with Elasticsearch. To test: * With Zebra: Download a record via Z39.50 and save. * Make sure the record is found in the catalog. * Download the same record via Z39.50 again and try to save - duplicate confirm message pops up. * Switch to Zebra * Again, make sure that the record can be found in the catalog. * Download the record again via Z39.50 and try to save - no duplicate warning, the record is saved. If an example is needed we could provide a taget and sample. Note: As I understand FindDuplicate it checks for ISSN and after that a combination of title and author. Is there a thing we might be missing here? Tested in different installations with master and 21.11. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18