October 2023 - Koha-bugs - lists.koha-community.org

[Bug 35105] New: ILL - Saving 'Edit request' form with invalid Patron ID explodes
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '23

29 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35105 Bug ID: 35105 Summary: ILL - Saving 'Edit request' form with invalid Patron ID explodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: pedro.amorim(a)ptfs-europe.com CC: pedro.amorim(a)ptfs-europe.com Depends on: 35094 To reproduce, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.…) 2) Visit /cgi-bin/koha/ill/ill-requests.pl 3) Create 'New ILL request' 4) Select the request type, input cardnumber '42' and select a library 5) Hit 'Create' 6) Manage the request created just now: click the request id or 'manage request' button from the table 7) Click "Edit request" from the top actions toolbar 8a) Input text in Patron ID e.g. 'asdasdasf'. Notice you get redirected to the table - that doesn't render - with an error. 8b) Input a patron id that doesn't exist e.g. '987654'. Notice you get an error upon saving "FK Constraint error" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35094 [Bug 35094] ILL new request is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 33211] New: Fix failing test for basic_workflow.t when adding item
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '23

29 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33211 Bug ID: 33211 Summary: Fix failing test for basic_workflow.t when adding item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It seems something changed and the selector is no longer findable STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 1840):1 in Selenium::Remote::Driver::__ANON__ (eval 1842):2 in Selenium::Remote::Driver::__ANON__ /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) t/db_dependent/selenium/basic_workflow.t:207 in Selenium::Remote::Driver::find_element Error while executing command: no such element: Unable to locate element: //div[@id="subfield952w"]/input[@class="input_marceditor flatpickr-input"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 255 just after 6. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/22 subtests Test Summary Report ------------------- t/db_dependent/selenium/basic_workflow.t (Wstat: 65280 Tests: 6 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 22 tests but ran 6. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 24319] New: When RenewSerialAddsSuggestion is used, use existing record when ordering from suggestion
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24319 Bug ID: 24319 Summary: When RenewSerialAddsSuggestion is used, use existing record when ordering from suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When renewing a serial subscription a suggestion in the acquisition module can be automatically created using the RenewSerialAddsSuggestion system preference. While the biblionumber can be stored, this will create a new record on 'ordering from a suggestoin' later on. It would be much better, if we attached the order to the existing record instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 24318] New: When RenewSerialAddsSuggestion is used, treat suggestion as "order from subscription"
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24318 Bug ID: 24318 Summary: When RenewSerialAddsSuggestion is used, treat suggestion as "order from subscription" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org At the moment, you can add add a suggestion on renewing a subscription, using the RenewSerialAddsSuggestion system preference. The suggestion is disconnected from the subscription, as we don't store the subscription id. When the suggestion is accepted, a new record is created and there is no connection to the existing one. We should store the subscriptionid and treat the order as a 'order from subscription', which will give it all the features available for subscription ordering at the moment and form a good connection between the serials and acq modules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 33477] New: POST /holds/ allows invalid item-level hold if biblio_id and item_id are both specified
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33477 Bug ID: 33477 Summary: POST /holds/ allows invalid item-level hold if biblio_id and item_id are both specified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov CC: tomascohen(a)gmail.com To reproduce: 1. Locate or create a bib with multiple items 2. Set one item to type "Reference" and the rest to type "Book" 3. Go to the Circulation and Fines Rules > "Default holds policy by item type" section, and add a line specifying No Holds Allowed for Reference item type 4. Attempt to place an item-level hold on the Reference-type item via the REST API, specifying only the parameters: patron_id, item_id, and pickup_library_id 5. Confirm expected error message: Hold cannot be placed. Reason: notReservable 6. Attempt to place an item-level hold on the Reference-type item via the REST API, specifying only the parameters: patron_id, item_id, biblio_id, and pickup_library_id 7. Observe that an item-level hold has been placed on the Reference-type item, even though it should not be holdable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 35053] New: When placing a hold via the REST API if both biblio_id and item_id are passed the hold is placed on the item, but rules checked for the record
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35053 Bug ID: 35053 Summary: When placing a hold via the REST API if both biblio_id and item_id are passed the hold is placed on the item, but rules checked for the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com CC: tomascohen(a)gmail.com In the checks we have: if ( $item_id and $biblio_id ) { .... $biblio = Koha::Biblios->find($biblio_id); ... } $item does not get assigned, then later: my $can_place_hold = $item ? C4::Reserves::CanItemBeReserved( $patron, $item ) : C4::Reserves::CanBookBeReserved( $patron_id, $biblio_id ); So while the item may not be holdable, we check if the bib is, then place the hold using the item_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 24092] New: Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Bug ID: 24092 Summary: Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: agustinmoyano(a)theke.io QA Contact: testopia(a)bugs.koha-community.org Koha::Item uses my $items_last_returned_by_rs = Koha::Database->new()->schema()->resultset('ItemsLastBorrower'); to retrieve item's last borrower. It should use Items::LastPatrons class introduced in bug 23260 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 31014] New: Minor UI problems in QOTD editor tool
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31014 Bug ID: 31014 Summary: Minor UI problems in QOTD editor tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org These problems were reported in Bug 30903 but were deemed too minor to be in that bug, so I was told to make a new report for these. Original test plan from Bug 30903 1- Download the attached csv or create a comma-separated csv with two columns, one for source and one for text (no headers) 2- Go to Tools > Edit quotes for QOTD feature 3- Click on Import quotes --> Note that the layout of the page is a bit strange... there is a big space between the title of the page and the first content box, and there is no space above the browse button 4- Click browse and choose the CSV file --> The quotes should be imported in an editable table, you can click on either the source or text of a quote to change it (on my browser the editable field is really small, I wonder if it's the page or my browser (Firefox) or my OS (Ubuntu)) 5- Click Save quotes Points to correct - At step 3, the browse button is still weirdly placed, at the top of the box - At step 4, the editable fields are very small (like there is no padding around the text?) -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 34716] New: Typo in tools/stockrotation.tt
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34716 Bug ID: 34716 Summary: Typo in tools/stockrotation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: matt.blenkinsop(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org "Are you sure you wish to remove this item from it's rota" - the "it's" is wrong here and should be "its" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 34942] New: Typo: brower
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '23

28 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34942 Bug ID: 34942 Summary: Typo: brower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org $ grep -rn --exclude=*.po brower * koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc:873: if( !confirm( _("This will retrieve macros stored in the brower, save them in the database, and delete them from the browser. Proceed?") ) ){ koha-tmpl/intranet-tmpl/prog/nb-NO/includes/cateditor-ui.inc:873: if( !confirm( _("This will retrieve macros stored in the brower, save them in the database, and delete them from the browser. Proceed?") ) ){ -- You are receiving this mail because: You are watching all bug changes.

1 18