October 2023 - Koha-bugs - lists.koha-community.org

[Bug 34768] New: Can't pay fines on OPAC if patron has a guarantee and they can see their fines
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34768 Bug ID: 34768 Summary: Can't pay fines on OPAC if patron has a guarantee and they can see their fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This requires having an OPAC payment system setup, but it doesn't need to be functional for testing To recreate: 1 - Set system preference: AllowStaffToSetFinesVisibilityForGuarantor to allow 2 - Find a patron 3 - Add some fines to their account 4 - Install and enable an opac payment plugin (https://github.com/bywatersolutions/koha-plugin-pay-via-govolution for example) 5 - Sign in to OPAC as borrower 6 - Go to 'Charges' tab 7 - Select a fee 8 - Confirm 'Make payment' button enabled and 'amount to pay' is updated 9 - Add a guarantee to patron in staff interface 10 - Set 'Show charges to guarantors' to 'Yes' 11 - Add and pay a fine for the child 12 - View guarantor account on the OPAC 13 - Confirm you now see child's charges 14 - Confirm selecting your own fees does not enable the button or update amount to pay -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 34767] New: SIP2 fee acknowledgement flag on renewals is passed, but not used
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34767 Bug ID: 34767 Summary: SIP2 fee acknowledgement flag on renewals is passed, but not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: david(a)davidnind.com, koha-bugs(a)lists.koha-community.org, nick(a)bywatersolutions.com, testopia(a)bugs.koha-community.org C4/SIP/ILS.pm 436 sub renew { 437 my ($self, $patron_id, $patron_pwd, $item_id, $title_id, 438 $no_block, $nb_due_date, $third_party, 439 $item_props, $fee_ack) = @_; The $fee_ack variable is lost in the transition to C4::SIP::ILS::Transaction::Renew.. we need to clone it across as we do for the checkout message transaction. This is important, as without passing this on, one cannot renew items where charges apply. To test: 1) Add a rental charge to an itemtype 2) Checkout an item of that itemtype to a user 3) Attempt a renewal of that item via SIP2 and note that it fails 4) Pass the fee_acknowledgement bit in renewal and note the renewal still fails. This can be achieved using the sip_cli_emulator (after applying bug 34764 to fix it's mishandling of passing the fee_ack bit) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.

1 18

[Bug 34764] New: sip_cli_emulator -fa/--fee_acknowledge does not act as expected
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Bug ID: 34764 Summary: sip_cli_emulator -fa/--fee_acknowledge does not act as expected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz The sip_cli_emulator documents a `fee_acknoledge`/`fa` option. In the code it's treated as a boolean in some places and a string in others which results in incorrect messages being generated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 34743] New: Incorrect POD in import_patrons.pl
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34743 Bug ID: 34743 Summary: Incorrect POD in import_patrons.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: matt.blenkinsop(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com There is a duplicated description in import_patrons.pl that causes confusion over what the flags are for -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 34656] New: CartToShelf should not trigger RealTimeHoldsQueue
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Bug ID: 34656 Summary: CartToShelf should not trigger RealTimeHoldsQueue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The routine only changes the location of the item, this does not affect holdability and does not need to update the queue. This is causing issues when the cron is adding background jobs and is followed by the holds queue builder and the two processes can end up running the queue for a bib at the same time and causing clashes in the tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 34532] New: Silence warns in Patroncard.pm when layout values are empty
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 Bug ID: 34532 Summary: Silence warns in Patroncard.pm when layout values are empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1. Go to patron card creator and make a patron card batch, card layout, and card template. 2. In the card layout leave some values blank for Lower left X coordinate and Lower left Y coordinate. 3. Now go create a card batch while tailing the plack-intranet-error log/ 4. Notice in the logs: [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 109. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 248. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 249. The more patrons in a given batch the more of these errors you will see. If no llx or lly value is given we should assume it is 0. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 34589] New: Update on bug 20256 is not idempotent
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34589 Bug ID: 34589 Summary: Update on bug 20256 is not idempotent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The last commit attempted to make the update idempotent, however, it missed a case. If the update is run, then a patron has the permission removed, they will get it again on a subsequent update. We should check if the permission exists in the permissions table, and only perform the first two updates if it does not -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 34736] New: Item checkboxes are lost in multi-receive, breaking partial receive
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Bug ID: 34736 Summary: Item checkboxes are lost in multi-receive, breaking partial receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: michaela.sieber(a)kit.edu, nick(a)bywatersolutions.com, tomascohen(a)gmail.com If multiple items were ordered and only a part of those are received, the order line is split into 2, received and pending. When you work with multi-receive and switch back and forth between entries, things get confused and you end up with a broken partial receive where the received items have not been re-linked to the new order line. This might also have other bad side effects. Sorry for the somewhat complicated test plan: To test: * Create a new basket, create items on placing the order * Create an order line with 4 items * Create another order line with 2 items * Close the basket * Receive shipment and create an invoice * Select both orders via the checkboxes got multi-receive * Click "receive selected" * Edit first order line, quantity received = 1 (1 out of 4) * Verify that one item is also selected in the table * Switch to "next order" * Quantity received is 0, no items checked in the second order * Switch to "Previous order" * ERROR: Item checkbox was lost, quantity received still correct * Switch to next order * ERROR: item is now checked, quantity received 0 * Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. * Save changes * Click confirm * Continue (complaint about the second order left unchanged) You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct * Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 35031] New: Improve translations of strings in serial collection template
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35031 Bug ID: 35031 Summary: Improve translations of strings in serial collection template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr I propose to add internationalization functions to several strings in serials-collection.tt in order to make the translation process easier. This change would improve parts of po file like this: #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:268 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt:43 #, c-format msgid "%s %sSpring%s %s %sSummer%s %s %sFall%s %s %sWinter%s %s %sSpr%s %s %sSum%s %s %sFal%s %s %sWin%s %s %s %s " msgstr "%s %sPrintemps%s %s %sÉté%s %s %sAutomne%s %s %sHiver%s %s %sPrtps%s %s %sÉté%s %s %sAut%s %s %sHiv%s %s %s %s" -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 35039] New: Hahahha
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35039 Bug ID: 35039 Summary: Hahahha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: martin.renvoize(a)ptfs-europe.com Reporter: kotoribotz(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, oleonard(a)myacpl.org Created attachment 156896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156896&action=e… Hahaha -- You are receiving this mail because: You are watching all bug changes.

1 2