December 2023 - Koha-bugs - lists.koha-community.org

[Bug 35611] New: Never use "ON UPDATE SET NULL"
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35611 Bug ID: 35611 Summary: Never use "ON UPDATE SET NULL" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, nick(a)bywatersolutions.com, tomascohen(a)gmail.com Why are we using "ON UPDATE SET NULL" in kohastructure.sql exactly? IMO it should be replaced with "ON UPDATE CASCADE", everywhere. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #134 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 160106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160106&action=e… Bug 12802: Clarify system preferences I felt the switch to multi in the EmailFieldPrimary preference was a bit confusing given that type exposes a 'select all' option which doesn't make sense with the pre-existing 'first valid' option being an override in the code. This patch opts to switch it back to 'Choice', meaning that only one option can be picked and adds a 'selected addresses' option which prompts the use of a new 'EmailFieldSelection' preference which allows for the multi-select as before. To test: 1) Run though the test plan for 'Update notice_email_address method to return a list' but with the following ammendments: * 2) As aposed to being able to select multiple options under EmailFieldPrimary, you should now only be able to select one option at a time, but a new 'selected addresses' option should be present. * 8) Select the 'selected addresses' option for 'EmailFieldPrimary' and also select multiple fields for the new 'EmailFieldSelection' preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160092|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 160105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160105&action=e… Bug 12802: Add note to EmailFieldPrimary system preference To clarify that "first valid" should be unchecked for multiple emails to receive notices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160091|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 160104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160104&action=e… Bug 12802: Update notice_email_address method to return a list This patch updates the notice_email_address method to return a comma separated list of addresses as expected by Email::Sender if you wish to send mail to multiple To addresses. To test: 1. Install database update and restart services 2. Go to Koha Administration -> system preferences. Search for EmailFieldPrimary. Confirm the options show as checkboxes and you can select multiple. 3. Search for a patron. Put different email addresses in each of the possible email fields (i.e. primary email, secondary email, alternate email). 4. Make sure 'first valid' is checked in EmailFieldPrimary. 5. Go to your patron, click the More dropdown and send a welcome email. 6. In your terminal, go into the database to view the message queue. sudo koha-mysql instance select * from message_queue\G 7. Confirm your welcome email is visible, with ONLY the first valid email in the to_address field. 8. Select other combinations of emails in EmailFieldPrimary. 9. Send another welcome email to the same patron, then run the message_queue SQL query again. 10. Confirm your welcome email is visible and shows all selected addresses concatenated by , in the to_address field. 11. Enable KTD to send email [1] (without email configured you will not be able to confirm the delivery to multiple addresses). 12. Run misc/cronjobs/process_message_queue.pl to trigger sending the queued notices from above. 13. Check that the addresses in the to_address all actually recieve the notice. [1] To test sending emails using a Google account: - Set up an App password for your Google Account - Configure a new 'SMTP Server' under 'Administration > SMTP servers' using the following settings where `User name` = your Google email address and `Password` = your APP password, not your Google account password): Host: smtp.gmail.com Port: 587 Timeout: 120 SSL: STARTTLS User name: GOOGLEACCOUNTUSER Password: GOOGLEAPPPASSWORD - Set this server as default Sponsored-by: St Luke's Grammar School & Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160090|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 160103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160103&action=e… Bug 12802: Update system preference Allow the EmailFieldPrimary preference to accept multiple selections -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35609] New: Ability to add tags to records via the staff interface
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35609 Bug ID: 35609 Summary: Ability to add tags to records via the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl TagsEnabled only adds tagging functionality to the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 4134] Add bibliographic tagging to staff interface
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4134 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha(a)catalyst.net.nz --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- *** Bug 35609 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5334] Omnibus: Add explicit foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35610 [Bug 35610] Missing FK on old_reserves.branchcode? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '23

20 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #130 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Thanks for testing, and adding the proper test plan in, Aleisha. I'm glad you like the alternative approach. -- You are receiving this mail because: You are watching all bug changes.

1 0