December 2023 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '23

15 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159780|0 |1 is obsolete| | --- Comment #120 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 159857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159857&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the EmailFieldPrimary syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the EmailFieldPrimary pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The EmailFieldPrimary was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref EmailFieldPrimary" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref EmailFieldPrimary (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of EmailFieldPrimary. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of EmailFieldPrimary; not sure if this is a bug or not. Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35577] New: Self-registration creates empty patron attributes
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35577 Bug ID: 35577 Summary: Self-registration creates empty patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: david.roberts(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When creating a new users using the self-registration feature, all extended patron attributes are created as empty lines in the database even if they are not completed in the form: select * from borrower_attributes where borrowernumber = 265932; +--------+----------------+-----------+-----------+ | id | borrowernumber | code | attribute | +--------+----------------+-----------+-----------+ | 408566 | 265932 | JOBROLE | Test | | 408567 | 265932 | ESRCAT | | | 408568 | 265932 | NOTIF | | | 408569 | 265932 | CONTRACT | | | 408570 | 265932 | STUDY | | | 408571 | 265932 | CONT_TYPE | | | 408572 | 265932 | TRUST_OTH | | | 408573 | 265932 | TRUST | | +--------+----------------+-----------+----- Editing this user record in the staff client then deletes the empty attributes: select * from borrower_attributes where borrowernumber = 265932; +--------+----------------+-----------+-----------+ | id | borrowernumber | code | attribute | +--------+----------------+-----------+-----------+ | 408574 | 265932 | CONT_TYPE | TEMP | | 408575 | 265932 | JOBROLE | Test | +--------+----------------+-----------+-----------+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 25965] New: Create SIP2 client daemon with HTTPS API endpoint
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 Bug ID: 25965 Summary: Create SIP2 client daemon with HTTPS API endpoint Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: lmstrand(a)gmail.com I am trying to pass messages to a sip server using a new endpoint I created in swagger/openApi. This endpoint uses the guidelines described here: http://biblstandard.dk/rfid/dk/rfid_sip2_over_https.htm The idea is to get rid of the tunneling/VPN implementations that we use, and use HTTPS instead to pass sip messages back and forth inside an XML. The Apache server handles the HTTPS stuff so I don't have had to worry about that so far when communicating with the REST api, hence the SipOHttp naming in my module. At the moment I can send the XML POST messages formed like in the linked guideline to the endpoint (XML wrapped SIP2 message to .../api/v1/sipmessages/). The api forwards the body content of the request to my module Koha::REST::V1::SipOHttp. The module validates and parses the contents of the XML message, extracts the information about the sip server the message is intended to (using the "login:" parameter inside the XML) and the sip message itself (inside the <request></request> variable). Then the module passes the sip message on to the sip server using IO:Socket::INET. My problem is that the sip server closes the connection after this first SC device login message has been passed and the response has been read back in my module: (from sip2.log) ..... [INFO] [undef](a)10.0.3.217: OUTPUT MSG: '941' C4::SIP::Sip::write_msg /home/koha/Koha/C4/SIP/Sip.pm (187) [DEBUG] SIPDEVICE(a)10.0.3.217: raw_transport: uname/inst: 'SIPDEVICE/SIPDEVICE' C4::SIP::SIPServer::raw_transport /home/koha/Koha/C4/SIP/SIPServer.pm (174) [DEBUG] SIPDEVICE(a)10.0.3.217: EOF returned on read C4::SIP::SIPServer::read_request /home/koha/Koha/C4/SIP/SIPServer.pm (349) [INFO] SIPDEVICE(a)10.0.3.217: raw_transport: shutting down C4::SIP::SIPServer::raw_transport /home/koha/Koha/C4/SIP/SIPServer.pm (178) So I need a way to keep this socket connection open for other future messages. Without touching the sip server's code itself, the only solution I can come up with is a proxy server that handles and passes on the REST api's incoming messages to sockets and keeps each invidual socket connection open to specific instances of the sip servers (I suppose the sip server itself ends the connections when needed so you wouldn't have to worry about it in the sender's end). Another solution would be to build a new api separate from the swagger/Openapi one. Like an all-in-one solution that deals with the requests and keeps tabs on the open socket connections. Let me know if you have ideas regarding this. Ps. I'm a trainee in Koha Suomi (Finland) so excuse me if the description of my problem is a bit vague and lacks some correct terms used. I'm happy to fill in any details I've left out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 46

[Bug 23303] New: When uninstalling a plugin we don't call any form of 'unload'
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23303 Bug ID: 23303 Summary: When uninstalling a plugin we don't call any form of 'unload' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We currently clean up the filesystem and run through the 'uninstall' method from the plugin in point during the uninstall process. We don't however, ever, unload the module code from memory and this may result in plack environments leaking memory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 35059] New: Display item location on item details (catalogue/moredetail.pl)
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35059 Bug ID: 35059 Summary: Display item location on item details (catalogue/moredetail.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: michaela.sieber(a)kit.edu QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We miss the location on the item details page (catalogue/moredetail.pl) item type, collection, callnumber and copynumber are displayed but the location is missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 35450] New: Punctuation: Preservation system preferences should end with a .
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Bug ID: 35450 Summary: Punctuation: Preservation system preferences should end with a . Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org I noticed that the new preservation system preferences are missing the ending . at the end of the sentences. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 35449] New: Accessibliity: No links on "here"
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Bug ID: 35449 Summary: Accessibliity: No links on "here" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org We have some "here" links that slipped into system preference descriptions: Example: UpdateItemLocationOnCheckin <br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 35436] New: Copy is not translatable in OPAC Search History
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Bug ID: 35436 Summary: Copy is not translatable in OPAC Search History Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: adolfo.rodriguez(a)xercode.es QA Contact: testopia(a)bugs.koha-community.org Created attachment 159349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159349&action=e… OPAC Search History Capture Copy in the table of OPAC Search History isn't translatable. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 35344] New: Patron image upload does not warn about missing cardnumber
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 Bug ID: 35344 Summary: Patron image upload does not warn about missing cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com As noted in bug 34018, the ./tools/picture-upload.pl silently fails if a patron doesn't have a cardnumber. It would be better to use the borrowernumber, but that would require rewriting the whole script, which seems like a lot of work for little gain. Instead, we'll add a warning / prevent upload if the patron doesn't have a cardnumber. That way the staff user can at least know they should add a cardnumber if they want to upload a patron image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 35425] New: Sortable prevents mouse selection of text inside child input/textarea elements
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '23

14 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Bug ID: 35425 Summary: Sortable prevents mouse selection of text inside child input/textarea elements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: slavashishkin(a)gmail.com Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Depends on: 35383 To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work -- You are receiving this mail because: You are watching all bug changes.

1 15