February 2023 - Koha-bugs - lists.koha-community.org

[Bug 32603] New: Suggester category in Suggestions management
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Bug ID: 32603 Summary: Suggester category in Suggestions management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org In Suggestions management, it would be intersting to know the suggester category. This way, it would be possible for example for the librarian managing suggestions rather to prioritize suggestions coming from teachers than those coming from students. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 28010] New: add plugin to modify record in "opac-detail.pl"
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28010 Bug ID: 28010 Summary: add plugin to modify record in "opac-detail.pl" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)trust-box.at QA Contact: testopia(a)bugs.koha-community.org Created attachment 118560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118560&action=e… patch to opac-detail.pl I (guess I) need the abiltiy to change how records are beeing display in in opac-detail.pl Specifically I want to change the content of a record depending if a user is logged in or not for ebook renting So it would be great to have the ability to have a plugin hook there, something like 1 diff --git a/opac-detail.pl.orig b/opac-detail.pl 2 index e74cf4b..b46eb90 100755 3 --- a/opac-detail.pl.orig 4 +++ b/opac-detail.pl 5 @@ -217,6 +217,16 @@ if ( $xslfile ) { 6 $variables = { %$variables, %$plugin_variables }; 7 } 8 9 + $record = Koha::Plugins->call_apply( 10 + 'munge_record', 11 + $record, 12 + { 13 + patron => $patron, 14 + interface => 'opac', 15 + caller => 'opac-detail', 16 + } 17 + ); 18 + additionally I have a proposal to extend/modify the plugin system a little bit: I don't like the idea very much that the caller of a plugin has to take care of merging the results so the first step would be to add the ability that a plugin works recursively on a variable diff --git a/Plugins.pm.orig b/Plugins.pm index 11d44dc..71461de 100644 --- a/Plugins.pm.orig +++ b/Plugins.pm @@ -82,6 +82,35 @@ sub call { return @responses; } +=head2 call_apply + +Calls a plugin method for all enabled plugins, reworking on the same input and returning it. +ideally the caller of a plugin must not know how to merge the results +so maybe also implement a "merge" method in the plugin + + @responses = Koha::Plugins->call_apply($method, $work_var, @args) + +=cut + +sub call_apply { + my ($class, $method, $work_var, @args) = @_; + + if (C4::Context->config('enable_plugins')) { + my @plugins = $class->new({ enable_plugins => 1 })->GetPlugins({ method => $method }); + @plugins = grep { $_->can($method) } @plugins; + foreach my $plugin (@plugins) { + my $work_var = eval { $plugin->$method($work_var, @args) }; + if ($@) { + warn sprintf("Plugin error (%s): %s", $plugin->get_metadata->{name}, $@); + next; + } + } + + } + return $work_var; +} + + =head2 GetPlugins In another my idea would be to have an optional "merge" method for a certain type of plugins to avoid code like 206 207 my @plugin_responses = Koha::Plugins->call( 208 'opac_detail_xslt_variables', 209 { 210 biblio_id => $biblionumber, 211 lang => $lang, 212 patron_id => $borrowernumber 213 214 } 215 ); 216 for my $plugin_variables ( @plugin_responses ) { 217 $variables = { %$variables, %$plugin_variables }; 218 } 219 and be able to write something along the lines of 206 207 my $variables = Koha::Plugins->call( 208 'opac_detail_xslt_variables', + $variables, 209 { 210 biblio_id => $biblionumber, 211 lang => $lang, 212 patron_id => $borrowernumber 213 214 } 215 ); I hope I haven't packed to much into one issue, thanks a lot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 32352] New: xt/check_makefile.t failing on node_modules
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Bug ID: 32352 Summary: xt/check_makefile.t failing on node_modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 21:55:20 koha_1 | # Failed test 'All directories must be listed in Makefile.PL' 21:55:20 koha_1 | # at xt/check_makefile.t line 39. 21:55:20 koha_1 | # got: '1' 21:55:20 koha_1 | # expected: '0' 21:55:20 koha_1 | # $VAR1 = [ 21:55:20 koha_1 | # './node_modules' 21:55:20 koha_1 | # ]; -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 26146] New: Patron duplicate matching - fuzzy matching?
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26146 Bug ID: 26146 Summary: Patron duplicate matching - fuzzy matching? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Koha doesn't have a middle name field so librarians may try to use the first name field to hold both first names and middle names. This means that Koha's duplicate patron feature doesn't work, e.g. Brian David Jones already exists on the system. Patron is added as Brian Jones. Koha doesn't find the duplicate patron, because it thinks "Brian" is different to "Brian David" OR Brian Jones already exists on the system. Patron is added as Brian David Jones. Koha doesn't find the duplicate patron, because it thinks "Brian David" is different to "Brian" Is it possible to have fuzzy matching on the first name field, so "Brian Jones" would match "Brian David Jones" and "Brian David Jones" would match "Brian Jones" ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 22449] New: Improve Elastic search facet setting UI
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 Bug ID: 22449 Summary: Improve Elastic search facet setting UI Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- As discussed on bug 18235, the UI of facet settings should be improved - probably make it separate tab on elastic search admin page. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 26303] New: [OMNIBUS] Preparing for Perl 7
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26303 Bug ID: 26303 Summary: [OMNIBUS] Preparing for Perl 7 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org https://www.perl.com/article/announcing-perl-7/ http://blogs.perl.org/users/brian_d_foy/2020/06/the-perl-7-tldr.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 22005] New: System preference DecreaseLoanHighHolds incorrectly counts the number of holds
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '23

24 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Bug ID: 22005 Summary: System preference DecreaseLoanHighHolds incorrectly counts the number of holds Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When using the system preference decreaseLoanHighHolds, if a library has this set to 1 hold. Then when the 1 person that has a hold on this item attempts to check it out, Koha will invoke the decreaseloanhighholds - although this hold is getting fulfilled. This system preference should only count holds that are not fulfilled instead of counting all the holds including the one that is getting checked out. In conclusion, Koha should disregard the first hold as this will get removed when the checkout happens instead of count it towards number of holds on the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 22457] New: OpacHiddenItemsExceptions should be moved to a category attribute
by bugzilla-daemon＠bugs.koha-community.org 23 Sep '23

23 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Bug ID: 22457 Summary: OpacHiddenItemsExceptions should be moved to a category attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- In order to determine if an item should be hidden for a specific patron category, we now need to: - Read and parse OpacHiddenItemsExceptions - Verify it is a real category (subject to typos) - Compare to the current patron category This would be avoided by just having an attribute on the categories table (e.g. overrides_hidding_policy). I leave choosing the right attribute name to native speakers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 22471] New: Default Finnish values for web installer
by bugzilla-daemon＠bugs.koha-community.org 23 Sep '23

23 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Bug ID: 22471 Summary: Default Finnish values for web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- Add default Finnish values for web installer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 22486] New: Limit Patron expiry notices by category
by bugzilla-daemon＠bugs.koha-community.org 23 Sep '23

23 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22486 Bug ID: 22486 Summary: Limit Patron expiry notices by category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3