February 2023 - Koha-bugs - lists.koha-community.org

[Bug 33011] New: Capitalization: Show in Staff interface?
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33011 Bug ID: 33011 Summary: Capitalization: Show in Staff interface? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt 64 <label for="filter_edit_staff_client">Show in Staff interface?</label> Shoudl be "staff interface" -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 23422] New: CART location feature
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23422 Bug ID: 23422 Summary: CART location feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Why was the CART feature made to be a stored value? I am curious why a preference wasn't setup for an hour value, and if an item location is displayed anywhere, this setting could be compared to the timestamp and current time and if it is within the value entered, just display CART or Recently Returned or whatever next to the location. I know it would take changing things in several locations, but it seems this would be much more stable, and would also be less information to store. I don't know if it would cause a performance issue or not. Just thought I'd throw this out there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 32437] New: When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Bug ID: 32437 Summary: When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1 - Stage the sample file on this report using the options below (If not using sample database simply save a record as marc from the details page, then change the title in the interface and import the saved version) 2 - Make sure to match using KohaBiblio (999c) 3 - Set option "Replace existing record" if match found 4 - Once record is staged go to Acquisitions 5 - Find a vendor and select/create an open basket 6 - Add to basket from the staged file 7 - Add order info and save 8 - Check the record, title is unchanged - Sample file should add 'New and improved!' 9 - Check the staged records batch - note the diff shows that new record should have overwritten -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 49

[Bug 32883] New: Curbside pickups - Order "To be staged" by date and time of scheduled pickup
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Bug ID: 32883 Summary: Curbside pickups - Order "To be staged" by date and time of scheduled pickup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The entries in the "To be staged" tab in the curbside pickup module should be ordered by date and time of the scheduled pickup so that we can address the most pressing/the soonest first. Right now, I'm not sure how they are ordered... Maybe in the order they were scheduled? To test: 1. Enable the CurbsidePickup system preference 2. Set up curbside pickup for a library (e.g. Centerville) 2.1. Go to Administration > Curbside pickup 2.2. Click the tab for the library 2.3. Fill out the form: - Enable: Check - Pickup interval: 10 (or other) - Maximum patrons per interval: 3 (or other) - Patron-scheduled pickup: leave unchecked - Enable for waiting holds only: leave unchecked 2.4. Enter a couple of time periods (e.g. - Day: Sunday - From: 10:00 - To: 12:00 2.5. Click 'Add' 2.6. Click 'Save configuration' 3. Schedule a pickup 3.1. Go to Circulation > Curbside pickups 3.2. Click 'Schedule pickup' 3.3. Search for a patron name (e.g. Henry) 3.4. Pick a date 3.5. Pick a time (not the first one, e.g. 10:50) 3.6. Click 'Submit' 4. Schedule a second pickup, in a time slot before the other one 4.1. Search for a patron name (e.g. Edna) 4.2. Pick the same date 4.3. Pick a time before the time selected in step 3.5 (e.g. 10:10) 4.4. Submit 5. Check the "To be staged" tab --> Pickups are not ordered from soonest to latest pickup time I think the table should maybe be a datatable with column configuration, search boxes and the arrows to order a column, to match all other tables in Koha, with the default order on the 'Pickup date/time' column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 33060] New: Fix yes/no setting to 1/0 in system preference YAML files
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33060 Bug ID: 33060 Summary: Fix yes/no setting to 1/0 in system preference YAML files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: katrin.fischer(a)bsz-bw.de Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 32713] New: x-koha-embed appears to no longer properly validate
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32713 Bug ID: 32713 Summary: x-koha-embed appears to no longer properly validate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com CC: tomascohen(a)gmail.com We migrated x-koha-embed into properly specified header parameters in bug 30536 however it appears that the upstream validation of those headers has since broken and we're now allowing open embed calls through from the API. At best this can lead to server errors leaking, at worst it exposed methods that should be private to the API. We need to write some tests to catch this and possibly re-instate the in-koha validation whilst the OpenAPI is updated. See 8e1265c45ddfc53d4bcbfc51e25b297e3592daf4 for some further details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 32421] New: Add collection ( ccode ) column to holds to pull
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32421 Bug ID: 32421 Summary: Add collection ( ccode ) column to holds to pull Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Some libraries would find it helpful to include a column for collection to the holds to pull page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 32118] New: Clarify expansion/embed modifiers
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118 Bug ID: 32118 Summary: Clarify expansion/embed modifiers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com CC: tomascohen(a)gmail.com With bug 26635 we add a new additive function to the embed header options.. +av_expand.. this is a special case in that it's not just pulling in a related object, but also setting a flag to expand coded values and embed them within their own structure. We also have +relation_count.. to add a single field in a parent structure to just return the 'count' of a relation.. I think we should use :relation_count for this case? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 32923] New: x-koha-embed must be an enum
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Bug ID: 32923 Summary: x-koha-embed must be an enum Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: REST API Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com CC: tomascohen(a)gmail.com See bug 30536, since then new patches added more x-koha-embed not being enum. % git grep x-koha-embed api/v1/swagger/paths/|grep -v 'name: x-koha-embed' -- You are receiving this mail because: You are watching all bug changes.

1 67

[Bug 32556] New: borrower_message_preference_id reaches limit
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '23

24 Apr '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 Bug ID: 32556 Summary: borrower_message_preference_id reaches limit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Symptom: Adding a new patron gives a 500 error. plack-error.log: C4::Members::Messaging::SetMessagingPreference(): DBI Exception: DBD::mysql::st execute failed: Out of range value for column 'borrower_message_preference_id' at row 1 at /usr/share/koha/lib/C4/Form/MessagingPreferences.pm line 98 MariaDB [koha]> select max(borrower_message_preference_id) from borrower_message_preferences; +-------------------------------------+ | max(borrower_message_preference_id) | +-------------------------------------+ | 2147475728 | +-------------------------------------+ 1 row in set (0.000 sec) MariaDB [koha]> show create table borrower_message_preferences\G *************************** 1. row *************************** Table: borrower_message_preferences Create Table: CREATE TABLE `borrower_message_preferences` ( `borrower_message_preference_id` int(11) NOT NULL AUTO_INCREMENT, `borrowernumber` int(11) DEFAULT NULL, `categorycode` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `message_attribute_id` int(11) DEFAULT 0, `days_in_advance` int(11) DEFAULT 0, `wants_digest` tinyint(1) NOT NULL DEFAULT 0, PRIMARY KEY (`borrower_message_preference_id`), KEY `borrowernumber` (`borrowernumber`), KEY `categorycode` (`categorycode`), KEY `message_attribute_id` (`message_attribute_id`), CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_message_preferences_ibfk_2` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB AUTO_INCREMENT=2147483648 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 1 row in set (0.000 sec) The site where this happens runs a nightly import from a student registration system, so patrons are updated frequently. Two questions: 1. How do we fix this for sites that reach the limit? I tried to disable foreign key checks and alter the column from signed to unsigned, but that did not work: MariaDB [koha]> SET FOREIGN_KEY_CHECKS=0; Query OK, 0 rows affected (0.000 sec) MariaDB [koha]> ALTER TABLE borrower_message_preferences MODIFY borrower_message_preference_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT; ERROR 1025 (HY000): Error on rename of './koha_hkr/#sql-3d8_41ab0' to './koha_hkr/borrower_message_preferences' (errno: 150 "Foreign key constraint is incorrectly formed") 2. How do we make sure this never happens? To extend the period before this happens, it might be a quick fix to change the borrower_message_preference_id column from SIGNED (the default) to UNSIGNED. As far as I can tell, this would double the number of IDs the column can hold. A better solution might be to make the borrower_message_preferences update in place, and not generate new borrower_message_preference_id's every time they are updated? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13