February 2023 - Koha-bugs - lists.koha-community.org

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145656|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146998&action=e… Bug 14367: Updated schema files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145655|0 |1 is obsolete| | --- Comment #72 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146997&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Update the database, update the schema files, restart services * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145673|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146992&action=e… Bug 6796: Updated schema files -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145672|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146991&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Auckland University of Technology Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145671|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146990&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursWhenIssuing' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursWhenIssuing. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursWhenIssuing to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145670|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146989&action=e… Bug 6796: ConsiderLibraryHoursWhenIssuing system preference -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145669|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146988&action=e… Bug 6796: Add branch_hours table and set opening hours for library -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '23

21 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #160 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 146987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146987&action=e… Bug 3150: Include host item entries in LIST and CART notices Incorporating fixes from Bug 16522 -- You are receiving this mail because: You are watching all bug changes.

1 0