February 2023 - Koha-bugs - lists.koha-community.org

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #25 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146295&action=e… Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <<today>> <h1>Discharge confirmation</h1> <p style="background-color: yellow;"><<branches.branchname>> certifies that the following borrower:<br> <<borrowers.firstname>> <<borrowers.surname>> (cardnumber: <<borrowers.cardnumber>>)<br> has returned all items.</p> 3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146168|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32793] New: import_patrons.pl typo in usage
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Bug ID: 32793 Summary: import_patrons.pl typo in usage Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: pedro.amorim(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 32785] New: Typo: Maximum number of simultaneus pickups per interval (curbside pickups)
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Bug ID: 32785 Summary: Typo: Maximum number of simultaneus pickups per interval (curbside pickups) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org In the curbside pickup configuration page, there is a small typo Maximum number of simultaneus pickups per interval should be "simultaneous" To get there: 1. Enable the CurbsidePickup system preferences 2. Go to Administration > Curbside pickup --> Next to Maximum patrons per interval, the tip is "Maximum number of simultaneus pickups per interval" -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 32889] New: Improve audio alert page
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32889 Bug ID: 32889 Summary: Improve audio alert page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org A couple things I noticed on audio_alerts.tt that could be better: Add/edit an alert: The breadcrumbs don't change. When adding an alert the breadcrumbs should be something like: Administration > Audio alerts > New alert When editing they should be something like: Administration > Audio alerts > Modify audio alert 'X' Also when adding/editing: If you use your browsers back button you are taken back to the Administration main page when you should go back to the Audio alerts main page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 32673] New: Remove misc/load_testing/ scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 Bug ID: 32673 Summary: Remove misc/load_testing/ scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We are spending too much time trying to package HTTPD::Bench::ApacheBench, and this dependency is only used by misc/load_testing scripts I am not sure this is even used by anyone, and I didn't manage to make them work (just spent 5 min however): $ perl misc/load_testing/benchmark_staff.pl --url=http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/ --user=koha --password=koha --steps=123456 Authentication successful -------------- Koha STAFF benchmarking utility -------------- Benchmarking with 20 occurrences of each operation and 30 concurrent sessions Step 1: staff interface main page 36ms 555.555 pages/sec Step 2: catalog detail page 34ms 588.235 biblios/sec Step 3: catalogue search 35ms 571.428 biblios/sec Step 4: patron detail page 28ms 714.285 borrowers/sec Step 5: patron search page 69ms 579.71 borrowers/sec Step 6a circulation (checkouts) 35ms 571.428 checkouts/sec Step 6b circulation (checkins) 36ms 555.555 checkins/sec Skipping 'testing all transactions at once' That does not seems correct (too fast). Moreover D12 is currently failing (00-strict.t because of missing deps) Mason did the work but it's not there yet: https://salsa.debian.org/perl-team/modules/packages/libhttpd-bench-apachebe… What do we want? I would vote for removing the script and the dependency. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '23

06 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Patrick Robitaille <patrick.robitaille(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0