February 2023 - Koha-bugs - lists.koha-community.org

[Bug 31261] New: Curbside pickups - remove dates in the past
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261 Bug ID: 31261 Summary: Curbside pickups - remove dates in the past Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 30650 We are displaying all the dates from the date picker widget, we should display future dates only. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Convert the Curbside Pickup plugin to Koha core -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 32442] New: Invalid Template Toolkit in notices can cause broader errors
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32442 Bug ID: 32442 Summary: Invalid Template Toolkit in notices can cause broader errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I have been noticing something while testing notices lately that I wanted to point out and see if anyone else can recreate, this is happening for me in KTD: To recreate: 1. Go to any notice and create some invalid Template Toolkit: [% IF ( 1 == 1 %] test [% END %] 2. Save and continue 3. Notice the Template Toolkit error: This is good. 3. Correct the error: [% IF ( 1 == 1 ) %] test [% END %] 4. Now save again. This time I see the Template Toolkit error like: DBIx::Class::Storage::DBI::mysql::_exec_svp_rollback(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist at /kohadevbox/koha/C4/Letters.pm line 1624 5. Save anyways 6. Logout of Koha and attempt to log back in: It explodes with this error: {UNKNOWN}: Transaction aborted: DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_4 does not exist at /kohadevbox/koha/Koha/Object.pm line 170 . Rollback failed: DBIx::Class::Storage::DBI::mysql::_exec_svp_rollback(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_3 does not exist at /kohadevbox/koha/Koha/Patron.pm line 363 at /kohadevbox/koha/Koha/Patron.pm line 363 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 32738] New: Correct upload local cover image title tag
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Bug ID: 32738 Summary: Correct upload local cover image title tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 26703 The upload local cover image template still uses the old sequence of breadcrumb details: Koha -> Cataloging -> Upload local cover images (see Bug 26703 - Modify the "title" elements to contain unique information first). These elements should be reversed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 [Bug 26703] Modify the "title" elements to contain unique information first -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #23 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146170&action=e… Bug 14251: Add weasyprint dependency Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #22 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146169&action=e… Bug 14251: Add warning in about.pl for missing weasyprint To test: 1. Have weasyprint installed 2. Go to the About > System information page => SUCCESS: No warning about weasyprint 3. Uninstall weasyprint 4. Repeat 2 => SUCCESS: A warning is displayed and makes sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #21 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 146168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146168&action=e… Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <<today>> <h1>Discharge confirmation</h1> <p style="background-color: yellow;"><<branches.branchname>> certifies that the following borrower:<br> <<borrowers.firstname>> <<borrowers.surname>> (cardnumber: <<borrowers.cardnumber>>)<br> has returned all items.</p> 3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14251] Allow use of CSS in discharge letter
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '23

03 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0